From: Arnd Bergmann <arnd@arndb.de>
To: Tomasz Figa <t.figa@samsung.com>
Cc: Chander Kashyap <chander.kashyap@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
"thomas.ab@samsung.com" <thomas.ab@samsung.com>,
"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>
Subject: Re: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework
Date: Tue, 18 Jun 2013 19:13:45 +0200 [thread overview]
Message-ID: <201306181913.45484.arnd@arndb.de> (raw)
In-Reply-To: <9285029.CIld1HyBWB@amdc1227>
On Tuesday 18 June 2013, Tomasz Figa wrote:
> This is a binding that has been defined for Samsung Common Clock Framework
> drivers. Exynos4 and Exynos5250 use the same convention. The numbers are
> defined in a way that should allow adding further clocks of particular types in
> future as need for such shows up.
I see, it's probably too late to change that then. Maybe if there is an Exynos6
this should be done differently though.
> Physically there is one clock controller (CMU) which has a lot of dividers,
> muxes and gates and so it is represented as a single device node.
Some platforms just put device nodes for their clocks under the clock controller
node, which would have helped here. Another option would be to use #clock-cells=<2>
and make the first cell the type of the clock, and the second one the number.
Also, if I understand things correctly, simple fixed rate clocks would normally
not go into the clock driver at all when they are not controller by it.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework
Date: Tue, 18 Jun 2013 19:13:45 +0200 [thread overview]
Message-ID: <201306181913.45484.arnd@arndb.de> (raw)
In-Reply-To: <9285029.CIld1HyBWB@amdc1227>
On Tuesday 18 June 2013, Tomasz Figa wrote:
> This is a binding that has been defined for Samsung Common Clock Framework
> drivers. Exynos4 and Exynos5250 use the same convention. The numbers are
> defined in a way that should allow adding further clocks of particular types in
> future as need for such shows up.
I see, it's probably too late to change that then. Maybe if there is an Exynos6
this should be done differently though.
> Physically there is one clock controller (CMU) which has a lot of dividers,
> muxes and gates and so it is represented as a single device node.
Some platforms just put device nodes for their clocks under the clock controller
node, which would have helped here. Another option would be to use #clock-cells=<2>
and make the first cell the type of the clock, and the second one the number.
Also, if I understand things correctly, simple fixed rate clocks would normally
not go into the clock driver at all when they are not controller by it.
Arnd
next prev parent reply other threads:[~2013-06-18 17:14 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 11:00 [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:38 ` Kukjin Kim
2013-06-17 11:38 ` Kukjin Kim
2013-06-18 4:24 ` Chander Kashyap
2013-06-18 4:24 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:45 ` Kukjin Kim
2013-06-17 11:45 ` Kukjin Kim
2013-06-18 10:31 ` Kukjin Kim
2013-06-18 10:31 ` Kukjin Kim
2013-06-18 15:19 ` 'Greg Kroah-Hartman'
2013-06-18 15:19 ` 'Greg Kroah-Hartman'
2013-06-17 11:00 ` [PATCH v3 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:49 ` Kukjin Kim
2013-06-17 11:49 ` Kukjin Kim
2013-06-17 12:27 ` Arnd Bergmann
2013-06-17 12:27 ` Arnd Bergmann
2013-06-18 4:09 ` Chander Kashyap
2013-06-18 4:09 ` Chander Kashyap
2013-06-18 14:01 ` Arnd Bergmann
2013-06-18 14:01 ` Arnd Bergmann
2013-06-18 14:26 ` Tomasz Figa
2013-06-18 14:26 ` Tomasz Figa
2013-06-18 17:13 ` Arnd Bergmann [this message]
2013-06-18 17:13 ` Arnd Bergmann
2013-06-17 11:00 ` [PATCH v3 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:44 ` Tomasz Figa
2013-06-17 11:44 ` Tomasz Figa
2013-06-18 4:21 ` Chander Kashyap
2013-06-18 4:21 ` Chander Kashyap
2013-06-18 7:36 ` Tomasz Figa
2013-06-18 7:36 ` Tomasz Figa
2013-06-17 11:00 ` [PATCH v3 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:53 ` Kukjin Kim
2013-06-17 11:53 ` Kukjin Kim
2013-06-18 4:11 ` Chander Kashyap
2013-06-18 4:11 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-17 11:00 ` Chander Kashyap
2013-06-17 12:21 ` Arnd Bergmann
2013-06-17 12:21 ` Arnd Bergmann
2013-06-18 4:10 ` Chander Kashyap
2013-06-18 4:10 ` Chander Kashyap
2013-06-17 11:45 ` [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Tomasz Figa
2013-06-17 11:45 ` Tomasz Figa
2013-06-17 11:56 ` Kukjin Kim
2013-06-17 11:56 ` Kukjin Kim
2013-06-18 4:28 ` Chander Kashyap
2013-06-18 4:28 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306181913.45484.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=chander.kashyap@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.