All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver
Date: Fri, 21 Jun 2013 13:41:53 +0200	[thread overview]
Message-ID: <201306211341.53928.arnd@arndb.de> (raw)
In-Reply-To: <20130621104355.GG23141@intel.com>

On Friday 21 June 2013, Vinod Koul wrote:
> On Mon, Jun 17, 2013 at 10:58:07PM +0200, Arnd Bergmann wrote:
> > On Monday 17 June 2013, Zhangfei Gao wrote:
> >
> > int dma_get_slave_channel(struct dma_chan *chan)
> > {
> >       /* lock against __dma_request_channel */
> >       mutex_lock(&dma_list_mutex);
> > 
> >       if (chan->client_count == 0)
> >               ret = dma_chan_get(chan);
> >       else    
> >               ret = -EBUSY;
> > 
> >       mutex_unlock(&dma_list_mutex);
> > 
> >       return ret;
> > }
> > EXPORT_SYMBOL_GPL(dma_get_slave_channel);
> and you add filter on top?

No, the idea is to no longer require a filter function when
we use dma_request_slave_channel with a DT specifier.

> This is getting you any channel and maynot work where we need to do some
> filtering. 

This function would be called only by the dmaengine driver's
xlate function. That driver obviously has to ensure that the
channel works for the specification from DT (or ACPI or
something else), but that part is easy, since that is
the same information that we currently pass into the filter
function.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Zhangfei Gao
	<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver
Date: Fri, 21 Jun 2013 13:41:53 +0200	[thread overview]
Message-ID: <201306211341.53928.arnd@arndb.de> (raw)
In-Reply-To: <20130621104355.GG23141-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Friday 21 June 2013, Vinod Koul wrote:
> On Mon, Jun 17, 2013 at 10:58:07PM +0200, Arnd Bergmann wrote:
> > On Monday 17 June 2013, Zhangfei Gao wrote:
> >
> > int dma_get_slave_channel(struct dma_chan *chan)
> > {
> >       /* lock against __dma_request_channel */
> >       mutex_lock(&dma_list_mutex);
> > 
> >       if (chan->client_count == 0)
> >               ret = dma_chan_get(chan);
> >       else    
> >               ret = -EBUSY;
> > 
> >       mutex_unlock(&dma_list_mutex);
> > 
> >       return ret;
> > }
> > EXPORT_SYMBOL_GPL(dma_get_slave_channel);
> and you add filter on top?

No, the idea is to no longer require a filter function when
we use dma_request_slave_channel with a DT specifier.

> This is getting you any channel and maynot work where we need to do some
> filtering. 

This function would be called only by the dmaengine driver's
xlate function. That driver obviously has to ensure that the
channel works for the specification from DT (or ACPI or
something else), but that part is easy, since that is
the same information that we currently pass into the filter
function.

	Arnd

  reply	other threads:[~2013-06-21 11:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17  4:54 [PATCH] dmaengine: Add hisilicon k3 DMA engine driver Zhangfei Gao
2013-06-17  4:54 ` Zhangfei Gao
2013-06-17 20:58 ` Arnd Bergmann
2013-06-17 20:58   ` Arnd Bergmann
2013-06-18  2:33   ` zhangfei gao
2013-06-18  2:33     ` zhangfei gao
2013-06-18 14:09     ` Arnd Bergmann
2013-06-18 14:09       ` Arnd Bergmann
2013-06-18 14:22       ` zhangfei
2013-06-18 14:22         ` zhangfei
2013-06-18 15:08         ` Arnd Bergmann
2013-06-18 15:08           ` Arnd Bergmann
2013-06-21 10:49           ` Vinod Koul
2013-06-21 10:49             ` Vinod Koul
2013-06-21 10:45       ` Vinod Koul
2013-06-21 10:45         ` Vinod Koul
2013-06-21 10:43   ` Vinod Koul
2013-06-21 10:43     ` Vinod Koul
2013-06-21 11:41     ` Arnd Bergmann [this message]
2013-06-21 11:41       ` Arnd Bergmann
2013-06-24  8:49       ` zhangfei gao
2013-06-24  8:49         ` zhangfei gao
2013-06-24 16:15         ` Arnd Bergmann
2013-06-24 16:15           ` Arnd Bergmann
2013-06-25  5:34           ` zhangfei gao
2013-06-25  5:34             ` zhangfei gao
2013-06-21 10:40 ` Vinod Koul
2013-06-21 10:40   ` Vinod Koul
2013-06-25  5:34   ` zhangfei gao
2013-06-25  5:34     ` zhangfei gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306211341.53928.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.