From: Thierry Reding <thierry.reding@gmail.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: "Kukjin Kim" <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>,
"Olof Johansson" <olof@lixom.net>,
"Sylwester Nawrocki" <sylvester.nawrocki@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Mark Brown" <broonie@kernel.org>,
"Thomas Abraham" <thomas.abraham@linaro.org>
Subject: Re: [PATCH v3 11/18] pwm: Add new pwm-samsung driver
Date: Tue, 25 Jun 2013 12:26:47 +0200 [thread overview]
Message-ID: <20130625102646.GC21137@manwe> (raw)
In-Reply-To: <1405696.in3RSSDWnX@flatron>
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
On Mon, Jun 24, 2013 at 11:17:03PM +0200, Tomasz Figa wrote:
> On Monday 24 of June 2013 22:53:42 Thierry Reding wrote:
> > On Mon, Jun 24, 2013 at 10:32:55PM +0200, Tomasz Figa wrote:
[...]
> > > What about:
> > >
> > > /*
> > >
> > > * PWM block is shared between pwm-samsung and samsung_pwm_timer
> > > drivers
> > > * and some registers need access synchronization. If both drivers are
> > > * compiled in, the spinlock is defined in the clocksource driver,
> > > * otherwise following definition is used.
> > > *
> > > * Currently we do not need any more complex synchronization method
> > > * because all the supported SoCs contain only one instance of the PWM
> > > * IP. Should this change, both drivers will need to be modified to
> > > * properly synchronize accesses to particular instances.
> > > */
> >
> > I see that you can't be persuaded. And everybody else seems to be okay
> > with it so... have it your way. I'm probably going to regret this.
>
> This was just a proposal. Do you want anything else to be added to the
> comment or anything to be changed?
For reference, I still don't like this but since I'm the only one
complaining, go ahead. With that comment added to the driver:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Heiko Stübner" <heiko@sntech.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Mark Brown" <broonie@kernel.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Thomas Abraham" <thomas.abraham@linaro.org>,
"Olof Johansson" <olof@lixom.net>,
"Sylwester Nawrocki" <sylvester.nawrocki@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 11/18] pwm: Add new pwm-samsung driver
Date: Tue, 25 Jun 2013 12:26:47 +0200 [thread overview]
Message-ID: <20130625102646.GC21137@manwe> (raw)
In-Reply-To: <1405696.in3RSSDWnX@flatron>
[-- Attachment #1.1: Type: text/plain, Size: 1302 bytes --]
On Mon, Jun 24, 2013 at 11:17:03PM +0200, Tomasz Figa wrote:
> On Monday 24 of June 2013 22:53:42 Thierry Reding wrote:
> > On Mon, Jun 24, 2013 at 10:32:55PM +0200, Tomasz Figa wrote:
[...]
> > > What about:
> > >
> > > /*
> > >
> > > * PWM block is shared between pwm-samsung and samsung_pwm_timer
> > > drivers
> > > * and some registers need access synchronization. If both drivers are
> > > * compiled in, the spinlock is defined in the clocksource driver,
> > > * otherwise following definition is used.
> > > *
> > > * Currently we do not need any more complex synchronization method
> > > * because all the supported SoCs contain only one instance of the PWM
> > > * IP. Should this change, both drivers will need to be modified to
> > > * properly synchronize accesses to particular instances.
> > > */
> >
> > I see that you can't be persuaded. And everybody else seems to be okay
> > with it so... have it your way. I'm probably going to regret this.
>
> This was just a proposal. Do you want anything else to be added to the
> comment or anything to be changed?
For reference, I still don't like this but since I'm the only one
complaining, go ahead. With that comment added to the driver:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 11/18] pwm: Add new pwm-samsung driver
Date: Tue, 25 Jun 2013 12:26:47 +0200 [thread overview]
Message-ID: <20130625102646.GC21137@manwe> (raw)
In-Reply-To: <1405696.in3RSSDWnX@flatron>
On Mon, Jun 24, 2013 at 11:17:03PM +0200, Tomasz Figa wrote:
> On Monday 24 of June 2013 22:53:42 Thierry Reding wrote:
> > On Mon, Jun 24, 2013 at 10:32:55PM +0200, Tomasz Figa wrote:
[...]
> > > What about:
> > >
> > > /*
> > >
> > > * PWM block is shared between pwm-samsung and samsung_pwm_timer
> > > drivers
> > > * and some registers need access synchronization. If both drivers are
> > > * compiled in, the spinlock is defined in the clocksource driver,
> > > * otherwise following definition is used.
> > > *
> > > * Currently we do not need any more complex synchronization method
> > > * because all the supported SoCs contain only one instance of the PWM
> > > * IP. Should this change, both drivers will need to be modified to
> > > * properly synchronize accesses to particular instances.
> > > */
> >
> > I see that you can't be persuaded. And everybody else seems to be okay
> > with it so... have it your way. I'm probably going to regret this.
>
> This was just a proposal. Do you want anything else to be added to the
> comment or anything to be changed?
For reference, I still don't like this but since I'm the only one
complaining, go ahead. With that comment added to the driver:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130625/f20e3970/attachment.sig>
next prev parent reply other threads:[~2013-06-25 10:26 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 22:12 [PATCH v2 00/18] Final Samsung PWM support cleanup Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 01/18] ARM: SAMSUNG: Unify base address definitions of timer block Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 02/18] ARM: SAMSUNG: Add new PWM platform device Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 03/18] ARM: SAMSUNG: Set PWM platform data Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 04/18] clocksource: samsung_pwm_timer: Cache clocksource register address Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 05/18] clocksource: samsung_pwm_timer: Do not use clocksource_mmio Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 06/18] clocksource: samsung_pwm_timer: Handle suspend/resume correctly Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 07/18] ARM: SAMSUNG: Move all platforms to new clocksource driver Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-24 15:33 ` Kukjin Kim
2013-06-24 15:33 ` Kukjin Kim
2013-06-24 15:38 ` Tomasz Figa
2013-06-24 15:38 ` Tomasz Figa
2013-06-24 15:46 ` Kukjin Kim
2013-06-24 15:46 ` Kukjin Kim
2013-06-24 15:49 ` Tomasz Figa
2013-06-24 15:49 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 08/18] ARM: SAMSUNG: Remove old samsung-time driver Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 09/18] ARM: SAMSUNG: Remove unused PWM timer IRQ chip code Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 10/18] pwm: samsung: Rename to pwm-samsung-legacy Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-22 13:09 ` [PATCH v3 " Tomasz Figa
2013-06-22 13:09 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 11/18] pwm: Add new pwm-samsung driver Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-22 13:06 ` [PATCH v3 " Tomasz Figa
2013-06-22 13:06 ` Tomasz Figa
2013-06-24 15:22 ` Kukjin Kim
2013-06-24 15:22 ` Kukjin Kim
2013-06-24 15:37 ` Tomasz Figa
2013-06-24 15:37 ` Tomasz Figa
2013-06-24 17:49 ` Thierry Reding
2013-06-24 17:49 ` Thierry Reding
2013-06-24 18:31 ` Tomasz Figa
2013-06-24 18:31 ` Tomasz Figa
2013-06-24 20:13 ` Thierry Reding
2013-06-24 20:13 ` Thierry Reding
2013-06-24 20:32 ` Tomasz Figa
2013-06-24 20:32 ` Tomasz Figa
2013-06-24 20:53 ` Thierry Reding
2013-06-24 20:53 ` Thierry Reding
2013-06-24 21:17 ` Tomasz Figa
2013-06-24 21:17 ` Tomasz Figa
2013-06-25 10:26 ` Thierry Reding [this message]
2013-06-25 10:26 ` Thierry Reding
2013-06-25 10:26 ` Thierry Reding
2013-06-25 11:19 ` Tomasz Figa
2013-06-25 11:19 ` Tomasz Figa
2013-06-25 15:18 ` Mark Brown
2013-06-25 15:18 ` Mark Brown
2013-06-25 16:41 ` Kukjin Kim
2013-06-25 16:41 ` Kukjin Kim
2013-06-25 16:30 ` Kukjin Kim
2013-06-25 16:30 ` Kukjin Kim
2013-06-20 22:12 ` [PATCH v2 12/18] ARM: SAMSUNG: Rework private data handling in dev-backlight Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 13/18] ARM: SAMSUNG: Modify board files to use new PWM platform device Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:12 ` [PATCH v2 14/18] pwm: Remove superseded pwm-samsung-legacy driver Tomasz Figa
2013-06-20 22:12 ` Tomasz Figa
2013-06-20 22:13 ` [PATCH v2 15/18] ARM: SAMSUNG: Remove old PWM timer platform devices Tomasz Figa
2013-06-20 22:13 ` Tomasz Figa
2013-06-20 22:13 ` [PATCH v2 16/18] ARM: SAMSUNG: Remove pwm-clock infrastructure Tomasz Figa
2013-06-20 22:13 ` Tomasz Figa
2013-06-20 22:13 ` [PATCH v2 17/18] ARM: SAMSUNG: Remove remaining uses of plat/regs-timer.h header Tomasz Figa
2013-06-20 22:13 ` Tomasz Figa
2013-06-20 22:13 ` [PATCH v2 18/18] ARM: SAMSUNG: Remove " Tomasz Figa
2013-06-20 22:13 ` Tomasz Figa
2013-06-20 23:05 ` [PATCH v2 00/18] Final Samsung PWM support cleanup Tomasz Figa
2013-06-20 23:05 ` Tomasz Figa
2013-06-21 14:04 ` Arnd Bergmann
2013-06-21 14:04 ` Arnd Bergmann
2013-06-21 14:04 ` Arnd Bergmann
2013-06-22 13:10 ` Tomasz Figa
2013-06-22 13:10 ` Tomasz Figa
2013-06-22 18:01 ` Heiko Stübner
2013-06-22 18:01 ` Heiko Stübner
2013-06-22 18:04 ` Tomasz Figa
2013-06-22 18:04 ` Tomasz Figa
2013-06-24 0:14 ` Kukjin Kim
2013-06-24 0:14 ` Kukjin Kim
2013-06-22 19:34 ` Sylwester Nawrocki
2013-06-22 19:34 ` Sylwester Nawrocki
2013-06-22 19:34 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625102646.GC21137@manwe \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sylvester.nawrocki@gmail.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.