From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting
Date: Mon, 1 Jul 2013 19:43:27 +0200 [thread overview]
Message-ID: <201307011943.27489.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5B5jh1XciO4K1u3yBcHHDAgi8hA3GcywnJd11M7=aOPxA@mail.gmail.com>
Dear Fabio Estevam,
> On Mon, Jul 1, 2013 at 12:33 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > On Mon, Jul 01, 2013 at 12:11:58PM -0300, Fabio Estevam wrote:
> >> On Mon, Jul 1, 2013 at 11:34 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> >> > And also why we do not see the impact of i2c issue on sgtl5000 before
> >> > the offending commit af8ee11 (ASoC: sgtl5000: Fix driver probe after
> >> > reset)?
> >>
> >> Probably because the mxs i2c was working before this commit.
> >
> > Do you have a commit id at which mxs i2c is known good? I would like to
> > find out it's a mxs i2c issue or sgtl5000 problem.
>
> I don't have it, but I am adding Alexandre in case he knows.
>
> Alexandre,
>
> Do you happen to know a commit id which does not show the mxs i2c
> timeouts you have been observing?
I think you can just disable the PIO mode altogether (around line 500 ... if
(msg->len < 8) ... replace this with if (0) ) and then the problem should not be
there (if it's a PIO problem).
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting
Date: Mon, 1 Jul 2013 19:43:27 +0200 [thread overview]
Message-ID: <201307011943.27489.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5B5jh1XciO4K1u3yBcHHDAgi8hA3GcywnJd11M7=aOPxA@mail.gmail.com>
Dear Fabio Estevam,
> On Mon, Jul 1, 2013 at 12:33 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > On Mon, Jul 01, 2013 at 12:11:58PM -0300, Fabio Estevam wrote:
> >> On Mon, Jul 1, 2013 at 11:34 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> >> > And also why we do not see the impact of i2c issue on sgtl5000 before
> >> > the offending commit af8ee11 (ASoC: sgtl5000: Fix driver probe after
> >> > reset)?
> >>
> >> Probably because the mxs i2c was working before this commit.
> >
> > Do you have a commit id at which mxs i2c is known good? I would like to
> > find out it's a mxs i2c issue or sgtl5000 problem.
>
> I don't have it, but I am adding Alexandre in case he knows.
>
> Alexandre,
>
> Do you happen to know a commit id which does not show the mxs i2c
> timeouts you have been observing?
I think you can just disable the PIO mode altogether (around line 500 ... if
(msg->len < 8) ... replace this with if (0) ) and then the problem should not be
there (if it's a PIO problem).
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-07-01 17:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 8:16 [PATCH 0/4] Fix mxs audio regressions Shawn Guo
2013-07-01 8:16 ` Shawn Guo
2013-07-01 8:16 ` [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting Shawn Guo
2013-07-01 8:16 ` Shawn Guo
2013-07-01 10:07 ` Mark Brown
2013-07-01 10:07 ` Mark Brown
2013-07-01 10:54 ` Marek Vasut
2013-07-01 10:54 ` Marek Vasut
2013-07-01 13:55 ` Shawn Guo
2013-07-01 13:55 ` Shawn Guo
2013-07-01 14:12 ` Fabio Estevam
2013-07-01 14:12 ` [alsa-devel] " Fabio Estevam
2013-07-01 14:26 ` Shawn Guo
2013-07-01 14:26 ` [alsa-devel] " Shawn Guo
2013-07-01 14:34 ` Shawn Guo
2013-07-01 14:34 ` [alsa-devel] " Shawn Guo
2013-07-01 15:11 ` Fabio Estevam
2013-07-01 15:11 ` [alsa-devel] " Fabio Estevam
2013-07-01 15:33 ` Shawn Guo
2013-07-01 15:33 ` [alsa-devel] " Shawn Guo
2013-07-01 15:42 ` Fabio Estevam
2013-07-01 15:42 ` [alsa-devel] " Fabio Estevam
2013-07-01 17:43 ` Marek Vasut [this message]
2013-07-01 17:43 ` Marek Vasut
2013-07-01 19:14 ` Fabio Estevam
2013-07-01 19:14 ` [alsa-devel] " Fabio Estevam
2013-07-01 19:28 ` Alexandre Belloni
2013-07-01 19:28 ` Alexandre Belloni
2013-07-02 2:16 ` Shawn Guo
2013-07-02 2:16 ` [alsa-devel] " Shawn Guo
2013-07-01 19:23 ` Alexandre Belloni
2013-07-01 19:23 ` Alexandre Belloni
2013-07-01 14:04 ` Shawn Guo
2013-07-01 14:04 ` Shawn Guo
2013-07-01 10:57 ` Lothar Waßmann
2013-07-01 10:57 ` Lothar Waßmann
2013-07-01 8:16 ` [PATCH 2/4] ASoC: sgtl5000: defer the probe if clock is not found Shawn Guo
2013-07-01 8:16 ` Shawn Guo
2013-07-01 9:45 ` Mark Brown
2013-07-01 9:45 ` Mark Brown
2013-07-01 11:33 ` Russell King - ARM Linux
2013-07-01 11:33 ` Russell King - ARM Linux
2013-07-01 12:51 ` Mark Brown
2013-07-01 12:51 ` Mark Brown
2013-07-01 8:16 ` [PATCH 3/4] ASoC: mxs: register saif mclk to clock framework Shawn Guo
2013-07-01 8:16 ` Shawn Guo
2013-07-01 10:11 ` Mark Brown
2013-07-01 10:11 ` Mark Brown
2013-07-01 8:16 ` [PATCH 4/4] ARM: mxs: saif0 is the clock provider to sgtl5000 Shawn Guo
2013-07-01 8:16 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307011943.27489.marex@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.