All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@denx.de>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting
Date: Mon, 01 Jul 2013 21:28:26 +0200	[thread overview]
Message-ID: <51D1D85A.8060807@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5DtgahX3WLdM-P9=ODhJVMTRHFuS9=6zHQiS9-3wCJcmA@mail.gmail.com>

Hi,

On 01/07/2013 21:14, Fabio Estevam wrote:
> Hi Marek,
> 
> On Mon, Jul 1, 2013 at 2:43 PM, Marek Vasut <marex@denx.de> wrote:
> 
>> I think you can just disable the PIO mode altogether (around line 500 ... if
>> (msg->len < 8) ... replace this with if (0) ) and then the problem should not be
>> there (if it's a PIO problem).
> 
> Yes, this is a good suggestion.
> 
> This is what I did on 3.10 kernel:
> 
> - Booted a 3.10 kernel, audio is probed correctly
> 
> - Enabled touchscreen:
> 

It definitely seems to be an issue with PIO mode as the investigation
from Torsten Fleischer showed. I'll test that on my boards tonight. I'll
also try to remove the touchscreen support to see if I observe the same
thing as you do.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting
Date: Mon, 01 Jul 2013 21:28:26 +0200	[thread overview]
Message-ID: <51D1D85A.8060807@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5DtgahX3WLdM-P9=ODhJVMTRHFuS9=6zHQiS9-3wCJcmA@mail.gmail.com>

Hi,

On 01/07/2013 21:14, Fabio Estevam wrote:
> Hi Marek,
> 
> On Mon, Jul 1, 2013 at 2:43 PM, Marek Vasut <marex@denx.de> wrote:
> 
>> I think you can just disable the PIO mode altogether (around line 500 ... if
>> (msg->len < 8) ... replace this with if (0) ) and then the problem should not be
>> there (if it's a PIO problem).
> 
> Yes, this is a good suggestion.
> 
> This is what I did on 3.10 kernel:
> 
> - Booted a 3.10 kernel, audio is probed correctly
> 
> - Enabled touchscreen:
> 

It definitely seems to be an issue with PIO mode as the investigation
from Torsten Fleischer showed. I'll test that on my boards tonight. I'll
also try to remove the touchscreen support to see if I observe the same
thing as you do.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-07-01 19:28 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01  8:16 [PATCH 0/4] Fix mxs audio regressions Shawn Guo
2013-07-01  8:16 ` Shawn Guo
2013-07-01  8:16 ` [PATCH 1/4] ASoC: sgtl5000: give it a ramping time before writting Shawn Guo
2013-07-01  8:16   ` Shawn Guo
2013-07-01 10:07   ` Mark Brown
2013-07-01 10:07     ` Mark Brown
2013-07-01 10:54     ` Marek Vasut
2013-07-01 10:54       ` Marek Vasut
2013-07-01 13:55       ` Shawn Guo
2013-07-01 13:55         ` Shawn Guo
2013-07-01 14:12       ` Fabio Estevam
2013-07-01 14:12         ` [alsa-devel] " Fabio Estevam
2013-07-01 14:26         ` Shawn Guo
2013-07-01 14:26           ` [alsa-devel] " Shawn Guo
2013-07-01 14:34           ` Shawn Guo
2013-07-01 14:34             ` [alsa-devel] " Shawn Guo
2013-07-01 15:11             ` Fabio Estevam
2013-07-01 15:11               ` [alsa-devel] " Fabio Estevam
2013-07-01 15:33               ` Shawn Guo
2013-07-01 15:33                 ` [alsa-devel] " Shawn Guo
2013-07-01 15:42                 ` Fabio Estevam
2013-07-01 15:42                   ` [alsa-devel] " Fabio Estevam
2013-07-01 17:43                   ` Marek Vasut
2013-07-01 17:43                     ` [alsa-devel] " Marek Vasut
2013-07-01 19:14                     ` Fabio Estevam
2013-07-01 19:14                       ` [alsa-devel] " Fabio Estevam
2013-07-01 19:28                       ` Alexandre Belloni [this message]
2013-07-01 19:28                         ` Alexandre Belloni
2013-07-02  2:16                     ` Shawn Guo
2013-07-02  2:16                       ` [alsa-devel] " Shawn Guo
2013-07-01 19:23                   ` Alexandre Belloni
2013-07-01 19:23                     ` Alexandre Belloni
2013-07-01 14:04     ` Shawn Guo
2013-07-01 14:04       ` Shawn Guo
2013-07-01 10:57   ` Lothar Waßmann
2013-07-01 10:57     ` Lothar Waßmann
2013-07-01  8:16 ` [PATCH 2/4] ASoC: sgtl5000: defer the probe if clock is not found Shawn Guo
2013-07-01  8:16   ` Shawn Guo
2013-07-01  9:45   ` Mark Brown
2013-07-01  9:45     ` Mark Brown
2013-07-01 11:33     ` Russell King - ARM Linux
2013-07-01 11:33       ` Russell King - ARM Linux
2013-07-01 12:51       ` Mark Brown
2013-07-01 12:51         ` Mark Brown
2013-07-01  8:16 ` [PATCH 3/4] ASoC: mxs: register saif mclk to clock framework Shawn Guo
2013-07-01  8:16   ` Shawn Guo
2013-07-01 10:11   ` Mark Brown
2013-07-01 10:11     ` Mark Brown
2013-07-01  8:16 ` [PATCH 4/4] ARM: mxs: saif0 is the clock provider to sgtl5000 Shawn Guo
2013-07-01  8:16   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D1D85A.8060807@free-electrons.com \
    --to=alexandre.belloni@free-electrons.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.