From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
Date: Sat, 6 Jul 2013 10:19:25 +0100 [thread overview]
Message-ID: <20130706091925.GL27646@sirena.org.uk> (raw)
In-Reply-To: <2269980.iUpB0kJaI3@flatron>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Sat, Jul 06, 2013 at 01:36:57AM +0200, Tomasz Figa wrote:
> On Monday 01 of July 2013 22:36:37 Mark Brown wrote:
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> Are the two #properties above really necessary? The regulators that will
> be placed here probably don't need any kind of addressing, so it should be
> possible to omit them.
I believe they're required boilerplate for a correct DT bus.
> > +
> > + mmc_reg: voltage-regulator {
> I'd suggest suffixing name of this node with an index, like voltage-
> regulator-0 to be more future proof, in case of further fixed regulators
> being added.
If you want to rename things that's a separate thing so should be a
separate patch - this patch is just about moving the existing devices
onto a bus.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus
Date: Sat, 6 Jul 2013 10:19:25 +0100 [thread overview]
Message-ID: <20130706091925.GL27646@sirena.org.uk> (raw)
In-Reply-To: <2269980.iUpB0kJaI3@flatron>
On Sat, Jul 06, 2013 at 01:36:57AM +0200, Tomasz Figa wrote:
> On Monday 01 of July 2013 22:36:37 Mark Brown wrote:
> > + regulators {
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> Are the two #properties above really necessary? The regulators that will
> be placed here probably don't need any kind of addressing, so it should be
> possible to omit them.
I believe they're required boilerplate for a correct DT bus.
> > +
> > + mmc_reg: voltage-regulator {
> I'd suggest suffixing name of this node with an index, like voltage-
> regulator-0 to be more future proof, in case of further fixed regulators
> being added.
If you want to rename things that's a separate thing so should be a
separate patch - this patch is just about moving the existing devices
onto a bus.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130706/4f173dbe/attachment.sig>
next prev parent reply other threads:[~2013-07-06 9:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 21:36 [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Mark Brown
2013-07-01 21:36 ` Mark Brown
2013-07-01 21:36 ` [PATCH 2/3] ARM: dts: Hook up supplies for Arndale S5M8767 Mark Brown
2013-07-01 21:36 ` Mark Brown
2013-07-01 21:36 ` [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings Mark Brown
2013-07-01 21:36 ` Mark Brown
2013-07-01 21:47 ` Fabio Estevam
2013-07-01 21:47 ` Fabio Estevam
2013-07-01 22:38 ` Mark Brown
2013-07-01 22:38 ` Mark Brown
2013-07-02 5:21 ` Tushar Behera
2013-07-02 5:21 ` Tushar Behera
2013-07-02 9:25 ` Mark Brown
2013-07-02 9:25 ` Mark Brown
2013-07-24 1:50 ` Kukjin Kim
2013-07-24 1:50 ` Kukjin Kim
2013-07-05 23:36 ` [PATCH 1/3] ARM: dts: Put Arndale fixed voltage regulators on a simple-bus Tomasz Figa
2013-07-05 23:36 ` Tomasz Figa
2013-07-06 9:19 ` Mark Brown [this message]
2013-07-06 9:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130706091925.GL27646@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.