From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/04] ARM: shmobile: Add EMEV2 and KZM9D to ARCH_SHMOBILE_MULTI
Date: Tue, 09 Jul 2013 07:37:29 +0000 [thread overview]
Message-ID: <201307090937.29805.arnd@arndb.de> (raw)
In-Reply-To: <20130709054359.14007.23619.sendpatchset@w520>
On Tuesday 09 July 2013, Magnus Damm wrote:
> +void __init __weak emev2_clock_init(void)
> +{
> + /* in case legacy clocks are disabled then do nothing */
> +}
Nitpicking:
I don't like the __weak symbols too much, in general I prefer
doing either
if (IS_ENABLED(CONFIG_SHMOBILE_CLOCKS)
emev2_clock_init()
or using an inline alternative in the header file.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/04] ARM: shmobile: Add EMEV2 and KZM9D to ARCH_SHMOBILE_MULTI
Date: Tue, 9 Jul 2013 09:37:29 +0200 [thread overview]
Message-ID: <201307090937.29805.arnd@arndb.de> (raw)
In-Reply-To: <20130709054359.14007.23619.sendpatchset@w520>
On Tuesday 09 July 2013, Magnus Damm wrote:
> +void __init __weak emev2_clock_init(void)
> +{
> + /* in case legacy clocks are disabled then do nothing */
> +}
Nitpicking:
I don't like the __weak symbols too much, in general I prefer
doing either
if (IS_ENABLED(CONFIG_SHMOBILE_CLOCKS)
emev2_clock_init()
or using an inline alternative in the header file.
Arnd
next prev parent reply other threads:[~2013-07-09 7:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 5:43 [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Magnus Damm
2013-07-09 5:43 ` Magnus Damm
2013-07-09 5:43 ` [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n Magnus Damm
2013-07-09 5:43 ` Magnus Damm
2013-07-09 7:43 ` Arnd Bergmann
2013-07-09 7:43 ` Arnd Bergmann
2013-07-09 7:45 ` Laurent Pinchart
2013-07-09 7:45 ` Laurent Pinchart
2013-07-09 9:09 ` Magnus Damm
2013-07-09 9:09 ` Magnus Damm
2013-07-09 21:06 ` Arnd Bergmann
2013-07-09 21:06 ` Arnd Bergmann
2013-07-09 5:43 ` [PATCH 02/04] ARM: shmobile: Introduce ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09 5:43 ` Magnus Damm
2013-07-09 5:43 ` [PATCH 03/04] ARM: shmobile: Add EMEV2 and KZM9D to ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09 5:43 ` Magnus Damm
2013-07-09 7:37 ` Arnd Bergmann [this message]
2013-07-09 7:37 ` Arnd Bergmann
2013-07-09 9:15 ` Magnus Damm
2013-07-09 9:15 ` Magnus Damm
2013-07-09 21:07 ` Arnd Bergmann
2013-07-09 21:07 ` Arnd Bergmann
2013-07-09 5:44 ` [PATCH 04/04] ARM: shmobile: Allow ARCH_SHMOBILE_MULTI timer configuration Magnus Damm
2013-07-09 5:44 ` Magnus Damm
2013-07-09 7:45 ` [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Arnd Bergmann
2013-07-09 7:45 ` Arnd Bergmann
2013-07-09 9:11 ` Magnus Damm
2013-07-09 9:11 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307090937.29805.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.