All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n
Date: Tue, 09 Jul 2013 21:06:37 +0000	[thread overview]
Message-ID: <201307092306.38004.arnd@arndb.de> (raw)
In-Reply-To: <CANqRtoRJhrbT4NMv4e7NwvXj0JoO001ShtjSwdquv7x-7dxKeA@mail.gmail.com>

On Tuesday 09 July 2013, Magnus Damm wrote:
> >>
> >> +ifndef CONFIG_COMMON_CLK
> >>  obj-$(CONFIG_ARCH_SH7372)      += setup-sh7372.o intc-sh7372.o
> >>  obj-$(CONFIG_ARCH_SH73A0)      += setup-sh73a0.o intc-sh73a0.o
> >>  obj-$(CONFIG_ARCH_R8A73A4)     += setup-r8a73a4.o
> >>  obj-$(CONFIG_ARCH_R8A7740)     += setup-r8a7740.o intc-r8a7740.o
> >>  obj-$(CONFIG_ARCH_R8A7778)     += setup-r8a7778.o
> >>  obj-$(CONFIG_ARCH_R8A7779)     += setup-r8a7779.o intc-r8a7779.o
> >>  obj-$(CONFIG_ARCH_R8A7790)     += setup-r8a7790.o
> >>  obj-$(CONFIG_ARCH_EMEV2)       += setup-emev2.o
> >> +endif
> >
> > I was about to mention the same, so I think that would be a good idea.
> 
> Sure, that may be a more common way to handle this. =)
> 
> To be clear, I assume you wanted that ifndef to cover the clock-xxx.c
> files instead of setup-xxx.c. So I will do that in next version.
> 

Yes, that's right, sorry for screwing up the example.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n
Date: Tue, 9 Jul 2013 23:06:37 +0200	[thread overview]
Message-ID: <201307092306.38004.arnd@arndb.de> (raw)
In-Reply-To: <CANqRtoRJhrbT4NMv4e7NwvXj0JoO001ShtjSwdquv7x-7dxKeA@mail.gmail.com>

On Tuesday 09 July 2013, Magnus Damm wrote:
> >>
> >> +ifndef CONFIG_COMMON_CLK
> >>  obj-$(CONFIG_ARCH_SH7372)      += setup-sh7372.o intc-sh7372.o
> >>  obj-$(CONFIG_ARCH_SH73A0)      += setup-sh73a0.o intc-sh73a0.o
> >>  obj-$(CONFIG_ARCH_R8A73A4)     += setup-r8a73a4.o
> >>  obj-$(CONFIG_ARCH_R8A7740)     += setup-r8a7740.o intc-r8a7740.o
> >>  obj-$(CONFIG_ARCH_R8A7778)     += setup-r8a7778.o
> >>  obj-$(CONFIG_ARCH_R8A7779)     += setup-r8a7779.o intc-r8a7779.o
> >>  obj-$(CONFIG_ARCH_R8A7790)     += setup-r8a7790.o
> >>  obj-$(CONFIG_ARCH_EMEV2)       += setup-emev2.o
> >> +endif
> >
> > I was about to mention the same, so I think that would be a good idea.
> 
> Sure, that may be a more common way to handle this. =)
> 
> To be clear, I assume you wanted that ifndef to cover the clock-xxx.c
> files instead of setup-xxx.c. So I will do that in next version.
> 

Yes, that's right, sorry for screwing up the example.

	Arnd

  reply	other threads:[~2013-07-09 21:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09  5:43 [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Magnus Damm
2013-07-09  5:43 ` Magnus Damm
2013-07-09  5:43 ` [PATCH 01/04] ARM: shmobile: Only build clocks when COMMON_CLK=n Magnus Damm
2013-07-09  5:43   ` Magnus Damm
2013-07-09  7:43   ` Arnd Bergmann
2013-07-09  7:43     ` Arnd Bergmann
2013-07-09  7:45     ` Laurent Pinchart
2013-07-09  7:45       ` Laurent Pinchart
2013-07-09  9:09       ` Magnus Damm
2013-07-09  9:09         ` Magnus Damm
2013-07-09 21:06         ` Arnd Bergmann [this message]
2013-07-09 21:06           ` Arnd Bergmann
2013-07-09  5:43 ` [PATCH 02/04] ARM: shmobile: Introduce ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09  5:43   ` Magnus Damm
2013-07-09  5:43 ` [PATCH 03/04] ARM: shmobile: Add EMEV2 and KZM9D to ARCH_SHMOBILE_MULTI Magnus Damm
2013-07-09  5:43   ` Magnus Damm
2013-07-09  7:37   ` Arnd Bergmann
2013-07-09  7:37     ` Arnd Bergmann
2013-07-09  9:15     ` Magnus Damm
2013-07-09  9:15       ` Magnus Damm
2013-07-09 21:07       ` Arnd Bergmann
2013-07-09 21:07         ` Arnd Bergmann
2013-07-09  5:44 ` [PATCH 04/04] ARM: shmobile: Allow ARCH_SHMOBILE_MULTI timer configuration Magnus Damm
2013-07-09  5:44   ` Magnus Damm
2013-07-09  7:45 ` [PATCH 00/04] ARM: shmobile: ARCH_MULTIPLATFORM for EMEV2 and KZM9D Arnd Bergmann
2013-07-09  7:45   ` Arnd Bergmann
2013-07-09  9:11   ` Magnus Damm
2013-07-09  9:11     ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201307092306.38004.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.