All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces
Date: Sat, 13 Jul 2013 00:57:02 +0000	[thread overview]
Message-ID: <20130713005702.GA14788@kroah.com> (raw)
In-Reply-To: <201307130351.42967.sergei.shtylyov@cogentembedded.com>

On Sat, Jul 13, 2013 at 03:51:42AM +0400, Sergei Shtylyov wrote:
> Add the driver for Gyro-ADC/speed-pulse interfaces found in Renesas R-Car SoCs.
> Though  being two separate devices, they have to be driven together because of
> the shared start/stop register (located in Gyro-ADC still). At this time, only
> speed-pulse interface is fully supported, the Gyro-ADC is just initialized and
> started/stopped synchronously with the speed-pulse interface.  A user interface
> is implemented via several sysfs files which allow to read and reset the speed-
> pulse interface's registers.

If you modify/create/remove sysfs files, you also have to document them
in Documentation/ABI/ which is missing from this patch.

Your sysfs files are also being created in a "racy" way, i.e. after
userspace is told about the device, please fix that as well.

And are you sure you want to control this through sysfs?  There's no
other better user/kernel apis for it?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces
Date: Fri, 12 Jul 2013 17:57:02 -0700	[thread overview]
Message-ID: <20130713005702.GA14788@kroah.com> (raw)
In-Reply-To: <201307130351.42967.sergei.shtylyov@cogentembedded.com>

On Sat, Jul 13, 2013 at 03:51:42AM +0400, Sergei Shtylyov wrote:
> Add the driver for Gyro-ADC/speed-pulse interfaces found in Renesas R-Car SoCs.
> Though  being two separate devices, they have to be driven together because of
> the shared start/stop register (located in Gyro-ADC still). At this time, only
> speed-pulse interface is fully supported, the Gyro-ADC is just initialized and
> started/stopped synchronously with the speed-pulse interface.  A user interface
> is implemented via several sysfs files which allow to read and reset the speed-
> pulse interface's registers.

If you modify/create/remove sysfs files, you also have to document them
in Documentation/ABI/ which is missing from this patch.

Your sysfs files are also being created in a "racy" way, i.e. after
userspace is told about the device, please fix that as well.

And are you sure you want to control this through sysfs?  There's no
other better user/kernel apis for it?

thanks,

greg k-h

  reply	other threads:[~2013-07-13  0:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 23:51 [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces Sergei Shtylyov
2013-07-12 23:51 ` Sergei Shtylyov
2013-07-13  0:57 ` Greg KH [this message]
2013-07-13  0:57   ` Greg KH
2013-07-13  1:15   ` Sergei Shtylyov
2013-07-13  1:15     ` Sergei Shtylyov
2013-07-13  1:30     ` Greg KH
2013-07-13  1:30       ` Greg KH
2013-07-13 22:44       ` Sergei Shtylyov
2013-07-13 22:44         ` Sergei Shtylyov
2013-07-13  7:58     ` Arnd Bergmann
2013-07-13  7:58       ` Arnd Bergmann
2013-07-13 22:26       ` Sergei Shtylyov
2013-07-13 22:26         ` Sergei Shtylyov
2013-07-13 23:17         ` Greg KH
2013-07-13 23:17           ` Greg KH
2013-07-14  8:12         ` Lars-Peter Clausen
2013-07-14  8:12           ` Lars-Peter Clausen
2013-07-14 19:57           ` Sergei Shtylyov
2013-07-14 19:57             ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130713005702.GA14788@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.