All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces
Date: Sun, 14 Jul 2013 19:57:24 +0000	[thread overview]
Message-ID: <51E302A4.6080801@cogentembedded.com> (raw)
In-Reply-To: <51E25D6A.3090106@metafoo.de>

Hello.

On 07/14/2013 12:12 PM, Lars-Peter Clausen wrote:

>>>>> And are you sure you want to control this through sysfs?  There's no
>>>>> other better user/kernel apis for it?

>>>>       I found none, besides ioctl(), as the device driven is rather
>>>> unique. But I thought that sysfs is "ioctl() today", so I went with it...

>>> It does sound like it would fit better into IIO than just a misc driver,
>>> even if it's the only hardware of its kind.

>>     I got somewhat familiarized myself with drivers/iio/ infrastructure and I
>> have found a place only the for ADC device in which the customer currently
>> has no interest.
>>     The other trouble is that I'll have to backport this driver to 3.4 which
>> doesn't contain the IIO infrastructure at all. :-(

> It has, it's just still in staging in 3.4. But the API (except for minor
> modifications) and more importantly the ABI are the same.

    Thank you for the useful information. I wouldn't probably have 
figured it out to search there.

> There is a angular velocity channel type in IIO. maybe that could be used to
> report the Speed-Pulse-ADC values.

    You probably misunderstood from my terse description. Multichannel 
ADC interface is separate from the speed-pulse interface which has on 
its single input digital PWM signal of varying frequency. Speed pulse 
i/f measures pulse count and period. I've found no adequate channel type 
in IIO infrastructure so far. I'll mail the IIO maintainers with a 
request for help probably...

> - Lars

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg KH <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces
Date: Sun, 14 Jul 2013 23:57:24 +0400	[thread overview]
Message-ID: <51E302A4.6080801@cogentembedded.com> (raw)
In-Reply-To: <51E25D6A.3090106@metafoo.de>

Hello.

On 07/14/2013 12:12 PM, Lars-Peter Clausen wrote:

>>>>> And are you sure you want to control this through sysfs?  There's no
>>>>> other better user/kernel apis for it?

>>>>       I found none, besides ioctl(), as the device driven is rather
>>>> unique. But I thought that sysfs is "ioctl() today", so I went with it...

>>> It does sound like it would fit better into IIO than just a misc driver,
>>> even if it's the only hardware of its kind.

>>     I got somewhat familiarized myself with drivers/iio/ infrastructure and I
>> have found a place only the for ADC device in which the customer currently
>> has no interest.
>>     The other trouble is that I'll have to backport this driver to 3.4 which
>> doesn't contain the IIO infrastructure at all. :-(

> It has, it's just still in staging in 3.4. But the API (except for minor
> modifications) and more importantly the ABI are the same.

    Thank you for the useful information. I wouldn't probably have 
figured it out to search there.

> There is a angular velocity channel type in IIO. maybe that could be used to
> report the Speed-Pulse-ADC values.

    You probably misunderstood from my terse description. Multichannel 
ADC interface is separate from the speed-pulse interface which has on 
its single input digital PWM signal of varying frequency. Speed pulse 
i/f measures pulse count and period. I've found no adequate channel type 
in IIO infrastructure so far. I'll mail the IIO maintainers with a 
request for help probably...

> - Lars

WBR, Sergei


  reply	other threads:[~2013-07-14 19:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 23:51 [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces Sergei Shtylyov
2013-07-12 23:51 ` Sergei Shtylyov
2013-07-13  0:57 ` Greg KH
2013-07-13  0:57   ` Greg KH
2013-07-13  1:15   ` Sergei Shtylyov
2013-07-13  1:15     ` Sergei Shtylyov
2013-07-13  1:30     ` Greg KH
2013-07-13  1:30       ` Greg KH
2013-07-13 22:44       ` Sergei Shtylyov
2013-07-13 22:44         ` Sergei Shtylyov
2013-07-13  7:58     ` Arnd Bergmann
2013-07-13  7:58       ` Arnd Bergmann
2013-07-13 22:26       ` Sergei Shtylyov
2013-07-13 22:26         ` Sergei Shtylyov
2013-07-13 23:17         ` Greg KH
2013-07-13 23:17           ` Greg KH
2013-07-14  8:12         ` Lars-Peter Clausen
2013-07-14  8:12           ` Lars-Peter Clausen
2013-07-14 19:57           ` Sergei Shtylyov [this message]
2013-07-14 19:57             ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E302A4.6080801@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.