From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
linux-watchdog@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Lior Amsalem <alior@marvell.com>,
Maen Suleiman <maen@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
wim@iguana.be
Subject: Re: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register
Date: Tue, 16 Jul 2013 11:18:51 -0300 [thread overview]
Message-ID: <20130716141850.GB23904@localhost> (raw)
In-Reply-To: <20130716140415.GB19448@lunn.ch>
Andrew,
On Tue, Jul 16, 2013 at 04:04:15PM +0200, Andrew Lunn wrote:
> On Mon, Jul 15, 2013 at 08:32:38PM -0300, Ezequiel Garcia wrote:
> > Instead of accessing the RSTOUT register directly, this commit
> > adds a platform memory resource to map this register into the driver.
>
>
> Have you looked at:
>
> arch/arm/mach-mvebu/system-controller.c
>
Mmm... I saw the use of the RSTOUT register in kirkwood_restart()
but wasn't sure who should be the real 'owner' of this register.
> It is also using this register. Are we going to have a similar problem
> as the TIMER_CTRL register, which you refactered in an earlier patch?
>
Probably.
> "marvell,orion-system-controller" is not actually used yet, but once
> kirkwood moves into mach-mvebu, it will start using it.
>
I guess so. We should take that into account *now*. Let me think about
it and see if I can have something sane for v2.
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register
Date: Tue, 16 Jul 2013 11:18:51 -0300 [thread overview]
Message-ID: <20130716141850.GB23904@localhost> (raw)
In-Reply-To: <20130716140415.GB19448@lunn.ch>
Andrew,
On Tue, Jul 16, 2013 at 04:04:15PM +0200, Andrew Lunn wrote:
> On Mon, Jul 15, 2013 at 08:32:38PM -0300, Ezequiel Garcia wrote:
> > Instead of accessing the RSTOUT register directly, this commit
> > adds a platform memory resource to map this register into the driver.
>
>
> Have you looked at:
>
> arch/arm/mach-mvebu/system-controller.c
>
Mmm... I saw the use of the RSTOUT register in kirkwood_restart()
but wasn't sure who should be the real 'owner' of this register.
> It is also using this register. Are we going to have a similar problem
> as the TIMER_CTRL register, which you refactered in an earlier patch?
>
Probably.
> "marvell,orion-system-controller" is not actually used yet, but once
> kirkwood moves into mach-mvebu, it will start using it.
>
I guess so. We should take that into account *now*. Let me think about
it and see if I can have something sane for v2.
Thanks!
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Maen Suleiman <maen-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register
Date: Tue, 16 Jul 2013 11:18:51 -0300 [thread overview]
Message-ID: <20130716141850.GB23904@localhost> (raw)
In-Reply-To: <20130716140415.GB19448-g2DYL2Zd6BY@public.gmane.org>
Andrew,
On Tue, Jul 16, 2013 at 04:04:15PM +0200, Andrew Lunn wrote:
> On Mon, Jul 15, 2013 at 08:32:38PM -0300, Ezequiel Garcia wrote:
> > Instead of accessing the RSTOUT register directly, this commit
> > adds a platform memory resource to map this register into the driver.
>
>
> Have you looked at:
>
> arch/arm/mach-mvebu/system-controller.c
>
Mmm... I saw the use of the RSTOUT register in kirkwood_restart()
but wasn't sure who should be the real 'owner' of this register.
> It is also using this register. Are we going to have a similar problem
> as the TIMER_CTRL register, which you refactered in an earlier patch?
>
Probably.
> "marvell,orion-system-controller" is not actually used yet, but once
> kirkwood moves into mach-mvebu, it will start using it.
>
I guess so. We should take that into account *now*. Let me think about
it and see if I can have something sane for v2.
Thanks!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-07-16 14:18 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 23:32 [PATCH 00/10] Orion Watchdog fixes Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 01/10] clocksource: orion: Add thread-safe API header Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 02/10] watchdog: orion: Use thread-safe clocksource API Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 03/10] watchdog: orion: Rename device-tree binding documentation Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 04/10] watchdog: orion: Use the proper watchdog register Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 05/10] watchdog: orion: Add a memory resource for RSTOUT register Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-16 14:04 ` Andrew Lunn
2013-07-16 14:04 ` Andrew Lunn
2013-07-16 14:04 ` Andrew Lunn
2013-07-16 14:18 ` Ezequiel Garcia [this message]
2013-07-16 14:18 ` Ezequiel Garcia
2013-07-16 14:18 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 06/10] watchdog: orion: Update device-tree binding documentation Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-16 13:24 ` Jason Cooper
2013-07-16 13:24 ` Jason Cooper
2013-07-16 13:24 ` Jason Cooper
2013-07-15 23:32 ` [PATCH 07/10] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 08/10] watchdog: orion: Remove mach-specific unneeded header Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 09/10] watchdog: orion: Use BIT() Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` [PATCH 10/10] ARM: kirkwood: Fix the device-tree watchdog's node reg property Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-15 23:32 ` Ezequiel Garcia
2013-07-16 6:59 ` [PATCH 00/10] Orion Watchdog fixes Andrew Lunn
2013-07-16 6:59 ` Andrew Lunn
2013-07-16 6:59 ` Andrew Lunn
2013-07-16 7:20 ` Thomas Petazzoni
2013-07-16 7:20 ` Thomas Petazzoni
2013-07-16 7:20 ` Thomas Petazzoni
2013-07-16 7:31 ` Andrew Lunn
2013-07-16 7:31 ` Andrew Lunn
2013-07-16 7:31 ` Andrew Lunn
2013-07-16 7:48 ` Sebastian Hesselbarth
2013-07-16 7:48 ` Sebastian Hesselbarth
2013-07-16 7:48 ` Sebastian Hesselbarth
2013-07-16 12:17 ` Ezequiel Garcia
2013-07-16 12:17 ` Ezequiel Garcia
2013-07-16 12:17 ` Ezequiel Garcia
2013-07-16 12:14 ` Ezequiel Garcia
2013-07-16 12:14 ` Ezequiel Garcia
2013-07-16 12:14 ` Ezequiel Garcia
2013-07-16 13:44 ` Jason Cooper
2013-07-16 13:44 ` Jason Cooper
2013-07-16 13:44 ` Jason Cooper
2013-07-16 14:04 ` Ezequiel Garcia
2013-07-16 14:04 ` Ezequiel Garcia
2013-07-16 14:04 ` Ezequiel Garcia
2013-07-16 14:29 ` Jason Cooper
2013-07-16 14:29 ` Jason Cooper
2013-07-16 14:29 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716141850.GB23904@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=maen@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.