All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list
Date: Wed, 17 Jul 2013 12:27:59 +0100	[thread overview]
Message-ID: <20130717112759.GD3336@laptop> (raw)
In-Reply-To: <1373197462-4033-4-git-send-email-yadi.brar@samsung.com>

On Sun, 07 Jul 2013, Yadwinder Singh Brar wrote:

> Since these are fixed rate clocks which are registered with common clock
> framework so remove these from list of regulators which were unnecessarily
> incrementing the count(S2MPS11_REGULATOR_MAX) of regulators.
> 
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> ---
>  include/linux/mfd/samsung/s2mps11.h |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/mfd/samsung/s2mps11.h b/include/linux/mfd/samsung/s2mps11.h
> index d0d52ea..b3ddf98 100644
> --- a/include/linux/mfd/samsung/s2mps11.h
> +++ b/include/linux/mfd/samsung/s2mps11.h
> @@ -167,11 +167,8 @@ enum s2mps11_regulators {
>  	S2MPS11_BUCK8,
>  	S2MPS11_BUCK9,
>  	S2MPS11_BUCK10,
> -	S2MPS11_AP_EN32KHZ,
> -	S2MPS11_CP_EN32KHZ,
> -	S2MPS11_BT_EN32KHZ,

These aren't mentioned anywhere else in the kernel, so I'll just apply
the patch.

> -	S2MPS11_REG_MAX,
> +	S2MPS11_REGULATOR_MAX,
>  };
>  
>  #define S2MPS11_BUCK_MIN1	600000
> @@ -203,6 +200,5 @@ enum s2mps11_regulators {
>  #define S2MPS11_BUCK4_RAMP_EN_SHIFT	1
>  #define S2MPS11_BUCK6_RAMP_EN_SHIFT	0
>  #define S2MPS11_PMIC_EN_SHIFT	6
> -#define S2MPS11_REGULATOR_MAX (S2MPS11_REG_MAX - 3)
>  
>  #endif /*  __LINUX_MFD_S2MPS11_H */

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Yadwinder Singh Brar <yadi.brar@samsung.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sbkim73@samsung.com,
	sameo@linux.intel.com, mturquette@linaro.org, broonie@kernel.org,
	yadi.brar01@gmail.com
Subject: Re: [PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list
Date: Wed, 17 Jul 2013 12:27:59 +0100	[thread overview]
Message-ID: <20130717112759.GD3336@laptop> (raw)
In-Reply-To: <1373197462-4033-4-git-send-email-yadi.brar@samsung.com>

On Sun, 07 Jul 2013, Yadwinder Singh Brar wrote:

> Since these are fixed rate clocks which are registered with common clock
> framework so remove these from list of regulators which were unnecessarily
> incrementing the count(S2MPS11_REGULATOR_MAX) of regulators.
> 
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> ---
>  include/linux/mfd/samsung/s2mps11.h |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/mfd/samsung/s2mps11.h b/include/linux/mfd/samsung/s2mps11.h
> index d0d52ea..b3ddf98 100644
> --- a/include/linux/mfd/samsung/s2mps11.h
> +++ b/include/linux/mfd/samsung/s2mps11.h
> @@ -167,11 +167,8 @@ enum s2mps11_regulators {
>  	S2MPS11_BUCK8,
>  	S2MPS11_BUCK9,
>  	S2MPS11_BUCK10,
> -	S2MPS11_AP_EN32KHZ,
> -	S2MPS11_CP_EN32KHZ,
> -	S2MPS11_BT_EN32KHZ,

These aren't mentioned anywhere else in the kernel, so I'll just apply
the patch.

> -	S2MPS11_REG_MAX,
> +	S2MPS11_REGULATOR_MAX,
>  };
>  
>  #define S2MPS11_BUCK_MIN1	600000
> @@ -203,6 +200,5 @@ enum s2mps11_regulators {
>  #define S2MPS11_BUCK4_RAMP_EN_SHIFT	1
>  #define S2MPS11_BUCK6_RAMP_EN_SHIFT	0
>  #define S2MPS11_PMIC_EN_SHIFT	6
> -#define S2MPS11_REGULATOR_MAX (S2MPS11_REG_MAX - 3)
>  
>  #endif /*  __LINUX_MFD_S2MPS11_H */

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2013-07-17 11:27 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 11:44 [PATCH 0/3] Add clk driver to register s2mps11 clocks Yadwinder Singh Brar
2013-07-07 11:44 ` Yadwinder Singh Brar
2013-07-07 11:44 ` [PATCH 1/3] clk: s2mps11: Add support for s2mps11 Yadwinder Singh Brar
2013-07-07 11:44   ` Yadwinder Singh Brar
2013-07-26 15:43   ` Yadwinder Singh Brar
2013-07-26 15:43     ` Yadwinder Singh Brar
2013-08-05 23:23   ` Mike Turquette
2013-08-05 23:23     ` Mike Turquette
2013-08-06  4:25     ` Yadwinder Singh Brar
2013-08-06  4:25       ` Yadwinder Singh Brar
2013-08-06 19:52       ` Mike Turquette
2013-08-07  8:00         ` Lee Jones
2013-08-07  8:00           ` Lee Jones
2013-07-07 11:44 ` [PATCH 2/3] mfd: sec: Add clock cell " Yadwinder Singh Brar
2013-07-07 11:44   ` Yadwinder Singh Brar
2013-07-17 11:23   ` Lee Jones
2013-07-17 11:23     ` Lee Jones
2013-08-07 17:16   ` Mike Turquette
2013-08-07 17:16     ` Mike Turquette
2013-08-08  9:05     ` Lee Jones
2013-08-08  9:05       ` Lee Jones
2013-07-07 11:44 ` [PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list Yadwinder Singh Brar
2013-07-07 11:44   ` Yadwinder Singh Brar
2013-07-17 11:27   ` Lee Jones [this message]
2013-07-17 11:27     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717112759.GD3336@laptop \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.