From: rric@kernel.org (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y
Date: Mon, 22 Jul 2013 15:56:39 +0200 [thread overview]
Message-ID: <20130722135639.GA6927@rric.localhost> (raw)
In-Reply-To: <20130721213753.GA29879@mudshark.cambridge.arm.com>
On 21.07.13 22:37:53, Will Deacon wrote:
> Ok, I think I'm with you now. I also think that a better solution would be
> to try and limit the r7/fp confusion to one place, perhaps behind something
> like:
>
> void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame);
In unwind_backtrace() there is already common code to do this and also
to get it from a task_struct. This could be ripped out. I would prefer
then the following function:
void init_stackframe(struct stackframe *frame, struct pt_regs *regs,
struct task_struct *tsk)
-Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Richter <rric@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Jed Davis <jld@mozilla.com>,
Russell King <linux@arm.linux.org.uk>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>
Subject: Re: [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y
Date: Mon, 22 Jul 2013 15:56:39 +0200 [thread overview]
Message-ID: <20130722135639.GA6927@rric.localhost> (raw)
In-Reply-To: <20130721213753.GA29879@mudshark.cambridge.arm.com>
On 21.07.13 22:37:53, Will Deacon wrote:
> Ok, I think I'm with you now. I also think that a better solution would be
> to try and limit the r7/fp confusion to one place, perhaps behind something
> like:
>
> void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame);
In unwind_backtrace() there is already common code to do this and also
to get it from a task_struct. This could be ripped out. I would prefer
then the following function:
void init_stackframe(struct stackframe *frame, struct pt_regs *regs,
struct task_struct *tsk)
-Robert
next prev parent reply other threads:[~2013-07-22 13:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 3:18 [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y Jed Davis
2013-07-13 3:18 ` Jed Davis
2013-07-15 13:54 ` Will Deacon
2013-07-15 13:54 ` Will Deacon
2013-07-20 4:46 ` Jed Davis
2013-07-20 4:46 ` Jed Davis
2013-07-21 21:37 ` Will Deacon
2013-07-21 21:37 ` Will Deacon
2013-07-22 13:56 ` Robert Richter [this message]
2013-07-22 13:56 ` Robert Richter
2013-07-22 18:52 ` Dave Martin
2013-07-22 18:52 ` Dave Martin
2013-07-29 21:21 ` Jed Davis
2013-07-29 21:21 ` Jed Davis
2013-07-30 9:25 ` Dave Martin
2013-07-30 9:25 ` Dave Martin
2013-07-30 9:38 ` [PATCH] ARM: Fix r7/r11 confusion when CONFIG_THUMB2_KERNEL=y [OT] Jean-Francois Moine
2013-07-30 9:38 ` Jean-Francois Moine
2013-07-30 9:44 ` Dave Martin
2013-07-30 9:44 ` Dave Martin
2013-07-30 10:09 ` Jean-Francois Moine
2013-07-30 10:09 ` Jean-Francois Moine
2013-07-30 11:46 ` Dave Martin
2013-07-30 11:46 ` Dave Martin
2013-07-30 17:50 ` Christopher Covington
2013-07-30 17:50 ` Christopher Covington
2013-07-30 9:49 ` Will Deacon
2013-07-30 9:49 ` Will Deacon
2013-07-31 9:03 ` Jean-Francois Moine
2013-07-31 9:03 ` Jean-Francois Moine
2013-07-31 10:38 ` Will Deacon
2013-07-31 10:38 ` Will Deacon
2014-01-06 9:54 ` walimis
2014-01-06 9:54 ` walimis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722135639.GA6927@rric.localhost \
--to=rric@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.