Re: [PATCH] Fix function libxl__domain_resume_device_model

[rwxybh <rwxybh@126.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2040 bytes --]

Of course, Ian.

From: Ian Campbell
Date: 2013-07-30 20:28
To: Wei Liu
CC: rwxybh; rwxybh@123.com; xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] Fix function libxl__domain_resume_device_model
On Tue, 2013-07-30 at 20:00 +0800, Wei Liu wrote:
> On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com> wrote:
> > Add a break point in function libxl__domain_resume_device_model
> >
> > Signed-off-by: rwxybh <rwxybh@126.com>
> 
> Is it OK to use alias rather than real name in SoB? I remember seeing that
> author should use real name in SoB but I'm not sure. Ignore this if I'm wrong.

I know the Linux guys have been picky about this in the past, although
I'm not sure they are 100% consistent (the one I'm thinking of had other
surrounding controversy).

In any case since rwxybh has previously posted with their real name I
think it would be OK to ask for an S-o-b containing it and sidestep
having to think about the issue? Bingheng, are you OK with me using the
following S-o-b instead of the one above?

> Signed-off-by: Bingheng Yan <rwxybh@126.com>

Ian.

> 
> 
> Wei.
> 
> > ---
> >  tools/libxl/libxl_dom.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > index b38d0a7..3eaf3ae 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> >      case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> >          if (libxl__qmp_resume(gc, domid))
> >              return ERROR_FAIL;
> > +       break;
> >      default:
> >          return ERROR_INVAL;
> >      }
> > --
> > 1.7.1
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

[-- Attachment #1.2: Type: text/html, Size: 4602 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel