* [PATCH] Fix function libxl__domain_resume_device_model
@ 2013-07-30 0:37 rwxybh
2013-07-30 8:22 ` Roger Pau Monné
2013-07-30 12:00 ` Wei Liu
0 siblings, 2 replies; 6+ messages in thread
From: rwxybh @ 2013-07-30 0:37 UTC (permalink / raw)
To: xen-devel; +Cc: rwxybh, rwxybh
Add a break point in function libxl__domain_resume_device_model
Signed-off-by: rwxybh <rwxybh@126.com>
---
tools/libxl/libxl_dom.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index b38d0a7..3eaf3ae 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
if (libxl__qmp_resume(gc, domid))
return ERROR_FAIL;
+ break;
default:
return ERROR_INVAL;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Fix function libxl__domain_resume_device_model
2013-07-30 0:37 [PATCH] Fix function libxl__domain_resume_device_model rwxybh
@ 2013-07-30 8:22 ` Roger Pau Monné
2013-07-30 12:00 ` Wei Liu
1 sibling, 0 replies; 6+ messages in thread
From: Roger Pau Monné @ 2013-07-30 8:22 UTC (permalink / raw)
To: rwxybh; +Cc: rwxybh, xen-devel
On 30/07/13 02:37, rwxybh wrote:
> Add a break point in function libxl__domain_resume_device_model
>
> Signed-off-by: rwxybh <rwxybh@126.com>
> ---
> tools/libxl/libxl_dom.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index b38d0a7..3eaf3ae 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> if (libxl__qmp_resume(gc, domid))
> return ERROR_FAIL;
> + break;
Thanks, the patch looks OK, but the indentation is wrong, libxl uses
spaces to indent, please read the CODING_STYLE.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix function libxl__domain_resume_device_model
2013-07-30 0:37 [PATCH] Fix function libxl__domain_resume_device_model rwxybh
2013-07-30 8:22 ` Roger Pau Monné
@ 2013-07-30 12:00 ` Wei Liu
2013-07-30 12:28 ` Ian Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Wei Liu @ 2013-07-30 12:00 UTC (permalink / raw)
To: rwxybh; +Cc: rwxybh, xen-devel@lists.xen.org
On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com> wrote:
> Add a break point in function libxl__domain_resume_device_model
>
> Signed-off-by: rwxybh <rwxybh@126.com>
Is it OK to use alias rather than real name in SoB? I remember seeing that
author should use real name in SoB but I'm not sure. Ignore this if I'm wrong.
Wei.
> ---
> tools/libxl/libxl_dom.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index b38d0a7..3eaf3ae 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> if (libxl__qmp_resume(gc, domid))
> return ERROR_FAIL;
> + break;
> default:
> return ERROR_INVAL;
> }
> --
> 1.7.1
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix function libxl__domain_resume_device_model
2013-07-30 12:00 ` Wei Liu
@ 2013-07-30 12:28 ` Ian Campbell
2013-07-30 12:39 ` rwxybh
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2013-07-30 12:28 UTC (permalink / raw)
To: Wei Liu; +Cc: rwxybh, rwxybh, xen-devel@lists.xen.org
On Tue, 2013-07-30 at 20:00 +0800, Wei Liu wrote:
> On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com> wrote:
> > Add a break point in function libxl__domain_resume_device_model
> >
> > Signed-off-by: rwxybh <rwxybh@126.com>
>
> Is it OK to use alias rather than real name in SoB? I remember seeing that
> author should use real name in SoB but I'm not sure. Ignore this if I'm wrong.
I know the Linux guys have been picky about this in the past, although
I'm not sure they are 100% consistent (the one I'm thinking of had other
surrounding controversy).
In any case since rwxybh has previously posted with their real name I
think it would be OK to ask for an S-o-b containing it and sidestep
having to think about the issue? Bingheng, are you OK with me using the
following S-o-b instead of the one above?
> Signed-off-by: Bingheng Yan <rwxybh@126.com>
Ian.
>
>
> Wei.
>
> > ---
> > tools/libxl/libxl_dom.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > index b38d0a7..3eaf3ae 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> > case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> > if (libxl__qmp_resume(gc, domid))
> > return ERROR_FAIL;
> > + break;
> > default:
> > return ERROR_INVAL;
> > }
> > --
> > 1.7.1
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix function libxl__domain_resume_device_model
2013-07-30 12:28 ` Ian Campbell
@ 2013-07-30 12:39 ` rwxybh
2013-07-30 13:04 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: rwxybh @ 2013-07-30 12:39 UTC (permalink / raw)
To: Ian Campbell, Wei Liu; +Cc: rwxybh@123.com, xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 2040 bytes --]
Of course, Ian.
From: Ian Campbell
Date: 2013-07-30 20:28
To: Wei Liu
CC: rwxybh; rwxybh@123.com; xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] Fix function libxl__domain_resume_device_model
On Tue, 2013-07-30 at 20:00 +0800, Wei Liu wrote:
> On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com> wrote:
> > Add a break point in function libxl__domain_resume_device_model
> >
> > Signed-off-by: rwxybh <rwxybh@126.com>
>
> Is it OK to use alias rather than real name in SoB? I remember seeing that
> author should use real name in SoB but I'm not sure. Ignore this if I'm wrong.
I know the Linux guys have been picky about this in the past, although
I'm not sure they are 100% consistent (the one I'm thinking of had other
surrounding controversy).
In any case since rwxybh has previously posted with their real name I
think it would be OK to ask for an S-o-b containing it and sidestep
having to think about the issue? Bingheng, are you OK with me using the
following S-o-b instead of the one above?
> Signed-off-by: Bingheng Yan <rwxybh@126.com>
Ian.
>
>
> Wei.
>
> > ---
> > tools/libxl/libxl_dom.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > index b38d0a7..3eaf3ae 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -985,6 +985,7 @@ int libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> > case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> > if (libxl__qmp_resume(gc, domid))
> > return ERROR_FAIL;
> > + break;
> > default:
> > return ERROR_INVAL;
> > }
> > --
> > 1.7.1
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
[-- Attachment #1.2: Type: text/html, Size: 4602 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix function libxl__domain_resume_device_model
2013-07-30 12:39 ` rwxybh
@ 2013-07-30 13:04 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2013-07-30 13:04 UTC (permalink / raw)
To: rwxybh; +Cc: xen-devel, rwxybh@123.com, Wei Liu
Thanks.
On Tue, 2013-07-30 at 20:39 +0800, rwxybh wrote:
> Of course, Ian.
>
> From: Ian Campbell
> Date: 2013-07-30 20:28
> To: Wei Liu
> CC: rwxybh; rwxybh@123.com; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] Fix function
> libxl__domain_resume_device_model
> On Tue, 2013-07-30 at 20:00 +0800, Wei Liu wrote:
> > On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com> wrote:
> > > Add a break point in function libxl__domain_resume_device_model
> > >
> > > Signed-off-by: rwxybh <rwxybh@126.com>
> >
> > Is it OK to use alias rather than real name in SoB? I remember
> seeing that
> > author should use real name in SoB but I'm not sure. Ignore this if
> I'm wrong.
>
> I know the Linux guys have been picky about this in the past, although
> I'm not sure they are 100% consistent (the one I'm thinking of had
> other
> surrounding controversy).
>
> In any case since rwxybh has previously posted with their real name I
> think it would be OK to ask for an S-o-b containing it and sidestep
> having to think about the issue? Bingheng, are you OK with me using
> the
> following S-o-b instead of the one above?
>
> > Signed-off-by: Bingheng Yan <rwxybh@126.com>
>
> Ian.
>
> >
> >
> > Wei.
> >
> > > ---
> > > tools/libxl/libxl_dom.c | 1 +
> > > 1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> > > index b38d0a7..3eaf3ae 100644
> > > --- a/tools/libxl/libxl_dom.c
> > > +++ b/tools/libxl/libxl_dom.c
> > > @@ -985,6 +985,7 @@ int
> libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> > > case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> > > if (libxl__qmp_resume(gc, domid))
> > > return ERROR_FAIL;
> > > + break;
> > > default:
> > > return ERROR_INVAL;
> > > }
> > > --
> > > 1.7.1
> > >
> > >
> > >
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xen.org
> > > http://lists.xen.org/xen-devel
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-30 13:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-30 0:37 [PATCH] Fix function libxl__domain_resume_device_model rwxybh
2013-07-30 8:22 ` Roger Pau Monné
2013-07-30 12:00 ` Wei Liu
2013-07-30 12:28 ` Ian Campbell
2013-07-30 12:39 ` rwxybh
2013-07-30 13:04 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.