From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: shmobile: ape6evm: add SDHI interfaces
Date: Wed, 31 Jul 2013 00:29:44 +0000 [thread overview]
Message-ID: <20130731002944.GD17209@verge.net.au> (raw)
In-Reply-To: <51F7B822.7020404@cogentembedded.com>
On Tue, Jul 30, 2013 at 04:57:06PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 30-07-2013 13:00, Simon Horman wrote:
>
> >From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> >Add support for SDHI0 and SDHI1 on APE6EVM in PIO mode only.
>
> >Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/board-ape6evm.c | 50 +++++++++++++++++++++++++++++++++-
> > 1 file changed, 49 insertions(+), 1 deletion(-)
>
> >diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> >index 8c7529c..ccf8b04 100644
> >--- a/arch/arm/mach-shmobile/board-ape6evm.c
> >+++ b/arch/arm/mach-shmobile/board-ape6evm.c
> [...]
> >@@ -75,6 +82,29 @@ static struct resource mmcif0_resources[] = {
> > DEFINE_RES_IRQ(gic_spi(169)),
> > };
> >
> >+/* SDHI0 */
> >+static struct sh_mobile_sdhi_info sdhi0_pdata = {
> >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
> >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
> >+};
> >+
> >+static struct resource sdhi0_resources[] = {
> >+ DEFINE_RES_MEM_NAMED(0xee100000, 0x100, "SDHI0"),
> >+ DEFINE_RES_IRQ(gic_spi(165)),
> >+};
> >+
> >+/* SDHI1 */
> >+static struct sh_mobile_sdhi_info sdhi1_pdata = {
> >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
> >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> >+ MMC_CAP_NEEDS_POLL,
> >+};
> >+
> >+static struct resource sdhi1_resources[] = {
> >+ DEFINE_RES_MEM_NAMED(0xee120000, 0x100, "SDHI1"),
> >+ DEFINE_RES_IRQ(gic_spi(166)),
> >+};
> >+
>
> All of the above are lacking '__initdata' annothation (the
> resources and platform data will be kmemdup()'ed when registering
> the platform devices). Too bad I've noticed this too late...
Thanks Sergei.
Guennadi,
as I have already queued-up this patch could you please
make an incremental patch that adds __initdata to the above structures?
>
> >@@ -124,6 +166,12 @@ static void __init ape6evm_add_standard_devices(void)
> > platform_device_register_resndata(&platform_bus, "sh_mmcif", 0,
> > mmcif0_resources, ARRAY_SIZE(mmcif0_resources),
> > &mmcif0_pdata, sizeof(mmcif0_pdata));
> >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 0,
> >+ sdhi0_resources, ARRAY_SIZE(sdhi0_resources),
> >+ &sdhi0_pdata, sizeof(sdhi0_pdata));
> >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 1,
> >+ sdhi1_resources, ARRAY_SIZE(sdhi1_resources),
> >+ &sdhi1_pdata, sizeof(sdhi1_pdata));
> > }
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: shmobile: ape6evm: add SDHI interfaces
Date: Wed, 31 Jul 2013 09:29:44 +0900 [thread overview]
Message-ID: <20130731002944.GD17209@verge.net.au> (raw)
In-Reply-To: <51F7B822.7020404@cogentembedded.com>
On Tue, Jul 30, 2013 at 04:57:06PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 30-07-2013 13:00, Simon Horman wrote:
>
> >From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> >Add support for SDHI0 and SDHI1 on APE6EVM in PIO mode only.
>
> >Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/board-ape6evm.c | 50 +++++++++++++++++++++++++++++++++-
> > 1 file changed, 49 insertions(+), 1 deletion(-)
>
> >diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> >index 8c7529c..ccf8b04 100644
> >--- a/arch/arm/mach-shmobile/board-ape6evm.c
> >+++ b/arch/arm/mach-shmobile/board-ape6evm.c
> [...]
> >@@ -75,6 +82,29 @@ static struct resource mmcif0_resources[] = {
> > DEFINE_RES_IRQ(gic_spi(169)),
> > };
> >
> >+/* SDHI0 */
> >+static struct sh_mobile_sdhi_info sdhi0_pdata = {
> >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
> >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
> >+};
> >+
> >+static struct resource sdhi0_resources[] = {
> >+ DEFINE_RES_MEM_NAMED(0xee100000, 0x100, "SDHI0"),
> >+ DEFINE_RES_IRQ(gic_spi(165)),
> >+};
> >+
> >+/* SDHI1 */
> >+static struct sh_mobile_sdhi_info sdhi1_pdata = {
> >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
> >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
> >+ MMC_CAP_NEEDS_POLL,
> >+};
> >+
> >+static struct resource sdhi1_resources[] = {
> >+ DEFINE_RES_MEM_NAMED(0xee120000, 0x100, "SDHI1"),
> >+ DEFINE_RES_IRQ(gic_spi(166)),
> >+};
> >+
>
> All of the above are lacking '__initdata' annothation (the
> resources and platform data will be kmemdup()'ed when registering
> the platform devices). Too bad I've noticed this too late...
Thanks Sergei.
Guennadi,
as I have already queued-up this patch could you please
make an incremental patch that adds __initdata to the above structures?
>
> >@@ -124,6 +166,12 @@ static void __init ape6evm_add_standard_devices(void)
> > platform_device_register_resndata(&platform_bus, "sh_mmcif", 0,
> > mmcif0_resources, ARRAY_SIZE(mmcif0_resources),
> > &mmcif0_pdata, sizeof(mmcif0_pdata));
> >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 0,
> >+ sdhi0_resources, ARRAY_SIZE(sdhi0_resources),
> >+ &sdhi0_pdata, sizeof(sdhi0_pdata));
> >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 1,
> >+ sdhi1_resources, ARRAY_SIZE(sdhi1_resources),
> >+ &sdhi1_pdata, sizeof(sdhi1_pdata));
> > }
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-31 0:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 9:00 [PATCH 0/5] Renesas ARM-based SoC board updates for v3.12 Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 1/5] ARM: shmobile: armadillo800eva: add DMA support to MMCIF Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 2/5] ARM: shmobile: lager: add MMCIF support Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 3/5] ARM: shmobile: select the fixed regulator driver on BockW Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 4/5] ARM: shmobile: ape6evm: add MMCIF support Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 12:59 ` Sergei Shtylyov
2013-07-30 12:59 ` Sergei Shtylyov
2013-07-31 0:30 ` Simon Horman
2013-07-31 0:30 ` Simon Horman
2013-07-30 9:00 ` [PATCH 5/5] ARM: shmobile: ape6evm: add SDHI interfaces Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 12:57 ` Sergei Shtylyov
2013-07-30 12:57 ` Sergei Shtylyov
2013-07-31 0:29 ` Simon Horman [this message]
2013-07-31 0:29 ` Simon Horman
2013-08-04 20:31 ` [PATCH 0/5] Renesas ARM-based SoC board updates for v3.12 Olof Johansson
2013-08-04 20:31 ` Olof Johansson
2013-08-05 1:39 ` Simon Horman
2013-08-05 1:39 ` Simon Horman
2013-08-14 7:55 ` Olof Johansson
2013-08-14 7:55 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731002944.GD17209@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.