From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: shmobile: ape6evm: add MMCIF support
Date: Tue, 30 Jul 2013 12:59:28 +0000 [thread overview]
Message-ID: <51F7B8B0.3080201@cogentembedded.com> (raw)
In-Reply-To: <8711613252ed931037f9e9f8646935519dd8f362.1375174556.git.horms+renesas@verge.net.au>
Hello.
On 30-07-2013 13:00, Simon Horman wrote:
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Add MMCIF support to the APE6EVM board in PIO mode only. Power supply is
> fixed for now, eventually support for the tps80032 regulator, also
> supplying both VDD and VccQ to the MMCIF slot should be added to APE6EVM.
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> Acked-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/board-ape6evm.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index af6dd39..8c7529c 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
[...]
> @@ -54,6 +56,25 @@ static const struct smsc911x_platform_config lan9220_data = {
[...]
> +/* MMCIF */
> +static struct sh_mmcif_plat_data mmcif0_pdata = {
> + .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +};
> +
> +static struct resource mmcif0_resources[] = {
> + DEFINE_RES_MEM_NAMED(0xee200000, 0x100, "MMCIF0"),
> + DEFINE_RES_IRQ(gic_spi(169)),
> +};
> +
The above needed '__initdata' too. And I have only noticed...
> static const struct pinctrl_map ape6evm_pinctrl_map[] = {
> /* SCIFA0 console */
> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a73a4",
[...]
> @@ -93,6 +119,11 @@ static void __init ape6evm_add_standard_devices(void)
> platform_device_register_resndata(&platform_bus, "smsc911x", -1,
> lan9220_res, ARRAY_SIZE(lan9220_res),
> &lan9220_data, sizeof(lan9220_data));
> + regulator_register_always_on(1, "fixed-3.3V", fixed3v3_power_consumers,
> + ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
> + platform_device_register_resndata(&platform_bus, "sh_mmcif", 0,
> + mmcif0_resources, ARRAY_SIZE(mmcif0_resources),
> + &mmcif0_pdata, sizeof(mmcif0_pdata));
> }
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: shmobile: ape6evm: add MMCIF support
Date: Tue, 30 Jul 2013 16:59:28 +0400 [thread overview]
Message-ID: <51F7B8B0.3080201@cogentembedded.com> (raw)
In-Reply-To: <8711613252ed931037f9e9f8646935519dd8f362.1375174556.git.horms+renesas@verge.net.au>
Hello.
On 30-07-2013 13:00, Simon Horman wrote:
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Add MMCIF support to the APE6EVM board in PIO mode only. Power supply is
> fixed for now, eventually support for the tps80032 regulator, also
> supplying both VDD and VccQ to the MMCIF slot should be added to APE6EVM.
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> Acked-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/board-ape6evm.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index af6dd39..8c7529c 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
[...]
> @@ -54,6 +56,25 @@ static const struct smsc911x_platform_config lan9220_data = {
[...]
> +/* MMCIF */
> +static struct sh_mmcif_plat_data mmcif0_pdata = {
> + .caps = MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +};
> +
> +static struct resource mmcif0_resources[] = {
> + DEFINE_RES_MEM_NAMED(0xee200000, 0x100, "MMCIF0"),
> + DEFINE_RES_IRQ(gic_spi(169)),
> +};
> +
The above needed '__initdata' too. And I have only noticed...
> static const struct pinctrl_map ape6evm_pinctrl_map[] = {
> /* SCIFA0 console */
> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.0", "pfc-r8a73a4",
[...]
> @@ -93,6 +119,11 @@ static void __init ape6evm_add_standard_devices(void)
> platform_device_register_resndata(&platform_bus, "smsc911x", -1,
> lan9220_res, ARRAY_SIZE(lan9220_res),
> &lan9220_data, sizeof(lan9220_data));
> + regulator_register_always_on(1, "fixed-3.3V", fixed3v3_power_consumers,
> + ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
> + platform_device_register_resndata(&platform_bus, "sh_mmcif", 0,
> + mmcif0_resources, ARRAY_SIZE(mmcif0_resources),
> + &mmcif0_pdata, sizeof(mmcif0_pdata));
> }
WBR, Sergei
next prev parent reply other threads:[~2013-07-30 12:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 9:00 [PATCH 0/5] Renesas ARM-based SoC board updates for v3.12 Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 1/5] ARM: shmobile: armadillo800eva: add DMA support to MMCIF Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 2/5] ARM: shmobile: lager: add MMCIF support Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 3/5] ARM: shmobile: select the fixed regulator driver on BockW Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 9:00 ` [PATCH 4/5] ARM: shmobile: ape6evm: add MMCIF support Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 12:59 ` Sergei Shtylyov [this message]
2013-07-30 12:59 ` Sergei Shtylyov
2013-07-31 0:30 ` Simon Horman
2013-07-31 0:30 ` Simon Horman
2013-07-30 9:00 ` [PATCH 5/5] ARM: shmobile: ape6evm: add SDHI interfaces Simon Horman
2013-07-30 9:00 ` Simon Horman
2013-07-30 12:57 ` Sergei Shtylyov
2013-07-30 12:57 ` Sergei Shtylyov
2013-07-31 0:29 ` Simon Horman
2013-07-31 0:29 ` Simon Horman
2013-08-04 20:31 ` [PATCH 0/5] Renesas ARM-based SoC board updates for v3.12 Olof Johansson
2013-08-04 20:31 ` Olof Johansson
2013-08-05 1:39 ` Simon Horman
2013-08-05 1:39 ` Simon Horman
2013-08-14 7:55 ` Olof Johansson
2013-08-14 7:55 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7B8B0.3080201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.