* [PATCH 1/2] Fix filespath for dylan
@ 2013-08-11 23:41 igeiser
2013-08-11 23:41 ` [PATCH 2/2] " igeiser
2013-08-12 3:30 ` [PATCH 1/2] " Denys Dmytriyenko
0 siblings, 2 replies; 7+ messages in thread
From: igeiser @ 2013-08-11 23:41 UTC (permalink / raw)
To: meta-ti
From: Ian Reinhart Geiser <igeiser@devonit.com>
The old way of setting THISDIR in a bbappend clobbers THISDIR for
other layers. This change makes it use the new way that is done
in dylan.
Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
---
recipes-bsp/formfactor/formfactor_0.0.bbappend | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/recipes-bsp/formfactor/formfactor_0.0.bbappend b/recipes-bsp/formfactor/formfactor_0.0.bbappend
index 4b8d0e6..491d403 100644
--- a/recipes-bsp/formfactor/formfactor_0.0.bbappend
+++ b/recipes-bsp/formfactor/formfactor_0.0.bbappend
@@ -1,3 +1,2 @@
-THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
-FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
-
+PRINC := "${@int(PRINC) + 1}"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] Fix filespath for dylan
2013-08-11 23:41 [PATCH 1/2] Fix filespath for dylan igeiser
@ 2013-08-11 23:41 ` igeiser
2013-08-12 3:30 ` Denys Dmytriyenko
2013-08-12 3:30 ` [PATCH 1/2] " Denys Dmytriyenko
1 sibling, 1 reply; 7+ messages in thread
From: igeiser @ 2013-08-11 23:41 UTC (permalink / raw)
To: meta-ti
From: Ian Reinhart Geiser <igeiser@devonit.com>
The old way of setting THISDIR in a bbappend clobbers THISDIR for
other layers. This change makes it use the new way that is done
in dylan.
Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
---
.../xorg-xserver/xserver-xf86-config_0.1.bbappend | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
index 1615df3..491d403 100644
--- a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
+++ b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
@@ -1,5 +1,2 @@
-PRINC = "2"
-
-THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
-FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
-
+PRINC := "${@int(PRINC) + 1}"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Fix filespath for dylan
2013-08-11 23:41 [PATCH 1/2] Fix filespath for dylan igeiser
2013-08-11 23:41 ` [PATCH 2/2] " igeiser
@ 2013-08-12 3:30 ` Denys Dmytriyenko
2013-08-12 4:03 ` Ian Geiser
1 sibling, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2013-08-12 3:30 UTC (permalink / raw)
To: igeiser; +Cc: meta-ti
On Sun, Aug 11, 2013 at 07:41:34PM -0400, igeiser@devonit.com wrote:
> From: Ian Reinhart Geiser <igeiser@devonit.com>
>
> The old way of setting THISDIR in a bbappend clobbers THISDIR for
> other layers. This change makes it use the new way that is done
> in dylan.
Thanks! I've been meaning to fix those for quite some time, but there was
always something more important... :)
> Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
> ---
> recipes-bsp/formfactor/formfactor_0.0.bbappend | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-bsp/formfactor/formfactor_0.0.bbappend b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> index 4b8d0e6..491d403 100644
> --- a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> +++ b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> @@ -1,3 +1,2 @@
> -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> -
> +PRINC := "${@int(PRINC) + 1}"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
The above should be _append since that is what =. operand does and also since
the colon is at the end.
--
Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] Fix filespath for dylan
2013-08-11 23:41 ` [PATCH 2/2] " igeiser
@ 2013-08-12 3:30 ` Denys Dmytriyenko
0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2013-08-12 3:30 UTC (permalink / raw)
To: igeiser; +Cc: meta-ti
On Sun, Aug 11, 2013 at 07:41:35PM -0400, igeiser@devonit.com wrote:
> From: Ian Reinhart Geiser <igeiser@devonit.com>
>
> The old way of setting THISDIR in a bbappend clobbers THISDIR for
> other layers. This change makes it use the new way that is done
> in dylan.
>
> Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
> ---
> .../xorg-xserver/xserver-xf86-config_0.1.bbappend | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> index 1615df3..491d403 100644
> --- a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> +++ b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> @@ -1,5 +1,2 @@
> -PRINC = "2"
> -
> -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> -
> +PRINC := "${@int(PRINC) + 1}"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
Same here - _append is more appropriate.
--
Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Fix filespath for dylan
2013-08-12 3:30 ` [PATCH 1/2] " Denys Dmytriyenko
@ 2013-08-12 4:03 ` Ian Geiser
2013-08-12 4:10 ` Denys Dmytriyenko
0 siblings, 1 reply; 7+ messages in thread
From: Ian Geiser @ 2013-08-12 4:03 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org
I can fix and resubmit. I found it while porting our 8148 build to Dylan. Thanks!
> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denys@ti.com]
> Sent: Sunday, August 11, 2013 11:30 PM
> To: Ian Geiser
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH 1/2] Fix filespath for dylan
>
> On Sun, Aug 11, 2013 at 07:41:34PM -0400, igeiser@devonit.com wrote:
> > From: Ian Reinhart Geiser <igeiser@devonit.com>
> >
> > The old way of setting THISDIR in a bbappend clobbers THISDIR for
> > other layers. This change makes it use the new way that is done in
> > dylan.
>
> Thanks! I've been meaning to fix those for quite some time, but there
> was always something more important... :)
>
>
> > Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
> > ---
> > recipes-bsp/formfactor/formfactor_0.0.bbappend | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > index 4b8d0e6..491d403 100644
> > --- a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > +++ b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > @@ -1,3 +1,2 @@
> > -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> > -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> > -
> > +PRINC := "${@int(PRINC) + 1}"
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> The above should be _append since that is what =. operand does and also
> since
> the colon is at the end.
>
> --
> Denys
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Fix filespath for dylan
2013-08-12 4:03 ` Ian Geiser
@ 2013-08-12 4:10 ` Denys Dmytriyenko
2013-08-12 4:51 ` Ian Geiser
0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2013-08-12 4:10 UTC (permalink / raw)
To: Ian Geiser; +Cc: meta-ti@yoctoproject.org
On Mon, Aug 12, 2013 at 12:03:38AM -0400, Ian Geiser wrote:
> I can fix and resubmit. I found it while porting our 8148 build to Dylan.
> Thanks!
Actually, never mind, I think I'm wrong on this one - looks like I'm not
thinking straight at this late hour... :)
> > -----Original Message-----
> > From: Denys Dmytriyenko [mailto:denys@ti.com]
> > Sent: Sunday, August 11, 2013 11:30 PM
> > To: Ian Geiser
> > Cc: meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [PATCH 1/2] Fix filespath for dylan
> >
> > On Sun, Aug 11, 2013 at 07:41:34PM -0400, igeiser@devonit.com wrote:
> > > From: Ian Reinhart Geiser <igeiser@devonit.com>
> > >
> > > The old way of setting THISDIR in a bbappend clobbers THISDIR for
> > > other layers. This change makes it use the new way that is done in
> > > dylan.
> >
> > Thanks! I've been meaning to fix those for quite some time, but there
> > was always something more important... :)
> >
> >
> > > Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
> > > ---
> > > recipes-bsp/formfactor/formfactor_0.0.bbappend | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > index 4b8d0e6..491d403 100644
> > > --- a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > +++ b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > @@ -1,3 +1,2 @@
> > > -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> > > -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> > > -
> > > +PRINC := "${@int(PRINC) + 1}"
> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > The above should be _append since that is what =. operand does and also
> > since
> > the colon is at the end.
> >
> > --
> > Denys
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] Fix filespath for dylan
2013-08-12 4:10 ` Denys Dmytriyenko
@ 2013-08-12 4:51 ` Ian Geiser
0 siblings, 0 replies; 7+ messages in thread
From: Ian Geiser @ 2013-08-12 4:51 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org
>
> Actually, never mind, I think I'm wrong on this one - looks like I'm
> not thinking straight at this late hour... :)
>
Lol, no problem. BTW, I did these in the Dylan branch, I did not test with master. Is that a problem? I think they are minor enough though.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-12 4:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-11 23:41 [PATCH 1/2] Fix filespath for dylan igeiser
2013-08-11 23:41 ` [PATCH 2/2] " igeiser
2013-08-12 3:30 ` Denys Dmytriyenko
2013-08-12 3:30 ` [PATCH 1/2] " Denys Dmytriyenko
2013-08-12 4:03 ` Ian Geiser
2013-08-12 4:10 ` Denys Dmytriyenko
2013-08-12 4:51 ` Ian Geiser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.