All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <b42378@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, timur@tabi.org,
	rob.herring@calxeda.com, broonie@kernel.org,
	p.zabel@pengutronix.de, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Wed, 14 Aug 2013 13:30:17 +0800	[thread overview]
Message-ID: <20130814053016.GF31651@MrMyself> (raw)
In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net>

Hi Shwan,

On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote:
> I do not think we need this general compatible string.  Device tree
> compatible should be specific.

So I should just use 'fsl,<chip>-spdif" and list all <chip>-spdif
in compatible list?

I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid
for example. So you think I should add all the possible chips to 
the list? But what if some chip I don't know right now that also
uses this spdif controller? Add them to the list later?

Thank you.

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <b42378@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	lars@metafoo.de, linuxppc-dev@lists.ozlabs.org, timur@tabi.org,
	rob.herring@calxeda.com, broonie@kernel.org,
	p.zabel@pengutronix.de, Fabio Estevam <festevam@gmail.com>
Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Wed, 14 Aug 2013 13:30:17 +0800	[thread overview]
Message-ID: <20130814053016.GF31651@MrMyself> (raw)
In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net>

Hi Shwan,

On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote:
> I do not think we need this general compatible string.  Device tree
> compatible should be specific.

So I should just use 'fsl,<chip>-spdif" and list all <chip>-spdif
in compatible list?

I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid
for example. So you think I should add all the possible chips to 
the list? But what if some chip I don't know right now that also
uses this spdif controller? Add them to the list later?

Thank you.

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <b42378@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	broonie@kernel.org, lars@metafoo.de, p.zabel@pengutronix.de,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linuxppc-dev@lists.ozlabs.org, timur@tabi.org,
	rob.herring@calxeda.com
Subject: Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Wed, 14 Aug 2013 13:30:17 +0800	[thread overview]
Message-ID: <20130814053016.GF31651@MrMyself> (raw)
In-Reply-To: <20130814032658.GA16915@S2101-09.ap.freescale.net>

Hi Shwan,

On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote:
> I do not think we need this general compatible string.  Device tree
> compatible should be specific.

So I should just use 'fsl,<chip>-spdif" and list all <chip>-spdif
in compatible list?

I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid
for example. So you think I should add all the possible chips to 
the list? But what if some chip I don't know right now that also
uses this spdif controller? Add them to the list later?

Thank you.




  reply	other threads:[~2013-08-14  5:44 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 12:01 [PATCH v4 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-12 12:01 ` Nicolin Chen
2013-08-12 12:01 ` Nicolin Chen
2013-08-12 12:01 ` [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-12 12:01   ` Nicolin Chen
2013-08-12 12:01   ` Nicolin Chen
2013-08-13 17:58   ` Fabio Estevam
2013-08-13 17:58     ` [alsa-devel] " Fabio Estevam
2013-08-13 17:58     ` Fabio Estevam
2013-08-13 19:01     ` Fabio Estevam
2013-08-13 19:01       ` [alsa-devel] " Fabio Estevam
2013-08-13 19:01       ` Fabio Estevam
2013-08-13 19:02     ` Mark Brown
2013-08-13 19:02       ` [alsa-devel] " Mark Brown
2013-08-13 19:02       ` Mark Brown
2013-08-14  2:09     ` Nicolin Chen
2013-08-14  2:09       ` [alsa-devel] " Nicolin Chen
2013-08-14  2:09       ` Nicolin Chen
2013-08-14  3:27     ` Shawn Guo
2013-08-14  3:27       ` [alsa-devel] " Shawn Guo
2013-08-14  3:27       ` Shawn Guo
2013-08-14  5:30       ` Nicolin Chen [this message]
2013-08-14  5:30         ` Nicolin Chen
2013-08-14  5:30         ` Nicolin Chen
2013-08-14  6:39         ` Shawn Guo
2013-08-14  6:39           ` [alsa-devel] " Shawn Guo
2013-08-14  6:39           ` Shawn Guo
2013-08-14  6:34           ` Nicolin Chen
2013-08-14  6:34             ` [alsa-devel] " Nicolin Chen
2013-08-14  6:34             ` Nicolin Chen
2013-08-14  8:14             ` Shawn Guo
2013-08-14  8:14               ` [alsa-devel] " Shawn Guo
2013-08-14  8:14               ` Shawn Guo
2013-08-14 15:47               ` Stephen Warren
2013-08-14 15:47                 ` [alsa-devel] " Stephen Warren
2013-08-14 15:47                 ` Stephen Warren
2013-08-15  2:18                 ` Nicolin Chen
2013-08-15  2:18                   ` Nicolin Chen
2013-08-15  9:24                   ` Shawn Guo
2013-08-15  9:24                     ` [alsa-devel] " Shawn Guo
2013-08-15  9:24                     ` Shawn Guo
2013-08-16 22:49                     ` Stephen Warren
2013-08-16 22:49                       ` [alsa-devel] " Stephen Warren
2013-08-16 22:49                       ` Stephen Warren
2013-08-12 12:01 ` [PATCH v4 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-12 12:01   ` Nicolin Chen
2013-08-12 12:01   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814053016.GF31651@MrMyself \
    --to=b42378@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rob.herring@calxeda.com \
    --cc=shawn.guo@linaro.org \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.