From: Thierry Reding <thierry.reding@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Stephen Warren <swarren@wwwdotorg.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 4/5] PCI: mvebu: add support for reset on GPIO
Date: Wed, 14 Aug 2013 11:07:24 +0200 [thread overview]
Message-ID: <20130814090715.GA2084@ulmo> (raw)
In-Reply-To: <1376396724-32048-5-git-send-email-sebastian.hesselbarth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Tue, Aug 13, 2013 at 02:25:23PM +0200, Sebastian Hesselbarth wrote:
[...]
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
[...]
> @@ -897,6 +904,30 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
[...]
> + u32 reset_udelay = 20000;
[...]
> + udelay(reset_udelay);
udelay(20000) is probably not a good idea. You should probably use
something like usleep_range() or msleep() here. Also see:
Documentation/timers/timers-howto.txt
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] PCI: mvebu: add support for reset on GPIO
Date: Wed, 14 Aug 2013 11:07:24 +0200 [thread overview]
Message-ID: <20130814090715.GA2084@ulmo> (raw)
In-Reply-To: <1376396724-32048-5-git-send-email-sebastian.hesselbarth@gmail.com>
On Tue, Aug 13, 2013 at 02:25:23PM +0200, Sebastian Hesselbarth wrote:
[...]
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
[...]
> @@ -897,6 +904,30 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
[...]
> + u32 reset_udelay = 20000;
[...]
> + udelay(reset_udelay);
udelay(20000) is probably not a good idea. You should probably use
something like usleep_range() or msleep() here. Also see:
Documentation/timers/timers-howto.txt
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130814/60f5504d/attachment.sig>
next prev parent reply other threads:[~2013-08-14 9:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:25 [PATCH v2 0/5] ARM: dove: DT PCIe support Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 12:25 ` [PATCH v2 1/5] PCI: mvebu: move clock enable before register access Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 12:25 ` [PATCH v2 2/5] PCI: mvebu: increment nports only for registered ports Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 12:25 ` [PATCH v2 3/5] PCI: mvebu: remove subsys_initcall Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 12:25 ` [PATCH v2 4/5] PCI: mvebu: add support for reset on GPIO Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 20:29 ` Thomas Petazzoni
2013-08-13 20:29 ` Thomas Petazzoni
2013-08-13 21:26 ` Jason Cooper
2013-08-13 21:26 ` Jason Cooper
2013-08-14 9:07 ` Thierry Reding [this message]
2013-08-14 9:07 ` Thierry Reding
2013-08-14 9:25 ` Sebastian Hesselbarth
2013-08-14 9:25 ` Sebastian Hesselbarth
2013-08-14 11:53 ` Jason Cooper
2013-08-14 11:53 ` Jason Cooper
2013-08-13 12:25 ` [PATCH v2 5/5] PCI: mvebu: add support for Marvell Dove SoCs Sebastian Hesselbarth
2013-08-13 12:25 ` Sebastian Hesselbarth
2013-08-13 14:01 ` [PATCH v2 0/5] ARM: dove: DT PCIe support Jason Cooper
2013-08-13 14:01 ` Jason Cooper
2013-08-13 15:11 ` Jason Cooper
2013-08-13 15:11 ` Jason Cooper
2013-08-13 17:19 ` Bjorn Helgaas
2013-08-13 17:19 ` Bjorn Helgaas
2013-08-13 18:49 ` Jason Cooper
2013-08-13 18:49 ` Jason Cooper
2013-08-15 16:16 ` Thomas Petazzoni
2013-08-15 16:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814090715.GA2084@ulmo \
--to=thierry.reding@gmail.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.