From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v1 3/5] ARM: mvebu: add Armada 150 uart to lowlevel debug
Date: Sat, 17 Aug 2013 21:01:51 +0200 [thread overview]
Message-ID: <201308172101.51537.arnd@arndb.de> (raw)
In-Reply-To: <1376682098-10580-4-git-send-email-sebastian.hesselbarth@gmail.com>
On Friday 16 August 2013, Sebastian Hesselbarth wrote:
>
> -#ifdef CONFIG_DEBUG_MVEBU_UART_ALTERNATE
> -#define ARMADA_370_XP_REGS_PHYS_BASE 0xf1000000
> -#else
> -#define ARMADA_370_XP_REGS_PHYS_BASE 0xd0000000
> +#if defined(CONFIG_MACH_ARMADA_1500)
> +#define MVEBU_REGS_PHYS_BASE 0xf7f80000
> +#define MVEBU_REGS_VIRT_BASE 0xf7f80000
> +#define MVEBU_UART0_OFFSET 0x00049000
> +#elif defined(CONFIG_DEBUG_MVEBU_UART)
> +#define MVEBU_REGS_PHYS_BASE 0xd0000000
> +#define MVEBU_REGS_VIRT_BASE 0xfec00000
> +#define MVEBU_UART0_OFFSET 0x00012000
> +#else /* CONFIG_DEBUG_MVEBU_UART_ALTERNATE */
It seems wrong to base this on CONFIG_MACH_ARMADA_1500. I think you need to
add a new config option just like we have for all other platforms. The above
makes it impossible to build a multiplatform kernel and select
CONFIG_DEBUG_MVEBU_UART for debugging while keeping CONFIG_MACH_ARMADA_1500
enabled.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v1 3/5] ARM: mvebu: add Armada 150 uart to lowlevel debug
Date: Sat, 17 Aug 2013 21:01:51 +0200 [thread overview]
Message-ID: <201308172101.51537.arnd@arndb.de> (raw)
In-Reply-To: <1376682098-10580-4-git-send-email-sebastian.hesselbarth@gmail.com>
On Friday 16 August 2013, Sebastian Hesselbarth wrote:
>
> -#ifdef CONFIG_DEBUG_MVEBU_UART_ALTERNATE
> -#define ARMADA_370_XP_REGS_PHYS_BASE 0xf1000000
> -#else
> -#define ARMADA_370_XP_REGS_PHYS_BASE 0xd0000000
> +#if defined(CONFIG_MACH_ARMADA_1500)
> +#define MVEBU_REGS_PHYS_BASE 0xf7f80000
> +#define MVEBU_REGS_VIRT_BASE 0xf7f80000
> +#define MVEBU_UART0_OFFSET 0x00049000
> +#elif defined(CONFIG_DEBUG_MVEBU_UART)
> +#define MVEBU_REGS_PHYS_BASE 0xd0000000
> +#define MVEBU_REGS_VIRT_BASE 0xfec00000
> +#define MVEBU_UART0_OFFSET 0x00012000
> +#else /* CONFIG_DEBUG_MVEBU_UART_ALTERNATE */
It seems wrong to base this on CONFIG_MACH_ARMADA_1500. I think you need to
add a new config option just like we have for all other platforms. The above
makes it impossible to build a multiplatform kernel and select
CONFIG_DEBUG_MVEBU_UART for debugging while keeping CONFIG_MACH_ARMADA_1500
enabled.
Arnd
next prev parent reply other threads:[~2013-08-17 19:01 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 19:41 [RFC v1 0/5] ARM: Initial support for Marvell Armada 1500 Sebastian Hesselbarth
2013-08-16 19:41 ` Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 1/5] irqchip: add Armada 1500 APB interrupt controller Sebastian Hesselbarth
2013-08-17 13:24 ` Sebastian Hesselbarth
2013-08-17 13:24 ` Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 2/5] ARM: mvebu: add Armada 1500 to defconfig Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 3/5] ARM: mvebu: add Armada 150 uart to lowlevel debug Sebastian Hesselbarth
2013-08-16 20:39 ` Jason Cooper
2013-08-16 20:39 ` Jason Cooper
2013-08-17 19:01 ` Arnd Bergmann [this message]
2013-08-17 19:01 ` Arnd Bergmann
2013-08-16 19:41 ` [RFC v1 4/5] ARM: mvebu: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-08-16 19:50 ` Jason Cooper
2013-08-16 19:50 ` Jason Cooper
2013-08-16 19:54 ` Sebastian Hesselbarth
2013-08-16 19:54 ` Sebastian Hesselbarth
2013-08-16 20:22 ` Jason Cooper
2013-08-16 20:22 ` Jason Cooper
2013-08-17 19:28 ` Arnd Bergmann
2013-08-17 19:28 ` Arnd Bergmann
2013-08-18 23:11 ` Sebastian Hesselbarth
2013-08-18 23:11 ` Sebastian Hesselbarth
2013-08-19 8:46 ` Arnd Bergmann
2013-08-19 8:46 ` Arnd Bergmann
2013-08-16 19:41 ` [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500 Sebastian Hesselbarth
2013-08-16 20:48 ` Jason Cooper
2013-08-16 20:48 ` Jason Cooper
2013-08-17 13:01 ` Sebastian Hesselbarth
2013-08-17 13:01 ` Sebastian Hesselbarth
2013-08-17 19:08 ` Arnd Bergmann
2013-08-17 19:08 ` Arnd Bergmann
2013-08-17 19:13 ` Arnd Bergmann
2013-08-17 19:13 ` Arnd Bergmann
2013-08-18 23:01 ` Sebastian Hesselbarth
2013-08-18 23:01 ` Sebastian Hesselbarth
2013-08-19 7:44 ` Arnd Bergmann
2013-08-19 7:44 ` Arnd Bergmann
2013-08-19 14:52 ` Sebastian Hesselbarth
2013-08-19 14:52 ` Sebastian Hesselbarth
2013-08-19 17:47 ` Arnd Bergmann
2013-08-19 17:47 ` Arnd Bergmann
2013-08-17 15:38 ` Thomas Petazzoni
2013-08-17 15:38 ` Thomas Petazzoni
2013-08-17 19:12 ` Arnd Bergmann
2013-08-17 19:12 ` Arnd Bergmann
2013-08-18 23:02 ` Sebastian Hesselbarth
2013-08-18 23:02 ` Sebastian Hesselbarth
2013-08-19 7:58 ` Arnd Bergmann
2013-08-19 7:58 ` Arnd Bergmann
2013-08-17 19:32 ` [RFC v1 0/5] ARM: Initial support for Marvell " Arnd Bergmann
2013-08-17 19:32 ` Arnd Bergmann
2013-08-18 23:21 ` Sebastian Hesselbarth
2013-08-18 23:21 ` Sebastian Hesselbarth
2013-08-19 8:03 ` Arnd Bergmann
2013-08-19 8:03 ` Arnd Bergmann
2013-08-18 16:34 ` Thomas Petazzoni
2013-08-18 16:34 ` Thomas Petazzoni
2013-08-27 14:19 ` Thomas Petazzoni
2013-08-27 14:19 ` Thomas Petazzoni
2013-08-27 16:45 ` Sebastian Hesselbarth
2013-08-27 16:45 ` Sebastian Hesselbarth
2013-08-27 16:51 ` Thomas Petazzoni
2013-08-27 16:51 ` Thomas Petazzoni
2013-08-27 19:38 ` Arnd Bergmann
2013-08-27 19:38 ` Arnd Bergmann
2013-08-28 0:14 ` [PATCH RFC v2 0/6] " Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 1/6] irqchip: add DesignWare APB ICTL interrupt controller Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 2/6] ARM: add Marvell Berlin SoC familiy to Marvell doc Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 3/6] ARM: add Marvell Berlin and Armada 1500 to multi_v7_defconfig Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 4/6] ARM: add Marvell Berlin UART0 lowlevel debug Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 5/6] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
2013-08-28 12:14 ` Jason Cooper
2013-08-28 12:14 ` Jason Cooper
2013-08-28 12:23 ` Sebastian Hesselbarth
2013-08-28 12:23 ` Sebastian Hesselbarth
2013-08-28 0:14 ` [PATCH RFC v2 6/6] ARM: add initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-08-28 0:14 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308172101.51537.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.