All of lore.kernel.org
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500
Date: Sat, 17 Aug 2013 15:01:24 +0200	[thread overview]
Message-ID: <520F7424.8030301@gmail.com> (raw)
In-Reply-To: <20130816204831.GX13964@titan.lakedaemon.net>

On 08/16/2013 10:48 PM, Jason Cooper wrote:
> On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote:
>> This adds initial setup for the Marvell Armada 1500 SoCs. The code
>> is fairly straight-forward, but especially _timer_and_clk_init()
>> can be simplified by using default arch hooks. I will have some time
>> until mach-mvebu is prepared for other SoCs moving over, so I can
>> catch up with latest machine simplifications.
>>
>> I am not so sure about the .map_io but I didn't yet fully understand
>> the mapping requirement. Anyway, it is required for iomap and friends
>> to work and basically remaps physical register addressed onto the same
>> virtual addresses.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> +obj-$(CONFIG_MACH_ARMADA_1500)		+= armada-1500.o
>
> guess what?  :)
>
> I swear I had a more substantive comment when I started this.  But after
> a suitable application of gray matter, these nits were all that were
> left. :(

Jason,

thanks for teaching me the alphabet again :) Of course, all your 
comments will be fixed for a real patch set.

I hope Thomas and Gregory will have some time to comment on the
mach-mvebu integration soon which also affects Orion SoCs.

But its weekend, next merge window is far, above just fails to boot
into anything useful due to the lack of drivers - relax :)

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Russell King <linux@arm.linux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500
Date: Sat, 17 Aug 2013 15:01:24 +0200	[thread overview]
Message-ID: <520F7424.8030301@gmail.com> (raw)
In-Reply-To: <20130816204831.GX13964@titan.lakedaemon.net>

On 08/16/2013 10:48 PM, Jason Cooper wrote:
> On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote:
>> This adds initial setup for the Marvell Armada 1500 SoCs. The code
>> is fairly straight-forward, but especially _timer_and_clk_init()
>> can be simplified by using default arch hooks. I will have some time
>> until mach-mvebu is prepared for other SoCs moving over, so I can
>> catch up with latest machine simplifications.
>>
>> I am not so sure about the .map_io but I didn't yet fully understand
>> the mapping requirement. Anyway, it is required for iomap and friends
>> to work and basically remaps physical register addressed onto the same
>> virtual addresses.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> +obj-$(CONFIG_MACH_ARMADA_1500)		+= armada-1500.o
>
> guess what?  :)
>
> I swear I had a more substantive comment when I started this.  But after
> a suitable application of gray matter, these nits were all that were
> left. :(

Jason,

thanks for teaching me the alphabet again :) Of course, all your 
comments will be fixed for a real patch set.

I hope Thomas and Gregory will have some time to comment on the
mach-mvebu integration soon which also affects Orion SoCs.

But its weekend, next merge window is far, above just fails to boot
into anything useful due to the lack of drivers - relax :)

Sebastian

  reply	other threads:[~2013-08-17 13:01 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16 19:41 [RFC v1 0/5] ARM: Initial support for Marvell Armada 1500 Sebastian Hesselbarth
2013-08-16 19:41 ` Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 1/5] irqchip: add Armada 1500 APB interrupt controller Sebastian Hesselbarth
2013-08-17 13:24   ` Sebastian Hesselbarth
2013-08-17 13:24     ` Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 2/5] ARM: mvebu: add Armada 1500 to defconfig Sebastian Hesselbarth
2013-08-16 19:41 ` [RFC v1 3/5] ARM: mvebu: add Armada 150 uart to lowlevel debug Sebastian Hesselbarth
2013-08-16 20:39   ` Jason Cooper
2013-08-16 20:39     ` Jason Cooper
2013-08-17 19:01   ` Arnd Bergmann
2013-08-17 19:01     ` Arnd Bergmann
2013-08-16 19:41 ` [RFC v1 4/5] ARM: mvebu: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-08-16 19:50   ` Jason Cooper
2013-08-16 19:50     ` Jason Cooper
2013-08-16 19:54     ` Sebastian Hesselbarth
2013-08-16 19:54       ` Sebastian Hesselbarth
2013-08-16 20:22   ` Jason Cooper
2013-08-16 20:22     ` Jason Cooper
2013-08-17 19:28   ` Arnd Bergmann
2013-08-17 19:28     ` Arnd Bergmann
2013-08-18 23:11     ` Sebastian Hesselbarth
2013-08-18 23:11       ` Sebastian Hesselbarth
2013-08-19  8:46       ` Arnd Bergmann
2013-08-19  8:46         ` Arnd Bergmann
2013-08-16 19:41 ` [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500 Sebastian Hesselbarth
2013-08-16 20:48   ` Jason Cooper
2013-08-16 20:48     ` Jason Cooper
2013-08-17 13:01     ` Sebastian Hesselbarth [this message]
2013-08-17 13:01       ` Sebastian Hesselbarth
2013-08-17 19:08     ` Arnd Bergmann
2013-08-17 19:08       ` Arnd Bergmann
2013-08-17 19:13       ` Arnd Bergmann
2013-08-17 19:13         ` Arnd Bergmann
2013-08-18 23:01       ` Sebastian Hesselbarth
2013-08-18 23:01         ` Sebastian Hesselbarth
2013-08-19  7:44         ` Arnd Bergmann
2013-08-19  7:44           ` Arnd Bergmann
2013-08-19 14:52       ` Sebastian Hesselbarth
2013-08-19 14:52         ` Sebastian Hesselbarth
2013-08-19 17:47         ` Arnd Bergmann
2013-08-19 17:47           ` Arnd Bergmann
2013-08-17 15:38   ` Thomas Petazzoni
2013-08-17 15:38     ` Thomas Petazzoni
2013-08-17 19:12   ` Arnd Bergmann
2013-08-17 19:12     ` Arnd Bergmann
2013-08-18 23:02     ` Sebastian Hesselbarth
2013-08-18 23:02       ` Sebastian Hesselbarth
2013-08-19  7:58       ` Arnd Bergmann
2013-08-19  7:58         ` Arnd Bergmann
2013-08-17 19:32 ` [RFC v1 0/5] ARM: Initial support for Marvell " Arnd Bergmann
2013-08-17 19:32   ` Arnd Bergmann
2013-08-18 23:21   ` Sebastian Hesselbarth
2013-08-18 23:21     ` Sebastian Hesselbarth
2013-08-19  8:03     ` Arnd Bergmann
2013-08-19  8:03       ` Arnd Bergmann
2013-08-18 16:34 ` Thomas Petazzoni
2013-08-18 16:34   ` Thomas Petazzoni
2013-08-27 14:19 ` Thomas Petazzoni
2013-08-27 14:19   ` Thomas Petazzoni
2013-08-27 16:45   ` Sebastian Hesselbarth
2013-08-27 16:45     ` Sebastian Hesselbarth
2013-08-27 16:51     ` Thomas Petazzoni
2013-08-27 16:51       ` Thomas Petazzoni
2013-08-27 19:38   ` Arnd Bergmann
2013-08-27 19:38     ` Arnd Bergmann
2013-08-28  0:14 ` [PATCH RFC v2 0/6] " Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 1/6] irqchip: add DesignWare APB ICTL interrupt controller Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 2/6] ARM: add Marvell Berlin SoC familiy to Marvell doc Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 3/6] ARM: add Marvell Berlin and Armada 1500 to multi_v7_defconfig Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 4/6] ARM: add Marvell Berlin UART0 lowlevel debug Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 5/6] ARM: add Armada 1500 and Sony NSZ-GS7 device tree files Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth
2013-08-28 12:14   ` Jason Cooper
2013-08-28 12:14     ` Jason Cooper
2013-08-28 12:23     ` Sebastian Hesselbarth
2013-08-28 12:23       ` Sebastian Hesselbarth
2013-08-28  0:14 ` [PATCH RFC v2 6/6] ARM: add initial support for Marvell Berlin SoCs Sebastian Hesselbarth
2013-08-28  0:14   ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520F7424.8030301@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.