Re: [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata()

[Nicolin Chen <b42378@freescale.com>]

Good to know this. Thank you :)

Acked-by: Nicolin Chen <b42378@freescale.com>
(
 I'm not sure if I can use 'Acked-by'.
 If not, pls replace it to 'Reviewed-by'
 Thanks a lot.
)

On Fri, Aug 23, 2013 at 06:14:45PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Driver core clears the driver data to NULL after device_release or on probe 
> failure, so just remove it from here.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Also remove dev_set_drvdata from the remove function
> 
>  sound/soc/fsl/fsl_spdif.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 42a4382..a8ef46a 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -1184,7 +1184,7 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>  					 &spdif_priv->cpu_dai_drv, 1);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to register DAI: %d\n", ret);
> -		goto error_dev;
> +		return ret;
>  	}
>  
>  	ret = imx_pcm_dma_init(pdev);
> @@ -1197,8 +1197,6 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>  
>  error_component:
>  	snd_soc_unregister_component(&pdev->dev);
> -error_dev:
> -	dev_set_drvdata(&pdev->dev, NULL);
>  
>  	return ret;
>  }
> @@ -1207,7 +1205,6 @@ static int fsl_spdif_remove(struct platform_device *pdev)
>  {
>  	imx_pcm_dma_exit(pdev);
>  	snd_soc_unregister_component(&pdev->dev);
> -	dev_set_drvdata(&pdev->dev, NULL);
>  
>  	return 0;
>  }
> -- 
> 1.8.1.2
> 
>