All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <b42378@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata()
Date: Tue, 27 Aug 2013 09:57:44 +0800	[thread overview]
Message-ID: <20130827015743.GA3758@MrMyself> (raw)
In-Reply-To: <20130826115255.GA10783@sirena.org.uk>

On Mon, Aug 26, 2013 at 12:52:55PM +0100, Mark Brown wrote:
> On Mon, Aug 26, 2013 at 02:05:56PM +0800, Nicolin Chen wrote:
> > Good to know this. Thank you :)
> > 
> > Acked-by: Nicolin Chen <b42378@freescale.com>
> > (
> >  I'm not sure if I can use 'Acked-by'.
> >  If not, pls replace it to 'Reviewed-by'
> >  Thanks a lot.
> 
> Reviwed-by: is actually better - acked just means that you don't mind
> the patch while reviewed means that you actaully did a proper review and
> so on.

Thank you for the explain :)

Nicolin

  reply	other threads:[~2013-08-27  2:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-23 21:14 [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata() Fabio Estevam
2013-08-23 21:14 ` [PATCH v2 2/2] ASoC: fsl_spdif: Reduce the noise on comments Fabio Estevam
2013-08-26  6:07   ` Nicolin Chen
2013-08-26  6:05 ` [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata() Nicolin Chen
2013-08-26 11:52   ` Mark Brown
2013-08-27  1:57     ` Nicolin Chen [this message]
2013-08-26 11:53 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827015743.GA3758@MrMyself \
    --to=b42378@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.