From: Nicolin Chen <b42378@freescale.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: fsl_spdif: Reduce the noise on comments
Date: Mon, 26 Aug 2013 14:07:29 +0800 [thread overview]
Message-ID: <20130826060728.GB12524@MrMyself> (raw)
In-Reply-To: <1377292486-7591-2-git-send-email-festevam@gmail.com>
On Fri, Aug 23, 2013 at 06:14:46PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Remove the "====" pattern to let the comments cleaner and more uniform.
>
> Also, do not use multi-line style for a single line comment.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Well, I just wanted to make it distinct.
But I'm fairly okay with this patch.
Thank you.
Acked-by: Nicolin Chen <b42378@freescale.com>
Best regards,
Nicolin Chen
> ---
> Changes since v1:
> - None
> sound/soc/fsl/fsl_spdif.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index bf58086..34b531b 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -555,7 +555,6 @@ struct snd_soc_dai_ops fsl_spdif_dai_ops = {
>
>
> /*
> - * ============================================
> * FSL SPDIF IEC958 controller(mixer) functions
> *
> * Channel status get/put control
> @@ -563,7 +562,6 @@ struct snd_soc_dai_ops fsl_spdif_dai_ops = {
> * Valid bit value get control
> * DPLL lock status get control
> * User bit sync mode selection control
> - * ============================================
> */
>
> static int fsl_spdif_info(struct snd_kcontrol *kcontrol,
> @@ -942,11 +940,7 @@ static const struct snd_soc_component_driver fsl_spdif_component = {
> .name = "fsl-spdif",
> };
>
> -/*
> - * ================
> - * FSL SPDIF REGMAP
> - * ================
> - */
> +/* FSL SPDIF REGMAP */
>
> static bool fsl_spdif_readable_reg(struct device *dev, unsigned int reg)
> {
> --
> 1.8.1.2
>
>
next prev parent reply other threads:[~2013-08-26 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 21:14 [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata() Fabio Estevam
2013-08-23 21:14 ` [PATCH v2 2/2] ASoC: fsl_spdif: Reduce the noise on comments Fabio Estevam
2013-08-26 6:07 ` Nicolin Chen [this message]
2013-08-26 6:05 ` [PATCH v2 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata() Nicolin Chen
2013-08-26 11:52 ` Mark Brown
2013-08-27 1:57 ` Nicolin Chen
2013-08-26 11:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826060728.GB12524@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.