From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>,
Graeme Gregory <gg@slimlogic.co.uk>, Balaji T K <balajitk@ti.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: [patch] iio: adc: twl6030-gpadc: returning success instead of error
Date: Tue, 27 Aug 2013 04:19:02 +0300 [thread overview]
Message-ID: <20130827011902.GC17061@elgon.mountain> (raw)
I've moved the goto down a line after we set the error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index a558516..0ea96c0 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
ret = -ETIMEDOUT;
goto err;
} else if (timeout < 0) {
- goto err;
ret = -EINTR;
+ goto err;
}
switch (mask) {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Cc: Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Oleksandr Kozaruk
<oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>,
Graeme Gregory <gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [patch] iio: adc: twl6030-gpadc: returning success instead of error
Date: Tue, 27 Aug 2013 04:19:02 +0300 [thread overview]
Message-ID: <20130827011902.GC17061@elgon.mountain> (raw)
I've moved the goto down a line after we set the error code.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index a558516..0ea96c0 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
ret = -ETIMEDOUT;
goto err;
} else if (timeout < 0) {
- goto err;
ret = -EINTR;
+ goto err;
}
switch (mask) {
next reply other threads:[~2013-08-27 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 1:19 Dan Carpenter [this message]
2013-08-27 1:19 ` [patch] iio: adc: twl6030-gpadc: returning success instead of error Dan Carpenter
2013-08-28 19:47 ` Jonathan Cameron
2013-08-28 19:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827011902.GC17061@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=balajitk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=oleksandr.kozaruk@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.