From: Jonathan Cameron <jic23@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>,
Graeme Gregory <gg@slimlogic.co.uk>, Balaji T K <balajitk@ti.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [patch] iio: adc: twl6030-gpadc: returning success instead of error
Date: Wed, 28 Aug 2013 20:47:34 +0100 [thread overview]
Message-ID: <521E53D6.8010805@kernel.org> (raw)
In-Reply-To: <20130827011902.GC17061@elgon.mountain>
On 08/27/13 02:19, Dan Carpenter wrote:
> I've moved the goto down a line after we set the error code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Sorry, I was being slow, but Wei Youngjun has already posted a fix for this one.
Just applied to the togreg branch of iio.git
Thanks
Jonathan
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index a558516..0ea96c0 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
> ret = -ETIMEDOUT;
> goto err;
> } else if (timeout < 0) {
> - goto err;
> ret = -EINTR;
> + goto err;
> }
>
> switch (mask) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Oleksandr Kozaruk
<oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>,
Graeme Gregory <gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
Balaji T K <balajitk-l0cyMroinI0@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] iio: adc: twl6030-gpadc: returning success instead of error
Date: Wed, 28 Aug 2013 20:47:34 +0100 [thread overview]
Message-ID: <521E53D6.8010805@kernel.org> (raw)
In-Reply-To: <20130827011902.GC17061-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
On 08/27/13 02:19, Dan Carpenter wrote:
> I've moved the goto down a line after we set the error code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Sorry, I was being slow, but Wei Youngjun has already posted a fix for this one.
Just applied to the togreg branch of iio.git
Thanks
Jonathan
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index a558516..0ea96c0 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -537,8 +537,8 @@ static int twl6030_gpadc_read_raw(struct iio_dev *indio_dev,
> ret = -ETIMEDOUT;
> goto err;
> } else if (timeout < 0) {
> - goto err;
> ret = -EINTR;
> + goto err;
> }
>
> switch (mask) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-08-28 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 1:19 [patch] iio: adc: twl6030-gpadc: returning success instead of error Dan Carpenter
2013-08-27 1:19 ` Dan Carpenter
2013-08-28 19:47 ` Jonathan Cameron [this message]
2013-08-28 19:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521E53D6.8010805@kernel.org \
--to=jic23@kernel.org \
--cc=balajitk@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=oleksandr.kozaruk@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.