From: Felipe Balbi <balbi@ti.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: balbi@ti.com, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ian.campbell@citrix.com, rob@landley.net,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver
Date: Tue, 27 Aug 2013 13:46:58 -0500 [thread overview]
Message-ID: <20130827184658.GS3005@radagast> (raw)
In-Reply-To: <1376472497.2132.6.camel@iivanov-dev.int.mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
On Wed, Aug 14, 2013 at 12:28:17PM +0300, Ivan T. Ivanov wrote:
>
> Hi,
>
> On Mon, 2013-08-12 at 13:24 -0500, Felipe Balbi wrote:
> > On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote:
> > > Hi,
> > >
> > > On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote:
> > > > Hi,
> > > >
> > > > On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote:
> > > > > diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c
> > > > > new file mode 100644
> > > > > index 0000000..e509abc
> > > > > --- /dev/null
> > > > > +++ b/drivers/usb/dwc3/dwc3-msm.c
> > > > > @@ -0,0 +1,175 @@
> > > > > +#undef CONFIG_REGULATOR
> > > >
> > > > why ??????
> > > >
> > >
> > > 1. This shows that driver is still not fully tested
> > > Regulators support is still missing in the MSM
> > > 2. Helps me to load driver successfully.
> >
> > Then remove all the regulator-related code from this.
>
> I would like to keep them. I will just remove #undef line.
> Code will continue to build fine. And once regulators drivers
> are upstreamed this driver 'will not' require further
> modifications.
fair enough.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: <balbi@ti.com>, <rob.herring@calxeda.com>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <swarren@wwwdotorg.org>,
<ian.campbell@citrix.com>, <rob@landley.net>,
<gregkh@linuxfoundation.org>, <grant.likely@linaro.org>,
<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver
Date: Tue, 27 Aug 2013 13:46:58 -0500 [thread overview]
Message-ID: <20130827184658.GS3005@radagast> (raw)
In-Reply-To: <1376472497.2132.6.camel@iivanov-dev.int.mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
On Wed, Aug 14, 2013 at 12:28:17PM +0300, Ivan T. Ivanov wrote:
>
> Hi,
>
> On Mon, 2013-08-12 at 13:24 -0500, Felipe Balbi wrote:
> > On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote:
> > > Hi,
> > >
> > > On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote:
> > > > Hi,
> > > >
> > > > On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote:
> > > > > diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c
> > > > > new file mode 100644
> > > > > index 0000000..e509abc
> > > > > --- /dev/null
> > > > > +++ b/drivers/usb/dwc3/dwc3-msm.c
> > > > > @@ -0,0 +1,175 @@
> > > > > +#undef CONFIG_REGULATOR
> > > >
> > > > why ??????
> > > >
> > >
> > > 1. This shows that driver is still not fully tested
> > > Regulators support is still missing in the MSM
> > > 2. Helps me to load driver successfully.
> >
> > Then remove all the regulator-related code from this.
>
> I would like to keep them. I will just remove #undef line.
> Code will continue to build fine. And once regulators drivers
> are upstreamed this driver 'will not' require further
> modifications.
fair enough.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-27 18:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 11:53 [RFC 0/2] DWC3 USB support for Qualcomm platform Ivan T. Ivanov
[not found] ` <1375789991-30041-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-08-06 11:53 ` [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core Ivan T. Ivanov
2013-08-06 11:53 ` Ivan T. Ivanov
2013-08-06 12:12 ` Pawel Moll
2013-08-06 13:30 ` Ivan T. Ivanov
2013-08-06 13:30 ` Ivan T. Ivanov
2013-08-06 14:03 ` Mark Rutland
2013-08-06 14:36 ` Ivan T. Ivanov
2013-08-08 9:16 ` Mark Rutland
2013-08-06 11:53 ` [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver Ivan T. Ivanov
[not found] ` <1375789991-30041-3-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-08-06 12:21 ` Pawel Moll
2013-08-06 12:21 ` Pawel Moll
2013-08-06 13:46 ` Ivan T. Ivanov
2013-08-06 15:15 ` Pawel Moll
2013-08-06 17:53 ` Ivan T. Ivanov
2013-08-09 13:24 ` Felipe Balbi
2013-08-06 14:07 ` Mark Rutland
2013-08-06 14:41 ` Ivan T. Ivanov
2013-08-09 13:23 ` Felipe Balbi
2013-08-09 13:23 ` Felipe Balbi
2013-08-09 16:09 ` Ivan T. Ivanov
2013-08-12 18:24 ` Felipe Balbi
2013-08-12 18:24 ` Felipe Balbi
2013-08-14 9:28 ` Ivan T. Ivanov
2013-08-27 18:46 ` Felipe Balbi [this message]
2013-08-27 18:46 ` Felipe Balbi
2013-08-14 9:43 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827184658.GS3005@radagast \
--to=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=iivanov@mm-sol.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.