All of lore.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [Question]: about the paramters of func generic_file_buffered_write.
Date: Fri, 30 Aug 2013 17:14:47 +0800	[thread overview]
Message-ID: <201308301714452181275@gmail.com> (raw)

Hi all,
	The definition of func generic_file_buffered_write is:
 		ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,
                							unsigned long, loff_t, loff_t *, size_t, ssize_t);
The fourth and fifth paratmers indicate the current pos of file.
Every place which call this function, it set the fourth to iocb->ki_pos(maybe not but equal).
The fifth parameter is set &iocb->ki_pos.

I think we can remove two parameters. Those parameter can replace by the files of struct kiocb in the fun
of generic_file_buffered_write.

Or am i missing something?

Thansk!
Jianpeng Ma

WARNING: multiple messages have this Message-ID (diff)
From: majianpeng <majianpeng@gmail.com>
To: viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [Question]: about the paramters of func generic_file_buffered_write.
Date: Fri, 30 Aug 2013 17:14:47 +0800	[thread overview]
Message-ID: <201308301714452181275@gmail.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 763 bytes --]

Hi all,
	The definition of func generic_file_buffered_write is:
 		ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,
                							unsigned long, loff_t, loff_t *, size_t, ssize_t);
The fourth and fifth paratmers indicate the current pos of file.
Every place which call this function, it set the fourth to iocb->ki_pos(maybe not but equal).
The fifth parameter is set &iocb->ki_pos.

I think we can remove two parameters. Those parameter can replace by the files of struct kiocb in the fun
of generic_file_buffered_write.

Or am i missing something?

Thansk!
Jianpeng Maÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

             reply	other threads:[~2013-08-30  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  9:14 majianpeng [this message]
2013-08-30  9:14 ` [Question]: about the paramters of func generic_file_buffered_write majianpeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201308301714452181275@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.