From: Marek Vasut <marex@denx.de>
To: "Jürgen Beisert" <jbe@pengutronix.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
fabio.estevam@freescale.com,
linux-arm-kernel@lists.infradead.org, jic23@cam.ac.uk
Subject: Re: [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection
Date: Fri, 6 Sep 2013 14:58:25 +0200 [thread overview]
Message-ID: <201309061458.25841.marex@denx.de> (raw)
In-Reply-To: <201309061430.50736.jbe@pengutronix.de>
Dear J=FCrgen Beisert,
> On Friday 06 September 2013 14:26:11 Dan Carpenter wrote:
> > On Fri, Sep 06, 2013 at 12:08:42PM +0200, Juergen Beisert wrote:
> > > +static int mxs_lradc_read_ts_channel(struct mxs_lradc *lradc)
> > > +{
> > > + u32 reg;
> > > + int val;
> > > +
> > > + reg =3D readl(lradc->base + LRADC_CTRL1);
> > > +
> > > + /* only channels 3 to 5 are of interest here */
> > > + if (reg & LRADC_CTRL1_LRADC_IRQ(TS_CH_YP)) {
> > > + pr_devel("!3");
> >=20
> > Gar. I meant to comment on this the first time this patch was sent.
> >=20
> > Please remove the pr_devel() calls. They are nonsense.
>=20
> They are very helpful for development to monitor the statemachine... :) B=
ut
> you are right, I will remove them.
You can put them into a separate patch which can be NAK'd separatelly :)
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection
Date: Fri, 6 Sep 2013 14:58:25 +0200 [thread overview]
Message-ID: <201309061458.25841.marex@denx.de> (raw)
In-Reply-To: <201309061430.50736.jbe@pengutronix.de>
Dear J?rgen Beisert,
> On Friday 06 September 2013 14:26:11 Dan Carpenter wrote:
> > On Fri, Sep 06, 2013 at 12:08:42PM +0200, Juergen Beisert wrote:
> > > +static int mxs_lradc_read_ts_channel(struct mxs_lradc *lradc)
> > > +{
> > > + u32 reg;
> > > + int val;
> > > +
> > > + reg = readl(lradc->base + LRADC_CTRL1);
> > > +
> > > + /* only channels 3 to 5 are of interest here */
> > > + if (reg & LRADC_CTRL1_LRADC_IRQ(TS_CH_YP)) {
> > > + pr_devel("!3");
> >
> > Gar. I meant to comment on this the first time this patch was sent.
> >
> > Please remove the pr_devel() calls. They are nonsense.
>
> They are very helpful for development to monitor the statemachine... :) But
> you are right, I will remove them.
You can put them into a separate patch which can be NAK'd separatelly :)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-06 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 10:08 [RFCv2] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-06 10:08 ` [PATCH 1/5] Staging/iio/adc/touchscreen/MXS: distinguish i.MX23's and i.MX28's LRADC Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-06 10:08 ` [PATCH 2/5] Staging/iio/adc/touchscreen/MXS: separate i.MX28 specific register bits Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-06 10:08 ` [PATCH 3/5] Staging/iio/adc/touchscreen/MXS: add i.MX23 support to the LRADC driver Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-06 10:08 ` [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
2013-09-06 12:26 ` Dan Carpenter
2013-09-06 12:26 ` Dan Carpenter
2013-09-06 12:30 ` Jürgen Beisert
2013-09-06 12:30 ` Jürgen Beisert
2013-09-06 12:58 ` Marek Vasut [this message]
2013-09-06 12:58 ` Marek Vasut
2013-09-06 10:08 ` [PATCH 5/5] Staging/iio/adc/touchscreen/MXS: Remove old touchscreen detection implementation Juergen Beisert
2013-09-06 10:08 ` Juergen Beisert
-- strict thread matches above, loose matches on Subject: below --
2013-09-09 8:03 [RFCv3] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-09 8:03 ` [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-09 8:03 ` Juergen Beisert
2013-09-04 13:01 [RFC] staging/iio/adc: change the MXS touchscreen driver implementation Juergen Beisert
2013-09-04 13:01 ` [PATCH 4/5] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Juergen Beisert
2013-09-04 13:01 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309061458.25841.marex@denx.de \
--to=marex@denx.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=jbe@pengutronix.de \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.