From: Bob Copeland <me@bobcopeland.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 1/7] ath10k: simplify HTC credits calculation
Date: Tue, 10 Sep 2013 10:14:13 -0400 [thread overview]
Message-ID: <20130910141413.GE29385@localhost> (raw)
In-Reply-To: <1378821003-22925-2-git-send-email-michal.kazior@tieto.com>
On Tue, Sep 10, 2013 at 03:49:57PM +0200, Michal Kazior wrote:
> + skb = __skb_dequeue(&ep->tx_queue);
> +
> + if (ep->tx_credit_flow_enabled) {
> + /* integer division w/ round-up */
> + credits = (skb->len + htc->target_credit_size - 1) /
> + htc->target_credit_size;
There's a macro for that...
credits = DIV_ROUND_UP(skb->len, htc->target_credit_size);
--
Bob Copeland %% www.bobcopeland.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/7] ath10k: simplify HTC credits calculation
Date: Tue, 10 Sep 2013 10:14:13 -0400 [thread overview]
Message-ID: <20130910141413.GE29385@localhost> (raw)
In-Reply-To: <1378821003-22925-2-git-send-email-michal.kazior@tieto.com>
On Tue, Sep 10, 2013 at 03:49:57PM +0200, Michal Kazior wrote:
> + skb = __skb_dequeue(&ep->tx_queue);
> +
> + if (ep->tx_credit_flow_enabled) {
> + /* integer division w/ round-up */
> + credits = (skb->len + htc->target_credit_size - 1) /
> + htc->target_credit_size;
There's a macro for that...
credits = DIV_ROUND_UP(skb->len, htc->target_credit_size);
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2013-09-10 14:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 13:49 [PATCH 0/7] ath10k: improve TX path Michal Kazior
2013-09-10 13:49 ` Michal Kazior
2013-09-10 13:49 ` [PATCH 1/7] ath10k: simplify HTC credits calculation Michal Kazior
2013-09-10 13:49 ` Michal Kazior
2013-09-10 14:14 ` Bob Copeland [this message]
2013-09-10 14:14 ` Bob Copeland
2013-09-11 5:06 ` Michal Kazior
2013-09-11 5:06 ` Michal Kazior
2013-09-10 13:49 ` [PATCH 2/7] ath10k: add HTC TX credits replenishing notification Michal Kazior
2013-09-10 13:49 ` Michal Kazior
2013-09-10 13:49 ` [PATCH 3/7] ath10k: make WMI commands block by design Michal Kazior
2013-09-10 13:49 ` Michal Kazior
2013-09-10 13:50 ` [PATCH 4/7] ath10k: simplify HTC command submitting Michal Kazior
2013-09-10 13:50 ` Michal Kazior
2013-09-10 13:50 ` [PATCH 5/7] ath10k: improve beacon submission latency Michal Kazior
2013-09-10 13:50 ` Michal Kazior
2013-09-12 16:47 ` Kalle Valo
2013-09-12 16:47 ` Kalle Valo
2013-09-10 13:50 ` [PATCH 6/7] ath10k: remove wmi pending count limit Michal Kazior
2013-09-10 13:50 ` Michal Kazior
2013-09-10 13:50 ` [PATCH 7/7] ath10k: remove wmi event worker thread Michal Kazior
2013-09-10 13:50 ` Michal Kazior
2013-09-12 16:48 ` [PATCH 0/7] ath10k: improve TX path Kalle Valo
2013-09-12 16:48 ` Kalle Valo
2013-09-13 12:16 ` [PATCHv2 " Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 1/7] ath10k: simplify HTC credits calculation Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 2/7] ath10k: add HTC TX credits replenishing notification Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 3/7] ath10k: make WMI commands block by design Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 4/7] ath10k: simplify HTC command submitting Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 5/7] ath10k: improve beacon submission latency Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 6/7] ath10k: remove wmi pending count limit Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-13 12:16 ` [PATCHv2 7/7] ath10k: remove wmi event worker thread Michal Kazior
2013-09-13 12:16 ` Michal Kazior
2013-09-16 17:05 ` [PATCHv2 0/7] ath10k: improve TX path Kalle Valo
2013-09-16 17:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910141413.GE29385@localhost \
--to=me@bobcopeland.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.