All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 5/7] ath10k: improve beacon submission latency
Date: Thu, 12 Sep 2013 19:47:36 +0300	[thread overview]
Message-ID: <87sixadm1j.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <1378821003-22925-6-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 10 Sep 2013 15:50:01 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> The patch prevents beacon misses in some case of
> heavy load on a system.
>
> If a beacon can't be transmitted directly from an
> SWBA event it will be left in arvif->beacon and
> transmission will be retried once TX credits
> become available.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

>  static void ath10k_wmi_op_ep_tx_credits(struct ath10k *ar)
>  {
> +	ath10k_wmi_tx_beacons_nowait(ar);
>  	wake_up(&ar->wmi.tx_credits_wq);
>  }
>  
> @@ -131,6 +174,7 @@ static int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb,
>  	int ret = -EINVAL;
>  
>  	wait_event_timeout(ar->wmi.tx_credits_wq, ({
> +		ath10k_wmi_tx_beacons_nowait(ar);
>  		ret = ath10k_wmi_cmd_send_nowait(ar, skb, cmd_id);
>  		(ret != -EAGAIN);

Please add a short comment to both calls of
ath10k_wmi_tx_beacons_nowait(). Something like "first transmit all
pending beacons" or similar.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/7] ath10k: improve beacon submission latency
Date: Thu, 12 Sep 2013 19:47:36 +0300	[thread overview]
Message-ID: <87sixadm1j.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <1378821003-22925-6-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 10 Sep 2013 15:50:01 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> The patch prevents beacon misses in some case of
> heavy load on a system.
>
> If a beacon can't be transmitted directly from an
> SWBA event it will be left in arvif->beacon and
> transmission will be retried once TX credits
> become available.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

>  static void ath10k_wmi_op_ep_tx_credits(struct ath10k *ar)
>  {
> +	ath10k_wmi_tx_beacons_nowait(ar);
>  	wake_up(&ar->wmi.tx_credits_wq);
>  }
>  
> @@ -131,6 +174,7 @@ static int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb,
>  	int ret = -EINVAL;
>  
>  	wait_event_timeout(ar->wmi.tx_credits_wq, ({
> +		ath10k_wmi_tx_beacons_nowait(ar);
>  		ret = ath10k_wmi_cmd_send_nowait(ar, skb, cmd_id);
>  		(ret != -EAGAIN);

Please add a short comment to both calls of
ath10k_wmi_tx_beacons_nowait(). Something like "first transmit all
pending beacons" or similar.

-- 
Kalle Valo

  reply	other threads:[~2013-09-12 16:50 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 13:49 [PATCH 0/7] ath10k: improve TX path Michal Kazior
2013-09-10 13:49 ` Michal Kazior
2013-09-10 13:49 ` [PATCH 1/7] ath10k: simplify HTC credits calculation Michal Kazior
2013-09-10 13:49   ` Michal Kazior
2013-09-10 14:14   ` Bob Copeland
2013-09-10 14:14     ` Bob Copeland
2013-09-11  5:06     ` Michal Kazior
2013-09-11  5:06       ` Michal Kazior
2013-09-10 13:49 ` [PATCH 2/7] ath10k: add HTC TX credits replenishing notification Michal Kazior
2013-09-10 13:49   ` Michal Kazior
2013-09-10 13:49 ` [PATCH 3/7] ath10k: make WMI commands block by design Michal Kazior
2013-09-10 13:49   ` Michal Kazior
2013-09-10 13:50 ` [PATCH 4/7] ath10k: simplify HTC command submitting Michal Kazior
2013-09-10 13:50   ` Michal Kazior
2013-09-10 13:50 ` [PATCH 5/7] ath10k: improve beacon submission latency Michal Kazior
2013-09-10 13:50   ` Michal Kazior
2013-09-12 16:47   ` Kalle Valo [this message]
2013-09-12 16:47     ` Kalle Valo
2013-09-10 13:50 ` [PATCH 6/7] ath10k: remove wmi pending count limit Michal Kazior
2013-09-10 13:50   ` Michal Kazior
2013-09-10 13:50 ` [PATCH 7/7] ath10k: remove wmi event worker thread Michal Kazior
2013-09-10 13:50   ` Michal Kazior
2013-09-12 16:48 ` [PATCH 0/7] ath10k: improve TX path Kalle Valo
2013-09-12 16:48   ` Kalle Valo
2013-09-13 12:16 ` [PATCHv2 " Michal Kazior
2013-09-13 12:16   ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 1/7] ath10k: simplify HTC credits calculation Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 2/7] ath10k: add HTC TX credits replenishing notification Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 3/7] ath10k: make WMI commands block by design Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 4/7] ath10k: simplify HTC command submitting Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 5/7] ath10k: improve beacon submission latency Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 6/7] ath10k: remove wmi pending count limit Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-13 12:16   ` [PATCHv2 7/7] ath10k: remove wmi event worker thread Michal Kazior
2013-09-13 12:16     ` Michal Kazior
2013-09-16 17:05   ` [PATCHv2 0/7] ath10k: improve TX path Kalle Valo
2013-09-16 17:05     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sixadm1j.fsf@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.