* [PATCH] xfs: remove dead code from xlog_recover_inode_pass2 [not found] <20130912140122.873071199@sgi.com> @ 2013-09-12 14:01 ` Mark Tinguely 2013-09-12 14:50 ` Ben Myers 0 siblings, 1 reply; 2+ messages in thread From: Mark Tinguely @ 2013-09-12 14:01 UTC (permalink / raw) To: xfs; +Cc: Dan Carpenter [-- Attachment #1: xfs-remove-dead-code-xlog_recover_inode_pass2.patch --] [-- Type: text/plain, Size: 821 bytes --] Additional code in the error handler of xlog_recover_inode_pass2() results in the following error: static checker warning: "fs/xfs/xfs_log_recover.c:2999 xlog_recover_inode_pass2() info: ignoring unreachable code." Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mark Tinguely <tinguely@sgi.com> --- fs/xfs/xfs_log_recover.c | 3 --- 1 file changed, 3 deletions(-) Index: b/fs/xfs/xfs_log_recover.c =================================================================== --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -2995,9 +2995,6 @@ error: if (need_free) kmem_free(in_f); return XFS_ERROR(error); - - xfs_buf_relse(bp); - goto error; } /* _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: remove dead code from xlog_recover_inode_pass2 2013-09-12 14:01 ` [PATCH] xfs: remove dead code from xlog_recover_inode_pass2 Mark Tinguely @ 2013-09-12 14:50 ` Ben Myers 0 siblings, 0 replies; 2+ messages in thread From: Ben Myers @ 2013-09-12 14:50 UTC (permalink / raw) To: Mark Tinguely; +Cc: Dan Carpenter, xfs On Thu, Sep 12, 2013 at 09:01:23AM -0500, Mark Tinguely wrote: > Additional code in the error handler of xlog_recover_inode_pass2() > results in the following error: > > static checker warning: "fs/xfs/xfs_log_recover.c:2999 > xlog_recover_inode_pass2() > info: ignoring unreachable code." > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Mark Tinguely <tinguely@sgi.com> Looks fine. Applied. Reviewed-by: Ben Myers <bpm@sgi.com> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-12 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130912140122.873071199@sgi.com>
2013-09-12 14:01 ` [PATCH] xfs: remove dead code from xlog_recover_inode_pass2 Mark Tinguely
2013-09-12 14:50 ` Ben Myers
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.