All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] Add cpuconfig nodes in dts for smp configure.
Date: Sat, 14 Sep 2013 13:50:11 +0200	[thread overview]
Message-ID: <20130914115011.GA2746@lukather> (raw)
In-Reply-To: <1378968687-8200-3-git-send-email-cinifr@gmail.com>

Hi Fan,

On Thu, Sep 12, 2013 at 02:51:25PM +0800, Fan Rong wrote:
> Signed-off-by: Fan Rong <cinifr@gmail.com>
> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 999ff45..bfedcb2 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -20,13 +20,13 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpu at 0 {
> +		cpu0: cpu at 0  {
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <0>;
>  		};
>  
> -		cpu at 1 {
> +		cpu1: cpu at 1 {

Both these changes don't seem really needed, are they?
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <1>;
> @@ -167,6 +167,11 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		cc: cpuconfig at 01c25c00 {
> +			compatible = "allwinner,sun7i-cc";

Please use the sun7i-a20 prefix, and I'd prefer cpu-config instead of
"cc".

Thanks for working on this!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130914/4cf66fd8/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Fan Rong <cinifr@gmail.com>
Cc: coosty@163.com, daniel.lezcano@linaro.org,
	linux@arm.linux.org.uk, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mark.rutland@arm.com,
	pawel.moll@arm.co, rob.herring@calxeda.com,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/4] Add cpuconfig nodes in dts for smp configure.
Date: Sat, 14 Sep 2013 13:50:11 +0200	[thread overview]
Message-ID: <20130914115011.GA2746@lukather> (raw)
In-Reply-To: <1378968687-8200-3-git-send-email-cinifr@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

Hi Fan,

On Thu, Sep 12, 2013 at 02:51:25PM +0800, Fan Rong wrote:
> Signed-off-by: Fan Rong <cinifr@gmail.com>
> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 999ff45..bfedcb2 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -20,13 +20,13 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpu@0 {
> +		cpu0: cpu@0  {
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <0>;
>  		};
>  
> -		cpu@1 {
> +		cpu1: cpu@1 {

Both these changes don't seem really needed, are they?
>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <1>;
> @@ -167,6 +167,11 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		cc: cpuconfig@01c25c00 {
> +			compatible = "allwinner,sun7i-cc";

Please use the sun7i-a20 prefix, and I'd prefer cpu-config instead of
"cc".

Thanks for working on this!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-09-14 11:50 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12  6:51 [PATCH 0/4] Add smp support for Allwinner A20 and phy arch count timer Fan Rong
2013-09-12  6:51 ` Fan Rong
2013-09-12  6:51 ` [PATCH 1/4] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-12  6:51   ` Fan Rong
2013-09-12 14:26   ` Mark Rutland
2013-09-12 14:26     ` Mark Rutland
2013-09-12 15:53     ` cinifr
2013-09-12 15:53       ` cinifr
2013-09-12 14:40   ` Russell King - ARM Linux
2013-09-12 14:40     ` Russell King - ARM Linux
2013-09-12  6:51 ` [PATCH 2/4] Add cpuconfig nodes in dts for smp configure Fan Rong
2013-09-12  6:51   ` Fan Rong
2013-09-14 11:50   ` Maxime Ripard [this message]
2013-09-14 11:50     ` Maxime Ripard
2013-09-12  6:51 ` [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7 Fan Rong
2013-09-12  6:51   ` Fan Rong
2013-09-12 11:24   ` Mark Rutland
2013-09-12 11:24     ` Mark Rutland
2013-09-12 14:33     ` Russell King - ARM Linux
2013-09-12 14:33       ` Russell King - ARM Linux
2013-09-12 16:09       ` cinifr
2013-09-12 16:09         ` cinifr
2013-09-12 15:39     ` [linux-sunxi] " Ian Campbell
2013-09-12 15:39       ` Ian Campbell
2013-09-12 16:07     ` cinifr
2013-09-12 16:07       ` cinifr
2013-09-12 16:39       ` Marc Zyngier
2013-09-12 16:39         ` Marc Zyngier
2013-09-13  8:49         ` cinifr
2013-09-13  8:49           ` cinifr
2013-09-13  9:30           ` Marc Zyngier
2013-09-13  9:30             ` Marc Zyngier
2013-09-13 13:09             ` cinifr
2013-09-13 13:09               ` cinifr
2013-09-13 13:40               ` Marc Zyngier
2013-09-13 13:40                 ` Marc Zyngier
2013-09-13 14:55                 ` cinifr
2013-09-13 14:55                   ` cinifr
2013-09-18  9:03                 ` cinifr
2013-09-18  9:03                   ` cinifr
2013-09-14 12:05             ` maxime.ripard at free-electrons.com
2013-09-14 12:05               ` maxime.ripard
2013-09-16  8:16               ` Marc Zyngier
2013-09-16  8:16                 ` Marc Zyngier
2013-09-12  6:51 ` [PATCH 4/4] Add arch count timer node in dts for Allwinner A20(sunxi 7i) Fan Rong
2013-09-12  6:51   ` Fan Rong
2013-09-12 14:57   ` Mark Rutland
2013-09-12 14:57     ` Mark Rutland
2013-09-12 15:44     ` [linux-sunxi] " Ian Campbell
2013-09-12 15:44       ` Ian Campbell
2013-09-12 16:23       ` cinifr
2013-09-12 16:23         ` cinifr
2013-09-12 19:53         ` Henrik Nordström
2013-09-12 19:53           ` Henrik Nordström
2013-09-12 14:39 ` [PATCH 0/4] Add smp support for Allwinner A20 and phy arch count timer Mark Rutland
2013-09-12 14:39   ` Mark Rutland
2013-09-12 15:46   ` cinifr
2013-09-12 15:46     ` cinifr
2013-09-13 11:20     ` Mark Rutland
2013-09-13 11:20       ` Mark Rutland
2013-09-13 13:23       ` cinifr
2013-09-13 13:23         ` cinifr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130914115011.GA2746@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.