From: maxime.ripard@free-electrons.com (maxime.ripard at free-electrons.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.
Date: Sat, 14 Sep 2013 14:05:57 +0200 [thread overview]
Message-ID: <20130914120557.GB2746@lukather> (raw)
In-Reply-To: <5232DB49.4050701@arm.com>
Hi Marc, Fan,
On Fri, Sep 13, 2013 at 10:30:49AM +0100, Marc Zyngier wrote:
> On 13/09/13 09:49, cinifr wrote:
> > On 13 September 2013 00:39, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > I am wondering what is the principle between kernel and bootload?
> > What should be done in bootloader and what should be done in kernel?
> > As you said, If kernel boot from hyp, Kernel can set CNTVOFF to zero
> > directly, does we add the code to set CNTVOFF in kernel? But, if
> > kernel boot from PL1 NS=0, Does kernel need to switch hyp mode to
> > set CNTVOFF and return PL1 NS=0 mode? Or,kernel dont care it because
> > kernel believe bootloader have set CNTVOFF before?
>
> In an ideal world, the bootloader should set CNTVOFF to zero. The fact
> that the kernel does it too when booted in HYP mode is to preserve
> itself from from broken bootloaders.
>
> CNTVOFF can only be setup from either HYP or Secure Monitor mode with
> SCR.NS == 1, so if you run your kernel in secure mode, it is always best
> to do it in the bootloader.
What would happen exactly if a kernel expects CNTVOFF to be set to 0,
and that your bootloader don't set it?
>From what you're saying, it's will be set by the kernel if it's booted
in hypervisor mode, but what if it's not?
The ARM documentation says that the CNTVOFF register will hold an
undefined value, how would that affect the kernel?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130914/6c9e137f/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "maxime.ripard@free-electrons.com" <maxime.ripard@free-electrons.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: cinifr <cinifr@gmail.com>, Mark Rutland <Mark.Rutland@arm.com>,
"coosty@163.com" <coosty@163.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pawel.moll@arm.co" <pawel.moll@arm.co>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7.
Date: Sat, 14 Sep 2013 14:05:57 +0200 [thread overview]
Message-ID: <20130914120557.GB2746@lukather> (raw)
In-Reply-To: <5232DB49.4050701@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]
Hi Marc, Fan,
On Fri, Sep 13, 2013 at 10:30:49AM +0100, Marc Zyngier wrote:
> On 13/09/13 09:49, cinifr wrote:
> > On 13 September 2013 00:39, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > I am wondering what is the principle between kernel and bootload?
> > What should be done in bootloader and what should be done in kernel?
> > As you said, If kernel boot from hyp, Kernel can set CNTVOFF to zero
> > directly, does we add the code to set CNTVOFF in kernel? But, if
> > kernel boot from PL1 NS=0, Does kernel need to switch hyp mode to
> > set CNTVOFF and return PL1 NS=0 mode? Or,kernel dont care it because
> > kernel believe bootloader have set CNTVOFF before?
>
> In an ideal world, the bootloader should set CNTVOFF to zero. The fact
> that the kernel does it too when booted in HYP mode is to preserve
> itself from from broken bootloaders.
>
> CNTVOFF can only be setup from either HYP or Secure Monitor mode with
> SCR.NS == 1, so if you run your kernel in secure mode, it is always best
> to do it in the bootloader.
What would happen exactly if a kernel expects CNTVOFF to be set to 0,
and that your bootloader don't set it?
From what you're saying, it's will be set by the kernel if it's booted
in hypervisor mode, but what if it's not?
The ARM documentation says that the CNTVOFF register will hold an
undefined value, how would that affect the kernel?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-14 12:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:51 [PATCH 0/4] Add smp support for Allwinner A20 and phy arch count timer Fan Rong
2013-09-12 6:51 ` Fan Rong
2013-09-12 6:51 ` [PATCH 1/4] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-12 6:51 ` Fan Rong
2013-09-12 14:26 ` Mark Rutland
2013-09-12 14:26 ` Mark Rutland
2013-09-12 15:53 ` cinifr
2013-09-12 15:53 ` cinifr
2013-09-12 14:40 ` Russell King - ARM Linux
2013-09-12 14:40 ` Russell King - ARM Linux
2013-09-12 6:51 ` [PATCH 2/4] Add cpuconfig nodes in dts for smp configure Fan Rong
2013-09-12 6:51 ` Fan Rong
2013-09-14 11:50 ` Maxime Ripard
2013-09-14 11:50 ` Maxime Ripard
2013-09-12 6:51 ` [PATCH 3/4] Add physical count arch timer support for clocksource in ARMv7 Fan Rong
2013-09-12 6:51 ` Fan Rong
2013-09-12 11:24 ` Mark Rutland
2013-09-12 11:24 ` Mark Rutland
2013-09-12 14:33 ` Russell King - ARM Linux
2013-09-12 14:33 ` Russell King - ARM Linux
2013-09-12 16:09 ` cinifr
2013-09-12 16:09 ` cinifr
2013-09-12 15:39 ` [linux-sunxi] " Ian Campbell
2013-09-12 15:39 ` Ian Campbell
2013-09-12 16:07 ` cinifr
2013-09-12 16:07 ` cinifr
2013-09-12 16:39 ` Marc Zyngier
2013-09-12 16:39 ` Marc Zyngier
2013-09-13 8:49 ` cinifr
2013-09-13 8:49 ` cinifr
2013-09-13 9:30 ` Marc Zyngier
2013-09-13 9:30 ` Marc Zyngier
2013-09-13 13:09 ` cinifr
2013-09-13 13:09 ` cinifr
2013-09-13 13:40 ` Marc Zyngier
2013-09-13 13:40 ` Marc Zyngier
2013-09-13 14:55 ` cinifr
2013-09-13 14:55 ` cinifr
2013-09-18 9:03 ` cinifr
2013-09-18 9:03 ` cinifr
2013-09-14 12:05 ` maxime.ripard at free-electrons.com [this message]
2013-09-14 12:05 ` maxime.ripard
2013-09-16 8:16 ` Marc Zyngier
2013-09-16 8:16 ` Marc Zyngier
2013-09-12 6:51 ` [PATCH 4/4] Add arch count timer node in dts for Allwinner A20(sunxi 7i) Fan Rong
2013-09-12 6:51 ` Fan Rong
2013-09-12 14:57 ` Mark Rutland
2013-09-12 14:57 ` Mark Rutland
2013-09-12 15:44 ` [linux-sunxi] " Ian Campbell
2013-09-12 15:44 ` Ian Campbell
2013-09-12 16:23 ` cinifr
2013-09-12 16:23 ` cinifr
2013-09-12 19:53 ` Henrik Nordström
2013-09-12 19:53 ` Henrik Nordström
2013-09-12 14:39 ` [PATCH 0/4] Add smp support for Allwinner A20 and phy arch count timer Mark Rutland
2013-09-12 14:39 ` Mark Rutland
2013-09-12 15:46 ` cinifr
2013-09-12 15:46 ` cinifr
2013-09-13 11:20 ` Mark Rutland
2013-09-13 11:20 ` Mark Rutland
2013-09-13 13:23 ` cinifr
2013-09-13 13:23 ` cinifr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914120557.GB2746@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.