From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Thu, 19 Sep 2013 14:29:22 -0700 [thread overview]
Message-ID: <20130919212922.GA27501@atomide.com> (raw)
In-Reply-To: <201309192301.58761@pali>
* Pali Rohár <pali.rohar@gmail.com> [130919 14:10]:
> On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [130918 15:02]:
> > > Without max_current data in board file lp5523 driver does
> > > not change current.
> >
> > Hmm is this a regression or are there other reasons to merge
> > this during the -rc cycle?
> >
>
> I think this is regression, drivers/leds/leds-lp55xx-common.c
> code refuse to change led_current sysfs attribute if value is
> higher than max_current specified in board file. And because in
> board file max_current is not specified it is by default zero as
> global variable. So changing led_current is not possible because
> any positive value is more than zero. First I saw this behaviour
> in 3.10, but I forgot to send this patch.
OK thanks, can you please update the patch description with
that so I can merge it for the -rc cycle? Ideally of course
with the breaking commit too.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Thu, 19 Sep 2013 14:29:22 -0700 [thread overview]
Message-ID: <20130919212922.GA27501@atomide.com> (raw)
In-Reply-To: <201309192301.58761@pali>
* Pali Rohár <pali.rohar@gmail.com> [130919 14:10]:
> On Thursday 19 September 2013 00:26:43 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@gmail.com> [130918 15:02]:
> > > Without max_current data in board file lp5523 driver does
> > > not change current.
> >
> > Hmm is this a regression or are there other reasons to merge
> > this during the -rc cycle?
> >
>
> I think this is regression, drivers/leds/leds-lp55xx-common.c
> code refuse to change led_current sysfs attribute if value is
> higher than max_current specified in board file. And because in
> board file max_current is not specified it is by default zero as
> global variable. So changing led_current is not possible because
> any positive value is more than zero. First I saw this behaviour
> in 3.10, but I forgot to send this patch.
OK thanks, can you please update the patch description with
that so I can merge it for the -rc cycle? Ideally of course
with the breaking commit too.
Regards,
Tony
next prev parent reply other threads:[~2013-09-19 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 21:52 [PATCH] RX-51: Add missing max_current to rx51_lp5523_led_config Pali Rohár
2013-09-18 22:26 ` Tony Lindgren
2013-09-18 22:26 ` Tony Lindgren
2013-09-19 21:01 ` Pali Rohár
2013-09-19 21:29 ` Tony Lindgren [this message]
2013-09-19 21:29 ` Tony Lindgren
2013-09-19 22:20 ` Pali Rohár
2013-09-23 12:50 ` [PATCH v2] " Pali Rohár
2013-09-23 13:06 ` joerg Reisenweber
2013-10-08 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919212922.GA27501@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.