From: maxime.ripard@free-electrons.com (maxime.ripard at free-electrons.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).
Date: Mon, 23 Sep 2013 21:34:30 +0300 [thread overview]
Message-ID: <20130923183430.GT2779@lukather> (raw)
In-Reply-To: <CAK3cCByGeAK2H83bP0wy=kC_+kj4Q8cFHPQ1gYUJ=uv4gs-T-A@mail.gmail.com>
Hi,
On Mon, Sep 23, 2013 at 10:43:55PM +0800, cinifr wrote:
> > In which case this kernel patch needs instead to speak the bootloader
> > wakeup protocol instead of speaking to the h/w directly like you've done
> > here, right?
> >
> > Or is it possible for the bootloader to set these things up and then put
> > the CPU back to sleep such that it both retains any settings and is
> > wakable by this patch? This code contains core resets and power control,
> > which makes me suspect not.
>
> And I think secondary cpus remains setting after h/w boot.
> >> > Wouldn't it be better to do all this stuff in the bootloader and
> >> either
> >> > implement PSCI or have the bootloader do the traditional holding pen
> >> and
> >> > mbox address thing?
> Uboot doesnot support PSCI, it use traditional holding pen for sunxi
> platform now.
>
> >> >
> >> I have modified uboot to set cntfrq and cntvoff in all smp cpus,and it
> >> works well. I guess kernel should believe all cpu should be all same
> >> when kernel boot. Bootloader should do it to ensure that.
> >
> > Yes, I think all CPUs must be in the same state at boot.
> >
> > But if you've done all that then what is this patch for?
> >
> > Do you have links to your u-boot patches?
> >
> > Ian.
> Yes, This is my patch for uboot.
> My working uboot code is in https://github.com/linux-sunxi/u-boot-sunxi.git
> Note this is only test patch. I have not commit it formally for uboot.
Please do so. I'd like very much to avoid ending up in a situation where
we would break the mainline kernel for the A20, without any bootloader
we can point the users to to fix the issues.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130923/16791ec5/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "maxime.ripard@free-electrons.com" <maxime.ripard@free-electrons.com>
To: cinifr <cinifr@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>,
"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
"coosty@163.com" <coosty@163.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"pawel.moll@arm.co" <pawel.moll@arm.co>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>
Subject: Re: [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i).
Date: Mon, 23 Sep 2013 21:34:30 +0300 [thread overview]
Message-ID: <20130923183430.GT2779@lukather> (raw)
In-Reply-To: <CAK3cCByGeAK2H83bP0wy=kC_+kj4Q8cFHPQ1gYUJ=uv4gs-T-A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]
Hi,
On Mon, Sep 23, 2013 at 10:43:55PM +0800, cinifr wrote:
> > In which case this kernel patch needs instead to speak the bootloader
> > wakeup protocol instead of speaking to the h/w directly like you've done
> > here, right?
> >
> > Or is it possible for the bootloader to set these things up and then put
> > the CPU back to sleep such that it both retains any settings and is
> > wakable by this patch? This code contains core resets and power control,
> > which makes me suspect not.
>
> And I think secondary cpus remains setting after h/w boot.
> >> > Wouldn't it be better to do all this stuff in the bootloader and
> >> either
> >> > implement PSCI or have the bootloader do the traditional holding pen
> >> and
> >> > mbox address thing?
> Uboot doesnot support PSCI, it use traditional holding pen for sunxi
> platform now.
>
> >> >
> >> I have modified uboot to set cntfrq and cntvoff in all smp cpus,and it
> >> works well. I guess kernel should believe all cpu should be all same
> >> when kernel boot. Bootloader should do it to ensure that.
> >
> > Yes, I think all CPUs must be in the same state at boot.
> >
> > But if you've done all that then what is this patch for?
> >
> > Do you have links to your u-boot patches?
> >
> > Ian.
> Yes, This is my patch for uboot.
> My working uboot code is in https://github.com/linux-sunxi/u-boot-sunxi.git
> Note this is only test patch. I have not commit it formally for uboot.
Please do so. I'd like very much to avoid ending up in a situation where
we would break the mainline kernel for the A20, without any bootloader
we can point the users to to fix the issues.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-23 18:34 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 12:21 [PATCH V3: Add Smp support for Allwinner A20. 0/3] Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-22 13:00 ` Russell King - ARM Linux
2013-09-22 13:00 ` Russell King - ARM Linux
2013-09-22 13:50 ` cinifr
2013-09-22 13:50 ` cinifr
2013-09-22 14:44 ` [linux-sunxi] " Ian Campbell
2013-09-22 14:44 ` Ian Campbell
[not found] ` <CAK3cCBzMXdeeSPC-OpWcHAuef=ocpy5n0=Fc2yBECPnU=2OTXw@mail.gmail.com>
2013-09-23 7:18 ` [PATCH " Ian Campbell
2013-09-23 7:18 ` Ian Campbell
2013-09-23 14:43 ` cinifr
2013-09-23 14:43 ` cinifr
2013-09-23 18:34 ` maxime.ripard at free-electrons.com [this message]
2013-09-23 18:34 ` maxime.ripard
2013-09-26 17:03 ` [linux-sunxi] [PATCH V3: Add Smp support for Allwinner A20. " Ben Dooks
2013-09-23 18:17 ` Maxime Ripard
2013-09-23 18:17 ` Maxime Ripard
2013-09-24 16:22 ` cinifr
2013-09-24 16:22 ` cinifr
2013-09-25 18:44 ` Maxime Ripard
2013-09-25 18:44 ` Maxime Ripard
2013-09-28 13:48 ` cinifr
2013-09-28 13:48 ` cinifr
2013-09-30 16:47 ` Maxime Ripard
2013-09-30 16:47 ` Maxime Ripard
2013-10-02 20:13 ` Russell King - ARM Linux
2013-10-02 20:13 ` Russell King - ARM Linux
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 2/3] Add cpuconfig nodes in dts for smp configure Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-23 17:03 ` Maxime Ripard
2013-09-23 17:03 ` Maxime Ripard
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 3/3] add arch count timer node in dts for Allwinner A20(sunxi 7i) Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-23 17:06 ` Maxime Ripard
2013-09-23 17:06 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2013-09-21 13:05 [PATCH 0/3] Fan Rong
2013-09-21 13:05 ` [PATCH 1/3] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-21 13:05 ` Fan Rong
2013-09-21 13:31 ` Russell King - ARM Linux
2013-09-21 13:31 ` Russell King - ARM Linux
2013-09-21 14:00 ` Maxime Ripard
2013-09-21 14:00 ` Maxime Ripard
2013-09-21 16:49 ` cinifr
2013-09-21 16:49 ` cinifr
2013-09-21 17:15 ` Russell King - ARM Linux
2013-09-21 17:15 ` Russell King - ARM Linux
2013-09-21 22:49 ` Maxime Ripard
2013-09-21 22:49 ` Maxime Ripard
2013-09-23 7:03 ` Uwe Kleine-König
2013-09-23 7:03 ` Uwe Kleine-König
2013-09-23 3:37 ` Guenter Roeck
2013-09-23 3:37 ` Guenter Roeck
2013-09-23 18:19 ` Maxime Ripard
2013-09-23 18:19 ` Maxime Ripard
2013-09-23 18:56 ` Guenter Roeck
2013-09-23 18:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923183430.GT2779@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.