From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i).
Date: Wed, 2 Oct 2013 21:13:50 +0100 [thread overview]
Message-ID: <20131002201350.GS12758@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAK3cCBwOpkk5ObeEm+by=RS6jSptPdGZM+fvpgGZpX9TPij5gg@mail.gmail.com>
On Sat, Sep 28, 2013 at 09:48:11PM +0800, cinifr wrote:
> Hi Maxime,
> I have test it, but I found it does not work. If using
> smp_prepare_cpus, the kernenl cannot find the secondary cpus because
> that smp_prepare_cpus semms not be excuted before kernel is booting
> secondary cpus. So I have to use early_initcall.
Please don't do this - you're hacking around what could be a real problem.
Instead, please investigate what is going on and why your smp_prepare_cpus()
function never gets called.
Quite honestly, whenever I see crap like the above, it just makes me want
to tell the ARM-SoC people to forever /dev/null your emails because you
really don't know how to deal with the Linux kernel.
Always *fully* investigate a problem that you find to determine whether
it's your problem or some as yet undiscovered kernel bug. Never hack
around it and then submit a patch suggesting that your workaround is
something that "has" to be done.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: cinifr <cinifr@gmail.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
coosty@163.com, Daniel Lezcano <daniel.lezcano@linaro.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"pawel.moll@arm.co" <pawel.moll@arm.co>,
Rob Herring <rob.herring@calxeda.com>,
"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i).
Date: Wed, 2 Oct 2013 21:13:50 +0100 [thread overview]
Message-ID: <20131002201350.GS12758@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAK3cCBwOpkk5ObeEm+by=RS6jSptPdGZM+fvpgGZpX9TPij5gg@mail.gmail.com>
On Sat, Sep 28, 2013 at 09:48:11PM +0800, cinifr wrote:
> Hi Maxime,
> I have test it, but I found it does not work. If using
> smp_prepare_cpus, the kernenl cannot find the secondary cpus because
> that smp_prepare_cpus semms not be excuted before kernel is booting
> secondary cpus. So I have to use early_initcall.
Please don't do this - you're hacking around what could be a real problem.
Instead, please investigate what is going on and why your smp_prepare_cpus()
function never gets called.
Quite honestly, whenever I see crap like the above, it just makes me want
to tell the ARM-SoC people to forever /dev/null your emails because you
really don't know how to deal with the Linux kernel.
Always *fully* investigate a problem that you find to determine whether
it's your problem or some as yet undiscovered kernel bug. Never hack
around it and then submit a patch suggesting that your workaround is
something that "has" to be done.
next prev parent reply other threads:[~2013-10-02 20:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 12:21 [PATCH V3: Add Smp support for Allwinner A20. 0/3] Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 1/3] Add smp support for Allwinner A20(sunxi 7i) Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-22 13:00 ` Russell King - ARM Linux
2013-09-22 13:00 ` Russell King - ARM Linux
2013-09-22 13:50 ` cinifr
2013-09-22 13:50 ` cinifr
2013-09-22 14:44 ` [linux-sunxi] " Ian Campbell
2013-09-22 14:44 ` Ian Campbell
[not found] ` <CAK3cCBzMXdeeSPC-OpWcHAuef=ocpy5n0=Fc2yBECPnU=2OTXw@mail.gmail.com>
2013-09-23 7:18 ` [PATCH " Ian Campbell
2013-09-23 7:18 ` Ian Campbell
2013-09-23 14:43 ` cinifr
2013-09-23 14:43 ` cinifr
2013-09-23 18:34 ` maxime.ripard at free-electrons.com
2013-09-23 18:34 ` maxime.ripard
2013-09-26 17:03 ` [linux-sunxi] [PATCH V3: Add Smp support for Allwinner A20. " Ben Dooks
2013-09-23 18:17 ` Maxime Ripard
2013-09-23 18:17 ` Maxime Ripard
2013-09-24 16:22 ` cinifr
2013-09-24 16:22 ` cinifr
2013-09-25 18:44 ` Maxime Ripard
2013-09-25 18:44 ` Maxime Ripard
2013-09-28 13:48 ` cinifr
2013-09-28 13:48 ` cinifr
2013-09-30 16:47 ` Maxime Ripard
2013-09-30 16:47 ` Maxime Ripard
2013-10-02 20:13 ` Russell King - ARM Linux [this message]
2013-10-02 20:13 ` Russell King - ARM Linux
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 2/3] Add cpuconfig nodes in dts for smp configure Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-23 17:03 ` Maxime Ripard
2013-09-23 17:03 ` Maxime Ripard
2013-09-22 12:21 ` [PATCH V3: Add Smp support for Allwinner A20. 3/3] add arch count timer node in dts for Allwinner A20(sunxi 7i) Fan Rong
2013-09-22 12:21 ` Fan Rong
2013-09-23 17:06 ` Maxime Ripard
2013-09-23 17:06 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002201350.GS12758@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.