From: Denys Dmytriyenko <denys@ti.com>
To: "Franklin S. Cooper Jr" <fcooper@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory
Date: Mon, 23 Sep 2013 20:41:43 -0400 [thread overview]
Message-ID: <20130924004143.GA4390@edge> (raw)
In-Reply-To: <1379985594-25515-1-git-send-email-fcooper@ti.com>
Heh, just sent out my updated patch and noticed you had one as well... And
they are so similar! I'm just wondering why you spent time on it, when I said
I'll fix it?
--
Denys
On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote:
> * Latest kernel sources included symbolic links that were broken and caused the
> tar command to fail.
> * In certain circumstances broken symbolic links are valid and should be
> packaged up.
> * However, any patch located in the "patches" directory should be dereference
> * since the original file is located in the recipe's WORKDIR.
> * Therefore, the sym link will be broken when accessed on a different computer.
> * By using the dereference option with the cp command the patches directory can
> be dereferenced.
>
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> meta-arago-distro/classes/sourceipk.bbclass | 12 +++++++++++-
> 1 files changed, 11 insertions(+), 1 deletions(-)
>
> diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
> index 1ea0577..3086670 100644
> --- a/meta-arago-distro/classes/sourceipk.bbclass
> +++ b/meta-arago-distro/classes/sourceipk.bbclass
> @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() {
> cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/
> fi
>
> + # Dereference symbolic links to patches that are stored in patches directory
> + if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ]
> + then
> +
> + mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> + cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> + rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> + fi
> +
> +
> #Write the data tarball
> - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
> + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
>
> # Create the debian-binary file
> echo "2.0" > $srcipk_dir/debian-binary
> --
> 1.7.0.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
next prev parent reply other threads:[~2013-09-24 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 1:19 [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory Franklin S. Cooper Jr
2013-09-24 0:41 ` Denys Dmytriyenko [this message]
2013-09-24 0:49 ` Cooper Jr., Franklin
2013-09-24 0:56 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924004143.GA4390@edge \
--to=denys@ti.com \
--cc=fcooper@ti.com \
--cc=meta-arago@arago-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.