Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory

Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory

[Denys Dmytriyenko]

Heh, just sent out my updated patch and noticed you had one as well... And 
they are so similar! I'm just wondering why you spent time on it, when I said 
I'll fix it?

-- 
Denys


On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote:
> * Latest kernel sources included symbolic links that were broken and caused the
>   tar command to fail.
> * In certain circumstances broken symbolic links are valid and should be
>   packaged up.
> * However, any patch located in the "patches" directory should be dereference
> * since the original file is located in the recipe's WORKDIR.
> * Therefore, the sym link will be broken when accessed on a different computer.
> * By using the dereference option with the cp command the patches directory can
>   be dereferenced.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
>  meta-arago-distro/classes/sourceipk.bbclass |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
> index 1ea0577..3086670 100644
> --- a/meta-arago-distro/classes/sourceipk.bbclass
> +++ b/meta-arago-distro/classes/sourceipk.bbclass
> @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() {
>              cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/
>          fi
>  
> +        # Dereference symbolic links to patches that are stored in patches directory
> +        if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ]
> +        then
> +
> +            mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> +            cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> +            rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> +        fi
> +
> +
>          #Write the data tarball
> -        tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
> +        tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
>  
>          # Create the debian-binary file
>          echo "2.0" > $srcipk_dir/debian-binary
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory

[Cooper Jr., Franklin]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, September 23, 2013 7:42 PM
> To: Cooper Jr., Franklin
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] sourceipk.bbclass: Dereference sym links
> located in patches directory
> 
> Heh, just sent out my updated patch and noticed you had one as well... And
> they are so similar! I'm just wondering why you spent time on it, when I said I'll
> fix it?
[Franklin]  Lol yeah. Must of overlooked the part where you said you were going to fix it and I needed it for my SDK build I want to start tomorrow morning. 
> 
> --
> Denys
> 
> 
> On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote:
> > * Latest kernel sources included symbolic links that were broken and caused
> the
> >   tar command to fail.
> > * In certain circumstances broken symbolic links are valid and should be
> >   packaged up.
> > * However, any patch located in the "patches" directory should be
> dereference
> > * since the original file is located in the recipe's WORKDIR.
> > * Therefore, the sym link will be broken when accessed on a different
> computer.
> > * By using the dereference option with the cp command the patches directory
> can
> >   be dereferenced.
> >
> > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > ---
> >  meta-arago-distro/classes/sourceipk.bbclass |   12 +++++++++++-
> >  1 files changed, 11 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-
> distro/classes/sourceipk.bbclass
> > index 1ea0577..3086670 100644
> > --- a/meta-arago-distro/classes/sourceipk.bbclass
> > +++ b/meta-arago-distro/classes/sourceipk.bbclass
> > @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() {
> >              cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/
> >          fi
> >
> > +        # Dereference symbolic links to patches that are stored in patches
> directory
> > +        if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ]
> > +        then
> > +
> > +            mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> > +            cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> > +            rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> > +        fi
> > +
> > +
> >          #Write the data tarball
> > -        tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
> > +        tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
> >
> >          # Create the debian-binary file
> >          echo "2.0" > $srcipk_dir/debian-binary
> > --
> > 1.7.0.4
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory

[Denys Dmytriyenko]

On Mon, Sep 23, 2013 at 08:49:10PM -0400, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Monday, September 23, 2013 7:42 PM
> > To: Cooper Jr., Franklin
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] sourceipk.bbclass: Dereference sym links
> > located in patches directory
> > 
> > Heh, just sent out my updated patch and noticed you had one as well... And
> > they are so similar! I'm just wondering why you spent time on it, when I said I'll
> > fix it?

> [Franklin] Lol yeah. Must of overlooked the part where you said you were 
> going to fix it and I needed it for my SDK build I want to start tomorrow 
> morning.

Ah, I didn't know you needed it sooner - I was working on it and testing it 
in-between my main work today on meta-qt5 and switching other platforms to 
3.12 kernel. That's why it took me a while to get it out...


> > On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote:
> > > * Latest kernel sources included symbolic links that were broken and caused
> > the
> > >   tar command to fail.
> > > * In certain circumstances broken symbolic links are valid and should be
> > >   packaged up.
> > > * However, any patch located in the "patches" directory should be
> > dereference
> > > * since the original file is located in the recipe's WORKDIR.
> > > * Therefore, the sym link will be broken when accessed on a different
> > computer.
> > > * By using the dereference option with the cp command the patches directory
> > can
> > >   be dereferenced.
> > >
> > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > ---
> > >  meta-arago-distro/classes/sourceipk.bbclass |   12 +++++++++++-
> > >  1 files changed, 11 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-
> > distro/classes/sourceipk.bbclass
> > > index 1ea0577..3086670 100644
> > > --- a/meta-arago-distro/classes/sourceipk.bbclass
> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass
> > > @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() {
> > >              cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/
> > >          fi
> > >
> > > +        # Dereference symbolic links to patches that are stored in patches
> > directory
> > > +        if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ]
> > > +        then
> > > +
> > > +            mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> > $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> > > +            cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> > $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
> > > +            rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
> > > +        fi
> > > +
> > > +
> > >          #Write the data tarball
> > > -        tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
> > > +        tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
> > >
> > >          # Create the debian-binary file
> > >          echo "2.0" > $srcipk_dir/debian-binary
> > > --
> > > 1.7.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

[PATCH] sourceipk.bbclass: Dereference sym links located in patches directory

[Franklin S. Cooper Jr]

* Latest kernel sources included symbolic links that were broken and caused the
  tar command to fail.
* In certain circumstances broken symbolic links are valid and should be
  packaged up.
* However, any patch located in the "patches" directory should be dereference
* since the original file is located in the recipe's WORKDIR.
* Therefore, the sym link will be broken when accessed on a different computer.
* By using the dereference option with the cp command the patches directory can
  be dereferenced.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 meta-arago-distro/classes/sourceipk.bbclass |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
index 1ea0577..3086670 100644
--- a/meta-arago-distro/classes/sourceipk.bbclass
+++ b/meta-arago-distro/classes/sourceipk.bbclass
@@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() {
             cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/
         fi
 
+        # Dereference symbolic links to patches that are stored in patches directory
+        if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ]
+        then
+
+            mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
+            cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak $tmp_dir/${SRCIPK_INSTALL_DIR}/patches
+            rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak
+        fi
+
+
         #Write the data tarball
-        tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
+        tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
 
         # Create the debian-binary file
         echo "2.0" > $srcipk_dir/debian-binary
-- 
1.7.0.4