From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Shuah Khan <shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org,
fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
udknight-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace
Date: Tue, 24 Sep 2013 12:48:57 +0200 [thread overview]
Message-ID: <20130924104855.GB4532@8bytes.org> (raw)
In-Reply-To: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote:
> +DEFINE_EVENT(iommu_fault, report_fault,
> +
> + TP_PROTO(struct device *dev, unsigned long iova, int flags),
> +
> + TP_ARGS(dev, iova, flags)
> +);
I am not entirely happy with the naming. It is better to name the class
iommu_error and the page-fault event io_page_fault. This makes it more
clear what kind of fault it is.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: alex.williamson@redhat.com, Varun.Sethi@freescale.com,
udknight@gmail.com, aik@ozlabs.ru, rostedt@goodmis.org,
fweisbec@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
shuahkhan@gmail.com
Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace
Date: Tue, 24 Sep 2013 12:48:57 +0200 [thread overview]
Message-ID: <20130924104855.GB4532@8bytes.org> (raw)
In-Reply-To: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh@samsung.com>
On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote:
> +DEFINE_EVENT(iommu_fault, report_fault,
> +
> + TP_PROTO(struct device *dev, unsigned long iova, int flags),
> +
> + TP_ARGS(dev, iova, flags)
> +);
I am not entirely happy with the naming. It is better to name the class
iommu_error and the page-fault event io_page_fault. This makes it more
clear what kind of fault it is.
Joerg
next prev parent reply other threads:[~2013-09-24 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 17:20 [PATCH 0/2] iommu: Add iommu_fault class event to iommu trace Shuah Khan
2013-08-16 17:20 ` Shuah Khan
[not found] ` <cover.1376672275.git.shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-08-16 17:20 ` [PATCH 1/2] " Shuah Khan
2013-08-16 17:20 ` Shuah Khan
[not found] ` <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-24 10:48 ` Joerg Roedel [this message]
2013-09-24 10:48 ` Joerg Roedel
[not found] ` <20130924104855.GB4532-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-09-24 12:39 ` Shuah Khan
2013-09-24 12:39 ` Shuah Khan
2013-08-16 17:20 ` [PATCH 2/2] iommu: Change iommu driver to call report_fault trace event Shuah Khan
2013-08-16 17:20 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924104855.GB4532@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=udknight-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.