All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
	huawei.libin@huawei.com, wangyijing@huawei.com,
	fenghua.yu@intel.com, tglx@linutronix.de, guohanjun@huawei.com,
	paul.gortmaker@windriver.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly
Date: Fri, 27 Sep 2013 15:33:02 +0200	[thread overview]
Message-ID: <20130927133302.GA12013@gmail.com> (raw)
In-Reply-To: <20130927124850.GB4422@pd.tnic>


* Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Sep 27, 2013 at 08:51:15AM +0200, Ingo Molnar wrote:
> > That message was cool and interesting back in the days when we wrote
> > lockdep ('hey, look ma, it really works!!'), but there hasn't been
> > any breakage in that area for a long time and it definitely does not
> > deserve one line of log spam per CPU! Especially if it messes up such
> > a nice CPU bootup table.
> 
> Right. The comment in alternatives_enable_smp() talks about older
> binutils and could be a useful info if we encounter the issue again. Should I
> keep it or are we talking really old, i.e.
> 
> obsolete-we-will-never-use-them-anywhere-and-if-someone-does-we-dont-care
> 
> binutils?

See this commit from ~5 years ago:

  17abecfe651c x86: fix up alternatives with lockdep enabled

I was thinking about removing the message back then. Nobody ever 
complained: code patching is so fundamental to a properly functioning 
Linux kernel that broken binutils would stick out like a sore thumb - and 
not just related to lockdep.

So lets remove it.

Thanks,

	Ingo

      reply	other threads:[~2013-09-27 13:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 10:57 [PATCH] x86, smpboot: fix announce_cpu() to print the last OK Libin
2013-09-05 17:52 ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly tip-bot for Libin
2013-09-25 10:07   ` Borislav Petkov
2013-09-25 18:29     ` Ingo Molnar
2013-09-26 23:15       ` Borislav Petkov
2013-09-27  6:51         ` Ingo Molnar
2013-09-27 10:38           ` Borislav Petkov
2013-09-27 14:32             ` Borislav Petkov
2013-09-27 14:34               ` [PATCH 1/2] x86, alternatives: Drop ancient lockdep fixup message Borislav Petkov
2013-09-28  8:28                 ` [tip:core/locking] lockdep, x86/alternatives: " tip-bot for Borislav Petkov
2013-09-27 14:35               ` [PATCH 2/2] x86: Cleanup boot CPUs table Borislav Petkov
2013-09-28  8:25                 ` Ingo Molnar
2013-09-28 10:23                   ` Borislav Petkov
2013-09-28 13:44                     ` Ingo Molnar
2013-09-28 17:47                       ` [PATCH] x86, boot: Further compress CPUs bootup message Borislav Petkov
2013-09-28 17:54                         ` Ingo Molnar
2013-09-28 18:04                           ` [PATCH -v1.1] " Borislav Petkov
2013-09-28 18:12                             ` Ingo Molnar
2013-09-28 19:15                               ` Borislav Petkov
2013-09-28 19:25                                 ` Ingo Molnar
2013-09-28 19:36                                   ` [PATCH -v1.3] " Borislav Petkov
2013-09-28 19:42                                   ` [PATCH -v1.1] " H. Peter Anvin
2013-09-28 19:49                                     ` Borislav Petkov
2013-09-28 19:54                                       ` Borislav Petkov
2013-09-28 19:58                                         ` Ingo Molnar
2013-09-28 20:08                                           ` Borislav Petkov
2013-09-28 23:13                                             ` H. Peter Anvin
2013-09-29  9:14                                               ` Borislav Petkov
2013-09-29 15:17                                                 ` [PATCH -v1.4] " Borislav Petkov
2013-09-29 15:44                                                 ` [PATCH -v1.1] " H. Peter Anvin
2013-09-30  6:28                                                   ` Ingo Molnar
2013-09-30  9:56                                                     ` Borislav Petkov
2013-10-01  8:53                                                       ` Ingo Molnar
2013-10-01  9:10                                                       ` [tip:x86/boot] x86/boot: " tip-bot for Borislav Petkov
2013-10-02 11:52                                                         ` Peter Zijlstra
2013-10-02 12:18                                                           ` Ingo Molnar
2013-10-02 12:20                                                           ` Peter Zijlstra
2013-10-02 13:55                                                             ` Borislav Petkov
2013-09-28 19:58                                     ` [PATCH -v1.1] x86, boot: " Ingo Molnar
2013-09-28 20:10                                       ` Borislav Petkov
2013-09-29  5:10                                         ` H. Peter Anvin
2013-09-29  2:55                   ` [PATCH 2/2] x86: Cleanup boot CPUs table Mike Galbraith
2013-09-28  8:28                 ` [tip:x86/boot] x86: Improve the printout of the SMP bootup CPU table tip-bot for Borislav Petkov
2013-09-29  4:25                   ` Yinghai Lu
2013-09-27 12:48           ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly Borislav Petkov
2013-09-27 13:33             ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927133302.GA12013@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.