All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Franklin S. Cooper Jr" <fcooper@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable
Date: Mon, 30 Sep 2013 21:40:56 -0400	[thread overview]
Message-ID: <20131001014056.GA26572@edge> (raw)
In-Reply-To: <1380591438-30769-1-git-send-email-fcooper@ti.com>

Ack.

On Mon, Sep 30, 2013 at 08:37:18PM -0500, Franklin S. Cooper Jr wrote:
> * Within environment-setup the TARGET_SYS variable is exported but used
>   improperly.
> * The value for --target and --host isn't the TARGET_SYS value within the
>   environment-setup file but rather the OE variable TARGET_SYS.
> * Cross compiling autotools based applications using environment-setup
>   results in host and machine not recognized "configure" errors.
> * Looking at toolchain-scripts.bbclass it looks like that variable has been
>   removed from environment-setup so mimic that change.
> * Introduce new REAL_MULTIMACH_TARGET_SYS environment variable since the value
>   is reused in several places within environment-setup.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> Version 2 changes:
> Replace TARGET_SYS environment variable with REAL_MULTIMACH_TARGET_SYS
> environment variable.
> 
>  .../recipes-core/meta/meta-toolchain-arago.bb      |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index a8da4dc..7d01980 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -30,17 +30,17 @@ toolchain_create_sdk_env_script () {
>  	echo '    export SDK_PATH' >> $script
>  	echo 'fi' >> $script
>  	echo 'export SDK_SYS=${SDK_SYS}' >> $script
> -	echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
> +	echo 'export REAL_MULTIMACH_TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script$
>  	echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script
>  	echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script
>  	echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script
> -	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script
> +	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$REAL_MULTIMACH_TARGET_SYS' >> $script
>  	echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script
>  	echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script
>  	echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script
>  	echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script
>  	echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> -	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script
> +	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$REAL_MULTIMACH_TARGET_SYS' >> $script
>  	printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script
>  	printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script
>  	printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script
> @@ -52,7 +52,7 @@ toolchain_create_sdk_env_script () {
>  	printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script
>  	printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script
>  	printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script
> -	echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
> +	echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
>  	echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script
>  	echo 'export CFLAGS="$CPPFLAGS"' >> $script
>  	echo 'export CXXFLAGS="$CPPFLAGS"' >> $script
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


      reply	other threads:[~2013-10-01  1:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  1:37 [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
2013-10-01  1:40 ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001014056.GA26572@edge \
    --to=denys@ti.com \
    --cc=fcooper@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.