All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable
@ 2013-10-01  1:37 Franklin S. Cooper Jr
  2013-10-01  1:40 ` Denys Dmytriyenko
  0 siblings, 1 reply; 2+ messages in thread
From: Franklin S. Cooper Jr @ 2013-10-01  1:37 UTC (permalink / raw)
  To: meta-arago; +Cc: Franklin S. Cooper Jr

* Within environment-setup the TARGET_SYS variable is exported but used
  improperly.
* The value for --target and --host isn't the TARGET_SYS value within the
  environment-setup file but rather the OE variable TARGET_SYS.
* Cross compiling autotools based applications using environment-setup
  results in host and machine not recognized "configure" errors.
* Looking at toolchain-scripts.bbclass it looks like that variable has been
  removed from environment-setup so mimic that change.
* Introduce new REAL_MULTIMACH_TARGET_SYS environment variable since the value
  is reused in several places within environment-setup.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
Version 2 changes:
Replace TARGET_SYS environment variable with REAL_MULTIMACH_TARGET_SYS
environment variable.

 .../recipes-core/meta/meta-toolchain-arago.bb      |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
index a8da4dc..7d01980 100644
--- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
+++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
@@ -30,17 +30,17 @@ toolchain_create_sdk_env_script () {
 	echo '    export SDK_PATH' >> $script
 	echo 'fi' >> $script
 	echo 'export SDK_SYS=${SDK_SYS}' >> $script
-	echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
+	echo 'export REAL_MULTIMACH_TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script$
 	echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script
 	echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script
 	echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script
-	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script
+	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$REAL_MULTIMACH_TARGET_SYS' >> $script
 	echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script
 	echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script
 	echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script
 	echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script
 	echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
-	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script
+	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$REAL_MULTIMACH_TARGET_SYS' >> $script
 	printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script
 	printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script
 	printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script
@@ -52,7 +52,7 @@ toolchain_create_sdk_env_script () {
 	printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script
 	printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script
 	printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script
-	echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
+	echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
 	echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script
 	echo 'export CFLAGS="$CPPFLAGS"' >> $script
 	echo 'export CXXFLAGS="$CPPFLAGS"' >> $script
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable
  2013-10-01  1:37 [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
@ 2013-10-01  1:40 ` Denys Dmytriyenko
  0 siblings, 0 replies; 2+ messages in thread
From: Denys Dmytriyenko @ 2013-10-01  1:40 UTC (permalink / raw)
  To: Franklin S. Cooper Jr; +Cc: meta-arago

Ack.

On Mon, Sep 30, 2013 at 08:37:18PM -0500, Franklin S. Cooper Jr wrote:
> * Within environment-setup the TARGET_SYS variable is exported but used
>   improperly.
> * The value for --target and --host isn't the TARGET_SYS value within the
>   environment-setup file but rather the OE variable TARGET_SYS.
> * Cross compiling autotools based applications using environment-setup
>   results in host and machine not recognized "configure" errors.
> * Looking at toolchain-scripts.bbclass it looks like that variable has been
>   removed from environment-setup so mimic that change.
> * Introduce new REAL_MULTIMACH_TARGET_SYS environment variable since the value
>   is reused in several places within environment-setup.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> Version 2 changes:
> Replace TARGET_SYS environment variable with REAL_MULTIMACH_TARGET_SYS
> environment variable.
> 
>  .../recipes-core/meta/meta-toolchain-arago.bb      |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> index a8da4dc..7d01980 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb
> @@ -30,17 +30,17 @@ toolchain_create_sdk_env_script () {
>  	echo '    export SDK_PATH' >> $script
>  	echo 'fi' >> $script
>  	echo 'export SDK_SYS=${SDK_SYS}' >> $script
> -	echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script
> +	echo 'export REAL_MULTIMACH_TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script$
>  	echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script
>  	echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script
>  	echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script
> -	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script
> +	echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$REAL_MULTIMACH_TARGET_SYS' >> $script
>  	echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script
>  	echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script
>  	echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script
>  	echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script
>  	echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script
> -	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script
> +	echo 'export CONFIG_SITE=$SDK_PATH/site-config-$REAL_MULTIMACH_TARGET_SYS' >> $script
>  	printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script
>  	printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script
>  	printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script
> @@ -52,7 +52,7 @@ toolchain_create_sdk_env_script () {
>  	printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script
>  	printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script
>  	printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script
> -	echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
> +	echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script
>  	echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script
>  	echo 'export CFLAGS="$CPPFLAGS"' >> $script
>  	echo 'export CXXFLAGS="$CPPFLAGS"' >> $script
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-01  1:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01  1:37 [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable Franklin S. Cooper Jr
2013-10-01  1:40 ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.