All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: rjohnston@sgi.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore
Date: Tue, 8 Oct 2013 12:08:22 +1100	[thread overview]
Message-ID: <20131008010822.GW4446@dastard> (raw)
In-Reply-To: <20131007193912.256265551@sgi.com>

On Mon, Oct 07, 2013 at 02:38:35PM -0500, rjohnston@sgi.com wrote:
> +# create files for test 1, a large file so the sparse file
> +# is in the next stream.
> +_create_test1_files()
> +{
> +
> +	dd if=/dev/zero of=$SCRATCH_MNT/$DUMPDIR/10MB bs=1MB \
> +		count=10 2>&1 >> $seqres.full | _filter_dd
> +	truncate --size=1t $SCRATCH_MNT/$DUMPDIR/sparse0 2>&1 \
> +		>> $seqres.full

I just noticed that 'truncate' is used here - we don't use that
anywhere else in xfstests, so either you need test for it in
common/config and use $TRUNCATE_PROG, or do like every other test
does and use:

	$XFS_IO_PROG -c "truncate 1t" $SCRATCH_MNT/$DUMPDIR/sparse0 

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-10-08  1:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 16:30 [PATCH] xfsrestore: fix multi stream support Rich Johnston
2013-10-01 20:47 ` Eric Sandeen
2013-10-01 21:39   ` Rich Johnston
2013-10-01 22:02     ` Rich Johnston
2013-10-02  3:57       ` Eric Sandeen
2013-10-02  4:17         ` Eric Sandeen
2013-10-02  4:26       ` Eric Sandeen
2013-10-02 18:41 ` Eric Sandeen
2013-10-02 20:03   ` Rich Johnston
2013-10-02 20:13     ` Eric Sandeen
2013-10-03 13:40       ` Rich Johnston
     [not found] ` <20131003212114.493910914@sgi.com>
2013-10-03 22:11   ` [PATCH] xfsdump: handle large, wholly-sparse files Eric Sandeen
2013-10-03 23:11 ` [PATCH V2] " Rich Johnston
2013-10-03 23:16   ` Eric Sandeen
2013-10-07 19:38 ` [PATCH] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore rjohnston
2013-10-07 20:32   ` Eric Sandeen
2013-10-07 20:54     ` Rich Johnston
2013-10-07 21:00       ` Eric Sandeen
2013-10-08  0:53   ` Dave Chinner
2013-10-08  0:57     ` Eric Sandeen
2013-10-08  0:58       ` Eric Sandeen
2013-10-08 14:21       ` Rich Johnston
2013-10-08 19:27         ` Dave Chinner
2013-10-08 19:57           ` Eric Sandeen
2013-10-08  1:08   ` Dave Chinner [this message]
2013-10-08 14:22     ` Rich Johnston
2013-10-08 14:43 ` [PATCH V2] xfstests XFS: verify extended attributes after multi-stream xfsdump/xfsrestore are not lost rjohnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131008010822.GW4446@dastard \
    --to=david@fromorbit.com \
    --cc=rjohnston@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.