From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, arnd@arndb.de, Pawel.Moll@arm.com,
dedekind1@gmail.com, ijc+devicetree@hellion.org.uk,
avinashphilipk@gmail.com, robherring2@gmail.com,
Pekon Gupta <pekon@ti.com>,
bcousson@baylibre.com, swarren@wwwdotorg.org, olof@lixom.net,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH v8 2/6] ARM: OMAP2+: cleaned-up DT support of various ECC schemes
Date: Fri, 11 Oct 2013 11:32:34 -0700 [thread overview]
Message-ID: <20131011183234.GX29913@atomide.com> (raw)
In-Reply-To: <20131011155527.GP25706@radagast>
* Felipe Balbi <balbi@ti.com> [131011 09:03]:
> On Fri, Oct 11, 2013 at 07:06:39PM +0530, Pekon Gupta wrote:
> > OMAP NAND driver support multiple ECC scheme, which can used in following
> > different flavours, depending on in-build Hardware engines supported by SoC.
> >
> > +---------------------------------------+---------------+---------------+
> > | ECC scheme |ECC calculation|Error detection|
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_HAM1_CODE_HW |H/W (GPMC) |S/W |
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W |
> > |(requires CONFIG_MTD_NAND_ECC_BCH) | | |
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_BCH8_CODE_HW |H/W (GPMC) |H/W (ELM) |
> > |(requires CONFIG_MTD_NAND_OMAP_BCH && | | |
> > | ti,elm-id in DT) | | |
> > +---------------------------------------+---------------+---------------+
> > To optimize footprint of omap2-nand driver, selection of some ECC schemes
> > also require enabling following Kconfigs, in addition to setting appropriate
> > DT bindings
> > - Kconfig:CONFIG_MTD_NAND_ECC_BCH error detection done in software
> > - Kconfig:CONFIG_MTD_NAND_OMAP_BCH error detection done by h/w engine
> >
> > DT binding updates in this patch are:
> > - ti,elm-id: replaces elm_id
> > - ti,nand-ecc-opts: supported values ham1, bch4, and bch8
> > selection of h/w or s/w implementation depends on ti,elm-id
> >
> > Signed-off-by: Pekon Gupta <pekon@ti.com>
>
> since this maintains backwards compatibility, I think it should be
> alright to apply
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
This patch looks safe to queue via the MTD tree for the arch/arm/*omap*
parts in this patch:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Pekon Gupta <pekon@ti.com>,
mark.rutland@arm.com, robherring2@gmail.com, olof@lixom.net,
computersforpeace@gmail.com, dedekind1@gmail.com,
Pawel.Moll@arm.com, ijc+devicetree@hellion.org.uk,
swarren@wwwdotorg.org, dwmw2@infradead.org, arnd@arndb.de,
bcousson@baylibre.com, avinashphilipk@gmail.com,
linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v8 2/6] ARM: OMAP2+: cleaned-up DT support of various ECC schemes
Date: Fri, 11 Oct 2013 11:32:34 -0700 [thread overview]
Message-ID: <20131011183234.GX29913@atomide.com> (raw)
In-Reply-To: <20131011155527.GP25706@radagast>
* Felipe Balbi <balbi@ti.com> [131011 09:03]:
> On Fri, Oct 11, 2013 at 07:06:39PM +0530, Pekon Gupta wrote:
> > OMAP NAND driver support multiple ECC scheme, which can used in following
> > different flavours, depending on in-build Hardware engines supported by SoC.
> >
> > +---------------------------------------+---------------+---------------+
> > | ECC scheme |ECC calculation|Error detection|
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_HAM1_CODE_HW |H/W (GPMC) |S/W |
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_BCH8_CODE_HW_DETECTION_SW |H/W (GPMC) |S/W |
> > |(requires CONFIG_MTD_NAND_ECC_BCH) | | |
> > +---------------------------------------+---------------+---------------+
> > |OMAP_ECC_BCH8_CODE_HW |H/W (GPMC) |H/W (ELM) |
> > |(requires CONFIG_MTD_NAND_OMAP_BCH && | | |
> > | ti,elm-id in DT) | | |
> > +---------------------------------------+---------------+---------------+
> > To optimize footprint of omap2-nand driver, selection of some ECC schemes
> > also require enabling following Kconfigs, in addition to setting appropriate
> > DT bindings
> > - Kconfig:CONFIG_MTD_NAND_ECC_BCH error detection done in software
> > - Kconfig:CONFIG_MTD_NAND_OMAP_BCH error detection done by h/w engine
> >
> > DT binding updates in this patch are:
> > - ti,elm-id: replaces elm_id
> > - ti,nand-ecc-opts: supported values ham1, bch4, and bch8
> > selection of h/w or s/w implementation depends on ti,elm-id
> >
> > Signed-off-by: Pekon Gupta <pekon@ti.com>
>
> since this maintains backwards compatibility, I think it should be
> alright to apply
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
This patch looks safe to queue via the MTD tree for the arch/arm/*omap*
parts in this patch:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-10-11 18:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 13:36 [PATCH v8 0/6] mtd:nand:omap2: clean-up of supported ECC schemes Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 13:36 ` [PATCH v8 1/6] mtd: nand: omap: combine different flavours of 1-bit hamming ecc schemes Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 18:33 ` Tony Lindgren
2013-10-11 18:33 ` Tony Lindgren
2013-10-11 13:36 ` [PATCH v8 2/6] ARM: OMAP2+: cleaned-up DT support of various ECC schemes Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 18:32 ` Tony Lindgren [this message]
2013-10-11 18:32 ` Tony Lindgren
2013-10-11 13:36 ` [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 19:28 ` Brian Norris
2013-10-11 19:28 ` Brian Norris
2013-10-12 23:58 ` Gupta, Pekon
2013-10-12 23:58 ` Gupta, Pekon
2013-10-13 1:40 ` Brian Norris
2013-10-13 1:40 ` Brian Norris
2013-10-11 13:36 ` [PATCH v8 4/6] mtd:nand:omap2: updated support for BCH4 ECC scheme Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 15:55 ` Felipe Balbi
2013-10-11 20:28 ` Brian Norris
2013-10-11 20:28 ` Brian Norris
2013-10-11 13:36 ` [PATCH v8 5/6] ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:56 ` Felipe Balbi
2013-10-11 15:56 ` Felipe Balbi
2013-10-11 13:36 ` [PATCH v8 6/6] mtd: nand: omap: updated devm_xx for all resource allocation and free calls Pekon Gupta
2013-10-11 13:36 ` Pekon Gupta
2013-10-11 15:56 ` Felipe Balbi
2013-10-11 15:56 ` Felipe Balbi
2013-10-11 18:15 ` Brian Norris
2013-10-11 18:15 ` Brian Norris
2013-10-11 18:28 ` Tony Lindgren
2013-10-11 18:28 ` Tony Lindgren
2013-10-11 19:27 ` Brian Norris
2013-10-11 19:27 ` Brian Norris
2013-10-11 21:46 ` Tony Lindgren
2013-10-11 21:46 ` Tony Lindgren
2013-10-11 22:14 ` Brian Norris
2013-10-11 22:14 ` Brian Norris
2013-10-11 21:09 ` [PATCH v8 0/6] mtd:nand:omap2: clean-up of supported ECC schemes Brian Norris
2013-10-11 21:09 ` Brian Norris
2013-10-12 22:26 ` Gupta, Pekon
2013-10-12 22:26 ` Gupta, Pekon
2013-10-13 1:40 ` Brian Norris
2013-10-13 1:40 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011183234.GX29913@atomide.com \
--to=tony@atomide.com \
--cc=Pawel.Moll@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=avinashphilipk@gmail.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pekon@ti.com \
--cc=robherring2@gmail.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.