From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready
Date: Thu, 17 Oct 2013 08:07:10 +0300 [thread overview]
Message-ID: <20131017050710.GA12141@redhat.com> (raw)
In-Reply-To: <8738o0aj9u.fsf@rustcorp.com.au>
On Thu, Oct 17, 2013 at 09:57:41AM +1030, Rusty Russell wrote:
> Jason Wang <jasowang@redhat.com> writes:
> > We're trying to re-configure the affinity unconditionally in cpu hotplug
> > callback. This may lead the issue during resuming from s3/s4 since
> >
> > - virt queues haven't been allocated at that time.
> > - it's unnecessary since thaw method will re-configure the affinity.
> >
> > Fix this issue by checking the config_enable and do nothing is we're not ready.
> >
> > The bug were introduced by commit 8de4b2f3ae90c8fc0f17eeaab87d5a951b66ee17
> > (virtio-net: reset virtqueue affinity when doing cpu hotplug).
> >
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
> > The patch is need for 3.8 and above.
>
> Please put 'CC: stable@kernel.org # 3.8+' in the commit.
Not if this is going in through the net tree.
>
> (The specification of the stable line is poor, but that seems to be one
> common method).
>
> Cheers,
> Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wanlong Gao <gaowanlong@cn.fujitsu.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready
Date: Thu, 17 Oct 2013 08:07:10 +0300 [thread overview]
Message-ID: <20131017050710.GA12141@redhat.com> (raw)
In-Reply-To: <8738o0aj9u.fsf@rustcorp.com.au>
On Thu, Oct 17, 2013 at 09:57:41AM +1030, Rusty Russell wrote:
> Jason Wang <jasowang@redhat.com> writes:
> > We're trying to re-configure the affinity unconditionally in cpu hotplug
> > callback. This may lead the issue during resuming from s3/s4 since
> >
> > - virt queues haven't been allocated at that time.
> > - it's unnecessary since thaw method will re-configure the affinity.
> >
> > Fix this issue by checking the config_enable and do nothing is we're not ready.
> >
> > The bug were introduced by commit 8de4b2f3ae90c8fc0f17eeaab87d5a951b66ee17
> > (virtio-net: reset virtqueue affinity when doing cpu hotplug).
> >
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > ---
> > The patch is need for 3.8 and above.
>
> Please put 'CC: stable@kernel.org # 3.8+' in the commit.
Not if this is going in through the net tree.
>
> (The specification of the stable line is poor, but that seems to be one
> common method).
>
> Cheers,
> Rusty.
next prev parent reply other threads:[~2013-10-17 5:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 3:18 [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Jason Wang
2013-10-15 3:18 ` Jason Wang
2013-10-15 3:18 ` [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues Jason Wang
2013-10-15 3:18 ` Jason Wang
2013-10-17 19:55 ` David Miller
2013-10-17 19:55 ` David Miller
2013-10-16 23:27 ` [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Rusty Russell
2013-10-16 23:27 ` Rusty Russell
2013-10-17 5:07 ` Michael S. Tsirkin [this message]
2013-10-17 5:07 ` Michael S. Tsirkin
2013-10-18 1:00 ` Rusty Russell
2013-10-18 1:00 ` Rusty Russell
2013-10-18 3:48 ` David Miller
2013-10-18 3:48 ` David Miller
2013-10-18 6:17 ` Rusty Russell
2013-10-18 6:17 ` Rusty Russell
2013-10-18 7:13 ` David Miller
2013-10-18 7:13 ` David Miller
2013-10-17 19:55 ` David Miller
2013-10-17 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017050710.GA12141@redhat.com \
--to=mst@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.