All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready
@ 2013-10-15  3:18 ` Jason Wang
  0 siblings, 0 replies; 20+ messages in thread
From: Jason Wang @ 2013-10-15  3:18 UTC (permalink / raw)
  To: mst, rusty, virtualization, netdev, linux-kernel

We're trying to re-configure the affinity unconditionally in cpu hotplug
callback. This may lead the issue during resuming from s3/s4 since

- virt queues haven't been allocated at that time.
- it's unnecessary since thaw method will re-configure the affinity.

Fix this issue by checking the config_enable and do nothing is we're not ready.

The bug were introduced by commit 8de4b2f3ae90c8fc0f17eeaab87d5a951b66ee17
(virtio-net: reset virtqueue affinity when doing cpu hotplug).

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
The patch is need for 3.8 and above.
---
 drivers/net/virtio_net.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index defec2b..c4bc1cc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1116,6 +1116,11 @@ static int virtnet_cpu_callback(struct notifier_block *nfb,
 {
 	struct virtnet_info *vi = container_of(nfb, struct virtnet_info, nb);
 
+	mutex_lock(&vi->config_lock);
+
+	if (!vi->config_enable)
+		goto done;
+
 	switch(action & ~CPU_TASKS_FROZEN) {
 	case CPU_ONLINE:
 	case CPU_DOWN_FAILED:
@@ -1128,6 +1133,9 @@ static int virtnet_cpu_callback(struct notifier_block *nfb,
 	default:
 		break;
 	}
+
+done:
+	mutex_unlock(&vi->config_lock);
 	return NOTIFY_OK;
 }
 
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2013-10-18  7:13 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15  3:18 [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Jason Wang
2013-10-15  3:18 ` Jason Wang
2013-10-15  3:18 ` [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues Jason Wang
2013-10-15  3:18   ` Jason Wang
2013-10-17 19:55   ` David Miller
2013-10-17 19:55     ` David Miller
2013-10-16 23:27 ` [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Rusty Russell
2013-10-16 23:27   ` Rusty Russell
2013-10-17  5:07   ` Michael S. Tsirkin
2013-10-17  5:07     ` Michael S. Tsirkin
2013-10-18  1:00     ` Rusty Russell
2013-10-18  1:00       ` Rusty Russell
2013-10-18  3:48       ` David Miller
2013-10-18  3:48         ` David Miller
2013-10-18  6:17         ` Rusty Russell
2013-10-18  6:17           ` Rusty Russell
2013-10-18  7:13           ` David Miller
2013-10-18  7:13             ` David Miller
2013-10-17 19:55 ` David Miller
2013-10-17 19:55   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.