From: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
To: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()
Date: Thu, 24 Oct 2013 13:04:06 +0100 [thread overview]
Message-ID: <20131024120406.GY14598@kernel.dk> (raw)
In-Reply-To: <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
> Cc: linux-stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # >= v3.10
> ---
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>
> if (bio->bi_rw & REQ_FLUSH) {
> /* Also need to send a flush to the backing device */
> - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
> dc->disk.bio_split);
>
> flush->bi_rw = WRITE_FLUSH;
Woops... Added.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kent Overstreet <kmo@daterainc.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()
Date: Thu, 24 Oct 2013 13:04:06 +0100 [thread overview]
Message-ID: <20131024120406.GY14598@kernel.dk> (raw)
In-Reply-To: <1382481353-4300-1-git-send-email-kmo@daterainc.com>
On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <kmo@daterainc.com>
> Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
> ---
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>
> if (bio->bi_rw & REQ_FLUSH) {
> /* Also need to send a flush to the backing device */
> - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
> dc->disk.bio_split);
>
> flush->bi_rw = WRITE_FLUSH;
Woops... Added.
--
Jens Axboe
next prev parent reply other threads:[~2013-10-24 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 22:35 [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() Kent Overstreet
[not found] ` <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
2013-10-23 9:06 ` Vasiliy Tolstov
2013-10-24 12:04 ` Jens Axboe [this message]
2013-10-24 12:04 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024120406.GY14598@kernel.dk \
--to=axboe-tswwg44o7x1aa/9udqfwiw@public.gmane.org \
--cc=kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.