* [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()
@ 2013-10-22 22:35 Kent Overstreet
[not found] ` <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Kent Overstreet @ 2013-10-22 22:35 UTC (permalink / raw)
To: torvalds, linux-kernel; +Cc: axboe, linux-bcache, Kent Overstreet
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
Cc: linux-stable <stable@vger.kernel.org> # >= v3.10
---
drivers/md/bcache/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index b6a74bc..2a7f0dd 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
if (bio->bi_rw & REQ_FLUSH) {
/* Also need to send a flush to the backing device */
- struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
+ struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
dc->disk.bio_split);
flush->bi_rw = WRITE_FLUSH;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>]
* Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() [not found] ` <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org> @ 2013-10-23 9:06 ` Vasiliy Tolstov 2013-10-24 12:04 ` Jens Axboe 1 sibling, 0 replies; 4+ messages in thread From: Vasiliy Tolstov @ 2013-10-23 9:06 UTC (permalink / raw) To: Kent Overstreet; +Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA Does this can crash or destroy data? Does i need more speed to apply it to my own kernel or i can wait? Thanks! 2013/10/23 Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>: > Signed-off-by: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org> > Cc: linux-stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # >= v3.10 > --- > drivers/md/bcache/request.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index b6a74bc..2a7f0dd 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s) > > if (bio->bi_rw & REQ_FLUSH) { > /* Also need to send a flush to the backing device */ > - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO, > + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0, > dc->disk.bio_split); > > flush->bi_rw = WRITE_FLUSH; > -- > 1.8.4.rc3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Vasiliy Tolstov, e-mail: v.tolstov-+9FY0jupvH6HXe+LvDLADg@public.gmane.org jabber: vase-+9FY0jupvH6HXe+LvDLADg@public.gmane.org ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() 2013-10-22 22:35 [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() Kent Overstreet @ 2013-10-24 12:04 ` Jens Axboe 0 siblings, 0 replies; 4+ messages in thread From: Jens Axboe @ 2013-10-24 12:04 UTC (permalink / raw) To: Kent Overstreet Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-bcache-u79uwXL29TY76Z2rM5mHXA On Tue, Oct 22 2013, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org> > Cc: linux-stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # >= v3.10 > --- > drivers/md/bcache/request.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index b6a74bc..2a7f0dd 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s) > > if (bio->bi_rw & REQ_FLUSH) { > /* Also need to send a flush to the backing device */ > - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO, > + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0, > dc->disk.bio_split); > > flush->bi_rw = WRITE_FLUSH; Woops... Added. -- Jens Axboe ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() @ 2013-10-24 12:04 ` Jens Axboe 0 siblings, 0 replies; 4+ messages in thread From: Jens Axboe @ 2013-10-24 12:04 UTC (permalink / raw) To: Kent Overstreet; +Cc: torvalds, linux-kernel, linux-bcache On Tue, Oct 22 2013, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet <kmo@daterainc.com> > Cc: linux-stable <stable@vger.kernel.org> # >= v3.10 > --- > drivers/md/bcache/request.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index b6a74bc..2a7f0dd 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s) > > if (bio->bi_rw & REQ_FLUSH) { > /* Also need to send a flush to the backing device */ > - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO, > + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0, > dc->disk.bio_split); > > flush->bi_rw = WRITE_FLUSH; Woops... Added. -- Jens Axboe ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-24 12:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 22:35 [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset() Kent Overstreet
[not found] ` <1382481353-4300-1-git-send-email-kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
2013-10-23 9:06 ` Vasiliy Tolstov
2013-10-24 12:04 ` Jens Axboe
2013-10-24 12:04 ` Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.